From patchwork Mon Nov 7 05:47:26 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 17245 Received: (qmail 75817 invoked by alias); 7 Nov 2016 05:48:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 75674 invoked by uid 89); 7 Nov 2016 05:47:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=no version=3.3.2 spammy=H*r:4.86_1, H*Ad:U*tom, H*RU:cmgw2, Hx-spam-relays-external:cmgw2 X-HELO: gproxy10-pub.mail.unifiedlayer.com Received: from gproxy10-pub.mail.unifiedlayer.com (HELO gproxy10-pub.mail.unifiedlayer.com) (69.89.20.226) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Mon, 07 Nov 2016 05:47:45 +0000 Received: (qmail 22772 invoked by uid 0); 7 Nov 2016 05:47:43 -0000 Received: from unknown (HELO cmgw2) (10.0.90.83) by gproxy10.mail.unifiedlayer.com with SMTP; 7 Nov 2016 05:47:43 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw2 with id 4tnf1u0062f2jeq01tniu0; Sun, 06 Nov 2016 22:47:42 -0700 X-Authority-Analysis: v=2.1 cv=PIacp5aC c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=L24OOQBejmoA:10 a=zstS-IiYAAAA:8 a=oaAf-FVLbl2rpzOoMCMA:9 a=4G6NA9xxw8l3yy4pmD5M:22 Received: from 174-16-143-211.hlrn.qwest.net ([174.16.143.211]:47918 helo=bapiya.Home) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1c3cmS-0008A3-Ir; Sun, 06 Nov 2016 22:47:40 -0700 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [RFA 04/14] Use gdbpy_reference in gdbpy_string_to_argv Date: Sun, 6 Nov 2016 22:47:26 -0700 Message-Id: <1478497656-11832-5-git-send-email-tom@tromey.com> In-Reply-To: <1478497656-11832-1-git-send-email-tom@tromey.com> References: <1478497656-11832-1-git-send-email-tom@tromey.com> X-BWhitelist: no X-Exim-ID: 1c3cmS-0008A3-Ir X-Source-Sender: 174-16-143-211.hlrn.qwest.net (bapiya.Home) [174.16.143.211]:47918 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== This chanes gdbpy_string_to_argv to use gdbpy_reference. 2016-11-06 Tom Tromey * python/py-cmd.c (gdbpy_string_to_argv): Use gdbpy_reference. --- gdb/ChangeLog | 4 ++++ gdb/python/py-cmd.c | 13 +++++-------- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 4475a66..1a0a21f 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,9 @@ 2016-11-06 Tom Tromey + * python/py-cmd.c (gdbpy_string_to_argv): Use gdbpy_reference. + +2016-11-06 Tom Tromey + * python/py-type.c (convert_field, make_fielditem, typy_fields) (typy_range): Use gdbpy_reference. diff --git a/gdb/python/py-cmd.c b/gdb/python/py-cmd.c index af6c5cf..80216e3 100644 --- a/gdb/python/py-cmd.c +++ b/gdb/python/py-cmd.c @@ -27,6 +27,7 @@ #include "cli/cli-decode.h" #include "completer.h" #include "language.h" +#include "py-ref.h" /* Struct representing built-in completion types. */ struct cmdpy_completer @@ -785,13 +786,12 @@ PyTypeObject cmdpy_object_type = PyObject * gdbpy_string_to_argv (PyObject *self, PyObject *args) { - PyObject *py_argv; const char *input; if (!PyArg_ParseTuple (args, "s", &input)) return NULL; - py_argv = PyList_New (0); + gdbpy_reference py_argv (PyList_New (0)); if (py_argv == NULL) return NULL; @@ -806,21 +806,18 @@ gdbpy_string_to_argv (PyObject *self, PyObject *args) for (i = 0; c_argv[i] != NULL; ++i) { - PyObject *argp = PyString_FromString (c_argv[i]); + gdbpy_reference argp (PyString_FromString (c_argv[i])); if (argp == NULL - || PyList_Append (py_argv, argp) < 0) + || PyList_Append (py_argv.get (), argp.get ()) < 0) { - Py_XDECREF (argp); - Py_DECREF (py_argv); freeargv (c_argv); return NULL; } - Py_DECREF (argp); } freeargv (c_argv); } - return py_argv; + return py_argv.release (); }