From patchwork Fri Nov 4 17:14:50 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yao Qi X-Patchwork-Id: 17194 Received: (qmail 102403 invoked by alias); 4 Nov 2016 17:15:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 98644 invoked by uid 89); 4 Nov 2016 17:15:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-pf0-f194.google.com Received: from mail-pf0-f194.google.com (HELO mail-pf0-f194.google.com) (209.85.192.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 04 Nov 2016 17:14:57 +0000 Received: by mail-pf0-f194.google.com with SMTP id i88so8467654pfk.2 for ; Fri, 04 Nov 2016 10:14:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=WcD8H+9maFCyRylsgcgHSq5E5v7J8zdRB11ZRM9zmfs=; b=mjJFIRTx6Av4N1QaC3ak0S9vJAg6IfQ3VJbMtkB0COt71t2zvVUJ7E1woQ8a8ulmeN 08Uvdpgalf/clFTC/gjjwiLzoWQg/cQrTnfL4IlocXvnoqaFKny4CawTV3O9gHDygIhr h9cHmh4aL3WhK6jx+WYZATURzGa9JncojORnVyYSssImw1VIVk5ttLfoF1Rbpsl8szZh 03IHauNcEMDOgYnmt2DH563tIY2MVNZ3m10B5/kMd+NRL+HkRYHqRQ62YV1wcdsrrSoN Bpjxaq8d2KKtnF1k9Wcrrx35ygYsTess5sDlomQdwk9FcVm9LPHH43o6tG/n5wot0/2O M6mw== X-Gm-Message-State: ABUngvdvOxPY13GAfC5HDwb0upI8CP5uph6DkwSH/ej+mtNWZ/aiXM/7wlm6rbHoGIEUPg== X-Received: by 10.99.168.78 with SMTP id i14mr23626966pgp.162.1478279695955; Fri, 04 Nov 2016 10:14:55 -0700 (PDT) Received: from E107787-LIN.cambridge.arm.com (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id xn11sm21769337pac.38.2016.11.04.10.14.55 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 04 Nov 2016 10:14:55 -0700 (PDT) From: Yao Qi X-Google-Original-From: Yao Qi To: gdb-patches@sourceware.org Subject: [PATCH 1/2] use get_frame_register_value instead of deprecated_frame_register_read Date: Fri, 4 Nov 2016 17:14:50 +0000 Message-Id: <1478279691-25682-2-git-send-email-yao.qi@linaro.org> In-Reply-To: <1478279691-25682-1-git-send-email-yao.qi@linaro.org> References: <1478279691-25682-1-git-send-email-yao.qi@linaro.org> X-IsSubscribed: yes This patch calls get_frame_register_value instead of deprecated_frame_register_read, so that we can pass value_contents_for_printing to val_print. Both get_frame_register_value and deprecated_frame_register_read call frame_unwind_register_value indirectly, so no functionality is changed by this patch. gdb: 2016-11-04 Yao Qi * mt-tdep.c (mt_registers_info): Call get_frame_register_value instead of deprecated_frame_register_read. * sh64-tdep.c (sh64_do_register): Likewise. --- gdb/mt-tdep.c | 10 +++++----- gdb/sh64-tdep.c | 15 +++++++++------ 2 files changed, 14 insertions(+), 11 deletions(-) diff --git a/gdb/mt-tdep.c b/gdb/mt-tdep.c index 95dd681..c08e805 100644 --- a/gdb/mt-tdep.c +++ b/gdb/mt-tdep.c @@ -712,11 +712,10 @@ mt_registers_info (struct gdbarch *gdbarch, || regnum == MT_COPRO_PSEUDOREG_REGNUM) { /* Special output handling for the 'coprocessor' register. */ - gdb_byte *buf; struct value_print_options opts; + struct value *val; - buf = (gdb_byte *) alloca (register_size (gdbarch, MT_COPRO_REGNUM)); - deprecated_frame_register_read (frame, MT_COPRO_REGNUM, buf); + val = get_frame_register_value (frame, MT_COPRO_REGNUM); /* And print. */ regnum = MT_COPRO_PSEUDOREG_REGNUM; fputs_filtered (gdbarch_register_name (gdbarch, regnum), @@ -726,8 +725,9 @@ mt_registers_info (struct gdbarch *gdbarch, file); get_no_prettyformat_print_options (&opts); opts.deref_ref = 1; - val_print (register_type (gdbarch, regnum), buf, - 0, 0, file, 0, NULL, + val_print (register_type (gdbarch, regnum), + value_contents_for_printing (val), + 0, 0, file, 0, val, &opts, current_language); fputs_filtered ("\n", file); } diff --git a/gdb/sh64-tdep.c b/gdb/sh64-tdep.c index cbbefdd..9054e20 100644 --- a/gdb/sh64-tdep.c +++ b/gdb/sh64-tdep.c @@ -2030,15 +2030,16 @@ static void sh64_do_register (struct gdbarch *gdbarch, struct ui_file *file, struct frame_info *frame, int regnum) { - unsigned char raw_buffer[MAX_REGISTER_SIZE]; struct value_print_options opts; + struct value *val; fputs_filtered (gdbarch_register_name (gdbarch, regnum), file); print_spaces_filtered (15 - strlen (gdbarch_register_name (gdbarch, regnum)), file); /* Get the data in raw format. */ - if (!deprecated_frame_register_read (frame, regnum, raw_buffer)) + val = get_frame_register_value (frame, regnum); + if (value_optimized_out (val) || !value_entirely_available (val)) { fprintf_filtered (file, "*value not available*\n"); return; @@ -2046,13 +2047,15 @@ sh64_do_register (struct gdbarch *gdbarch, struct ui_file *file, get_formatted_print_options (&opts, 'x'); opts.deref_ref = 1; - val_print (register_type (gdbarch, regnum), raw_buffer, 0, 0, - file, 0, NULL, &opts, current_language); + val_print (register_type (gdbarch, regnum), + value_contents_for_printing (val), 0, 0, + file, 0, val, &opts, current_language); fprintf_filtered (file, "\t"); get_formatted_print_options (&opts, 0); opts.deref_ref = 1; - val_print (register_type (gdbarch, regnum), raw_buffer, 0, 0, - file, 0, NULL, &opts, current_language); + val_print (register_type (gdbarch, regnum), + value_contents_for_printing (val), 0, 0, + file, 0, val, &opts, current_language); fprintf_filtered (file, "\n"); }