From patchwork Thu Oct 13 14:38:28 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yao Qi X-Patchwork-Id: 16474 Received: (qmail 13971 invoked by alias); 13 Oct 2016 14:38:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 13955 invoked by uid 89); 13 Oct 2016 14:38:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RCVD_IN_SORBS_SPAM, SPF_PASS, URIBL_RED autolearn=ham version=3.3.2 spammy=36, 8, Hx-languages-length:4641, tll, tld X-HELO: mail-pf0-f196.google.com Received: from mail-pf0-f196.google.com (HELO mail-pf0-f196.google.com) (209.85.192.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Oct 2016 14:38:36 +0000 Received: by mail-pf0-f196.google.com with SMTP id i85so1808677pfa.0 for ; Thu, 13 Oct 2016 07:38:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id; bh=JBgvNUess0CuqNCXKhogwQt1ONMZ8dEx1o6s46KFoEY=; b=L/zXdpCiYdGccnvpClZZf0RSqin0H75/Tj9ACQQ8KOkkcCkc0v5P2deVWrHuPvna0h DYQzFtES4G/ZZaIJWC7cYnBViWAsxQubeTyxLPiJSa3qTAWR4uejoUOtIsGkiXZjzoQ9 ZAZEoYqsXZY2H9EReDOQ8585sYRGDx1w5cFgKiRY9QSj519EHxmHcHNmZQf4EZXJ/wuh LrF+K2MoYNPP9s4uoqaFvVmqBS9zgf2aYeFkfpG+08MYIAB+25oQJu3LdjjEomBXir3k 1qfmP86rH6nK/Md3HbC2jfYKwqL4n2aZfCxkZF8W2jON21CkVkWZHYXhaqMTLWzbmFGf pxgQ== X-Gm-Message-State: AA6/9Rn1sXeRrOMAKDNY1Qxp7eHFGeYyAqn90SDtpHwz3XEeHjrSd20lhX/eZl2gVaRiyw== X-Received: by 10.98.59.66 with SMTP id i63mr10583321pfa.124.1476369514791; Thu, 13 Oct 2016 07:38:34 -0700 (PDT) Received: from E107787-LIN.cambridge.arm.com (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id n77sm20288773pfi.82.2016.10.13.07.38.33 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 13 Oct 2016 07:38:34 -0700 (PDT) From: Yao Qi X-Google-Original-From: Yao Qi To: gdb-patches@sourceware.org Subject: [PUSHED] Skip testing structures with floating points Date: Thu, 13 Oct 2016 15:38:28 +0100 Message-Id: <1476369508-11074-1-git-send-email-yao.qi@linaro.org> X-IsSubscribed: yes This patch skips some tests related to floating point in structs.exp if gdb_skip_float_test return false. gdb/testsuite: 2016-10-13 Yao Qi * gdb.base/structs.exp: Invoke gdb_skip_float_test, and do floating point tests if $skip_float_test is false. --- gdb/testsuite/ChangeLog | 5 ++ gdb/testsuite/gdb.base/structs.exp | 119 ++++++++++++++++++++----------------- 2 files changed, 68 insertions(+), 56 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 21ee095..18dd701 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2016-10-13 Yao Qi + + * gdb.base/structs.exp: Invoke gdb_skip_float_test, and do + floating point tests if $skip_float_test is false. + 2016-10-12 Luis Machado * gdb.python/py-value.c (main): Check if argv is NULL before using it. diff --git a/gdb/testsuite/gdb.base/structs.exp b/gdb/testsuite/gdb.base/structs.exp index c525340..4fcef52 100644 --- a/gdb/testsuite/gdb.base/structs.exp +++ b/gdb/testsuite/gdb.base/structs.exp @@ -36,6 +36,8 @@ if [get_compiler_info] { return -1 } +set skip_float_test [gdb_skip_float_test] + # Compile a variant of structs.c using TYPES to specify the type of # the first N struct elements (the remaining elements take the type of # the last TYPES field). Run the compmiled program up to "main". @@ -563,25 +565,27 @@ test_struct_calls 1 test_struct_calls 2 test_struct_returns 1 -# Approx size: 4, 8, ... -start_structs_test { tf } -test_struct_calls 1 -test_struct_calls 2 -test_struct_calls 3 -test_struct_returns 1 -test_struct_returns 2 - -# Approx size: 8, 16, ... -start_structs_test { td } -test_struct_calls 1 -test_struct_calls 2 -test_struct_returns 1 - -# Approx size: 16, 32, ... -start_structs_test { tld } -test_struct_calls 1 -test_struct_calls 2 -test_struct_returns 1 +if { !$skip_float_test } { + # Approx size: 4, 8, ... + start_structs_test { tf } + test_struct_calls 1 + test_struct_calls 2 + test_struct_calls 3 + test_struct_returns 1 + test_struct_returns 2 + + # Approx size: 8, 16, ... + start_structs_test { td } + test_struct_calls 1 + test_struct_calls 2 + test_struct_returns 1 + + # Approx size: 16, 32, ... + start_structs_test { tld } + test_struct_calls 1 + test_struct_calls 2 + test_struct_returns 1 +} # Approx size: 2+1=3, 4, ... start_structs_test { ts tc } @@ -616,22 +620,24 @@ test_struct_returns 2 start_structs_test { tll tc } test_struct_calls 2 -# Approx size: 4+1=5, 6, ... -start_structs_test { tf tc } -test_struct_calls 2 -test_struct_calls 3 -test_struct_calls 4 -test_struct_calls 5 -test_struct_calls 6 -test_struct_returns 2 - -# Approx size: 8+1=9, 10, ... -start_structs_test { td tc } -test_struct_calls 2 - -# Approx size: 16+1=17, 18, ... -start_structs_test { tld tc } -test_struct_calls 2 +if { !$skip_float_test } { + # Approx size: 4+1=5, 6, ... + start_structs_test { tf tc } + test_struct_calls 2 + test_struct_calls 3 + test_struct_calls 4 + test_struct_calls 5 + test_struct_calls 6 + test_struct_returns 2 + + # Approx size: 8+1=9, 10, ... + start_structs_test { td tc } + test_struct_calls 2 + + # Approx size: 16+1=17, 18, ... + start_structs_test { tld tc } + test_struct_calls 2 +} # Approx size: (1+1)+2=4, 6, ... start_structs_test { tc ts } @@ -660,30 +666,31 @@ test_struct_returns 2 start_structs_test { tc tll } test_struct_calls 2 -# Approx size: (1+3)+4=8, 12, ... -start_structs_test { tc tf } -test_struct_calls 2 -test_struct_calls 3 -test_struct_calls 4 +if { !$skip_float_test } { + # Approx size: (1+3)+4=8, 12, ... + start_structs_test { tc tf } + test_struct_calls 2 + test_struct_calls 3 + test_struct_calls 4 -# Approx size: (1+7)+8=16, 24, ... -start_structs_test { tc td } -test_struct_calls 2 - -# Approx size: (1+15)+16=32, 48, ... -start_structs_test { tc tld } -test_struct_calls 2 + # Approx size: (1+7)+8=16, 24, ... + start_structs_test { tc td } + test_struct_calls 2 -# Some float combinations + # Approx size: (1+15)+16=32, 48, ... + start_structs_test { tc tld } + test_struct_calls 2 -# Approx size: 8+4=12, 16, ... -start_structs_test { td tf } -test_struct_calls 2 -test_struct_returns 2 + # Some float combinations -# Approx size: (4+4)+8=16, 32, ... -start_structs_test { tf td } -test_struct_calls 2 -test_struct_returns 2 + # Approx size: 8+4=12, 16, ... + start_structs_test { td tf } + test_struct_calls 2 + test_struct_returns 2 + # Approx size: (4+4)+8=16, 32, ... + start_structs_test { tf td } + test_struct_calls 2 + test_struct_returns 2 +} return 0