From patchwork Mon Oct 3 21:54:04 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 16224 Received: (qmail 55951 invoked by alias); 3 Oct 2016 21:54:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 55906 invoked by uid 89); 3 Oct 2016 21:54:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.0 required=5.0 tests=AWL, BAYES_00, KAM_STOCKGEN, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=no version=3.3.2 spammy=7.11.1, 7111, memcmp, H*RU:69.89.20.122 X-HELO: gproxy9-pub.mail.unifiedlayer.com Received: from gproxy9-pub.mail.unifiedlayer.com (HELO gproxy9-pub.mail.unifiedlayer.com) (69.89.20.122) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Mon, 03 Oct 2016 21:54:14 +0000 Received: (qmail 15065 invoked by uid 0); 3 Oct 2016 21:54:13 -0000 Received: from unknown (HELO cmgw2) (10.0.90.83) by gproxy9.mail.unifiedlayer.com with SMTP; 3 Oct 2016 21:54:13 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw2 with id r9u81t00Y2f2jeq019uBYz; Mon, 03 Oct 2016 15:54:11 -0600 X-Authority-Analysis: v=2.1 cv=dJg1xopb c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=CH0kA5CcgfcA:10 a=zstS-IiYAAAA:8 a=20KFwNOVAAAA:8 a=i49xpifMpA7X4oni7RkA:9 a=4G6NA9xxw8l3yy4pmD5M:22 a=e_O65bzb51kRm2y5VmPK:22 Received: from 71-218-192-86.hlrn.qwest.net ([71.218.192.86]:36324 helo=bapiya.Home) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1brBBZ-0001qc-Kn; Mon, 03 Oct 2016 15:54:09 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [RFA 1/3] PR symtab/20652 - fix psymbol_compare Date: Mon, 3 Oct 2016 15:54:04 -0600 Message-Id: <1475531646-18049-2-git-send-email-tom@tromey.com> In-Reply-To: <1475531646-18049-1-git-send-email-tom@tromey.com> References: <1475531646-18049-1-git-send-email-tom@tromey.com> X-BWhitelist: no X-Exim-ID: 1brBBZ-0001qc-Kn X-Source-Sender: 71-218-192-86.hlrn.qwest.net (bapiya.Home) [71.218.192.86]:36324 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== This fixes an oversight in psymbol_compare. 2016-10-03 Tom Tromey PR symtab/20652: * psymtab.c (psymbol_compare): Correctly compare "ginfo.value" fields. --- gdb/ChangeLog | 6 ++++++ gdb/psymtab.c | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index ffbdc3d..434f750 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2016-10-03 Tom Tromey + + PR symtab/20652: + * psymtab.c (psymbol_compare): Correctly compare "ginfo.value" + fields. + 2016-09-29 Jan Kratochvil PR gdb/20609 - attach of JIT-debug-enabled inf 7.11.1 regression diff --git a/gdb/psymtab.c b/gdb/psymtab.c index a39c6e2..edcaa8b 100644 --- a/gdb/psymtab.c +++ b/gdb/psymtab.c @@ -1577,7 +1577,7 @@ psymbol_compare (const void *addr1, const void *addr2, int length) struct partial_symbol *sym1 = (struct partial_symbol *) addr1; struct partial_symbol *sym2 = (struct partial_symbol *) addr2; - return (memcmp (&sym1->ginfo.value, &sym1->ginfo.value, + return (memcmp (&sym1->ginfo.value, &sym2->ginfo.value, sizeof (sym1->ginfo.value)) == 0 && sym1->ginfo.language == sym2->ginfo.language && PSYMBOL_DOMAIN (sym1) == PSYMBOL_DOMAIN (sym2)