From patchwork Tue Sep 27 18:16:31 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 16085 Received: (qmail 75966 invoked by alias); 27 Sep 2016 18:16:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 75865 invoked by uid 89); 27 Sep 2016 18:16:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:1857, 1797 X-HELO: gproxy5-pub.mail.unifiedlayer.com Received: from gproxy5-pub.mail.unifiedlayer.com (HELO gproxy5-pub.mail.unifiedlayer.com) (67.222.38.55) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Tue, 27 Sep 2016 18:16:45 +0000 Received: (qmail 23404 invoked by uid 0); 27 Sep 2016 18:16:44 -0000 Received: from unknown (HELO cmgw2) (10.0.90.83) by gproxy5.mail.unifiedlayer.com with SMTP; 27 Sep 2016 18:16:44 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw2 with id oiGf1t00j2f2jeq01iGiLD; Tue, 27 Sep 2016 12:16:42 -0600 X-Authority-Analysis: v=2.1 cv=F4vEKMRN c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=GW1xBdLrtEIA:10 a=zstS-IiYAAAA:8 a=vVQOq55otKHWDHCESfkA:9 a=4G6NA9xxw8l3yy4pmD5M:22 Received: from 71-218-192-86.hlrn.qwest.net ([71.218.192.86]:60956 helo=bapiya.Home) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1bowvo-0000eX-S8; Tue, 27 Sep 2016 12:16:40 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [RFA 2/3] Add missing ATTRIBUTE_NORETURNs Date: Tue, 27 Sep 2016 12:16:31 -0600 Message-Id: <1475000192-8789-3-git-send-email-tom@tromey.com> In-Reply-To: <1475000192-8789-1-git-send-email-tom@tromey.com> References: <1475000192-8789-1-git-send-email-tom@tromey.com> X-BWhitelist: no X-Exim-ID: 1bowvo-0000eX-S8 X-Source-Sender: 71-218-192-86.hlrn.qwest.net (bapiya.Home) [71.218.192.86]:60956 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== This patch adds a couple of missing ATTRIBUTE_NORETURNs. This lets -Wimplicit-fallthrough recognize that a given case does not fall through. 2016-09-27 Tom Tromey * dwarf2loc.c (unimplemented): Add ATTRIBUTE_NORETURN. * completer.h (throw_max_completions_reached_error): Add ATTRIBUTE_NORETURN. --- gdb/ChangeLog | 6 ++++++ gdb/completer.h | 3 ++- gdb/dwarf2loc.c | 2 +- 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index fdd43ab..83b051f 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,11 @@ 2016-09-27 Tom Tromey + * dwarf2loc.c (unimplemented): Add ATTRIBUTE_NORETURN. + * completer.h (throw_max_completions_reached_error): Add + ATTRIBUTE_NORETURN. + +2016-09-27 Tom Tromey + * xcoffread.c (scan_xcoff_symtab): Move comment later. * symfile.c (section_is_mapped): Fix fall-through comment. * stabsread.c (define_symbol, read_member_functions): Fix diff --git a/gdb/completer.h b/gdb/completer.h index 24bfee9..ff01f86 100644 --- a/gdb/completer.h +++ b/gdb/completer.h @@ -179,6 +179,7 @@ extern enum maybe_add_completion_enum /* Wrapper to throw MAX_COMPLETIONS_REACHED_ERROR. */ -extern void throw_max_completions_reached_error (void); +extern void throw_max_completions_reached_error (void) + ATTRIBUTE_NORETURN; #endif /* defined (COMPLETER_H) */ diff --git a/gdb/dwarf2loc.c b/gdb/dwarf2loc.c index f9f3216..a29c9ed 100644 --- a/gdb/dwarf2loc.c +++ b/gdb/dwarf2loc.c @@ -2917,7 +2917,7 @@ dwarf2_loc_desc_get_symbol_read_needs (const gdb_byte *data, size_t size, /* A helper function that throws an unimplemented error mentioning a given DWARF operator. */ -static void +static void ATTRIBUTE_NORETURN unimplemented (unsigned int op) { const char *name = get_DW_OP_name (op);