From patchwork Thu Jul 21 13:36:59 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yao Qi X-Patchwork-Id: 13905 Received: (qmail 53038 invoked by alias); 21 Jul 2016 13:37:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 53024 invoked by uid 89); 21 Jul 2016 13:37:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-pf0-f196.google.com Received: from mail-pf0-f196.google.com (HELO mail-pf0-f196.google.com) (209.85.192.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 21 Jul 2016 13:37:11 +0000 Received: by mail-pf0-f196.google.com with SMTP id g202so5518363pfb.1 for ; Thu, 21 Jul 2016 06:37:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id; bh=6lq24Kp8kxe/Y51c0lDhRF0EHc960fAvqJ3bDwbDjo0=; b=R8ufHnZ7OYxTGE33DDPbhNowdArdTLSFyIXgKm1MA/PJXaqYg2LYN/PPx73z/2nvPi JxNXO7FVUjJ99QUnRlfSxlxzNIohv6w7uKixQm1k4yVtHQrTENTGCoTjmaouf+yEd3jl XyWRF1cjOD1gZmTtTBQFDpWwETTQqBNZZmfE9Lfv8wfn1gx3HEaEME5Cr7r58Ew1sYn4 /BKqcruuIe5X68v+el3dFq2KEqBHeHEZf6D8KBv9bA1MjmmyKuEUsbaSgo9qpiRk4Kk8 866r92rHU2Toa4T6Pu4Ur910uTgH6rLeRCwA+mMHKFSDU/K3IxYbJEad5ZXJ1bsN7k0m MXCQ== X-Gm-Message-State: ALyK8tL7VYGDigLoIhQjjj/5Asjr98olJDdXUX4KeiIJBkIluwZ9Dm4H62NtaOH4bon6+A== X-Received: by 10.98.26.133 with SMTP id a127mr72279019pfa.46.1469108229450; Thu, 21 Jul 2016 06:37:09 -0700 (PDT) Received: from E107787-LIN.cambridge.arm.com (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id fj19sm12564619pab.37.2016.07.21.06.37.08 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 21 Jul 2016 06:37:08 -0700 (PDT) From: Yao Qi X-Google-Original-From: Yao Qi To: gdb-patches@sourceware.org Subject: [PATCH committed] Fix cast to 'gdb_breakpoint *' Date: Thu, 21 Jul 2016 14:36:59 +0100 Message-Id: <1469108219-3204-1-git-send-email-yao.qi@linaro.org> X-IsSubscribed: yes c-mode buildbot catches a build problem, gcc -g -O2 -I. -I../../../binutils-gdb/gdb/gdbserver -I../../../binutils-gdb/gdb/gdbserver/../common -I../../../binutils-gdb/gdb/gdbserver/../regformats -I../../../binutils-gdb/gdb/gdbserver/.. -I../../../binutils-gdb/gdb/gdbserver/../../include -I../../../binutils-gdb/gdb/gdbserver/../gnulib/import -Ibuild-gnulib-gdbserver/import -Wall -Wpointer-arith -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wempty-body -Wpointer-sign -Wmissing-prototypes -Wdeclaration-after-statement -Wmissing-parameter-type -Wold-style-declaration -Wold-style-definition -Wformat-nonliteral -Wno-missing-prototypes -Werror -DGDBSERVER -c -o hostio.o -MT hostio.o -MMD -MP -MF .deps/hostio.Tpo ../../../binutils-gdb/gdb/gdbserver/hostio.c ../../../binutils-gdb/gdb/gdbserver/mem-break.c: In function find_gdb_breakpoint: ../../../binutils-gdb/gdb/gdbserver/mem-break.c:996:15: error: gdb_breakpoint undeclared (first use in this function) return (gdb_breakpoint *) bp; we should use 'struct gdb_breakpoint' rather than 'gdb_breakpoint'. Patch below fixes this. gdb/gdbserver: 2016-07-21 Yao Qi * mem-break.c (find_gdb_breakpoint): Cast bp to 'struct gdb_breakpoint *' rather than 'gdb_breakpoint *'. --- gdb/gdbserver/ChangeLog | 5 +++++ gdb/gdbserver/mem-break.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index 1592a11..4156790 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,5 +1,10 @@ 2016-07-21 Yao Qi + * mem-break.c (find_gdb_breakpoint): Cast bp to + 'struct gdb_breakpoint *' rather than 'gdb_breakpoint *'. + +2016-07-21 Yao Qi + * server.c (handle_v_requests): Support s and S actions if target_supports_software_single_step return true. diff --git a/gdb/gdbserver/mem-break.c b/gdb/gdbserver/mem-break.c index 65ca3f9..7cd037f 100644 --- a/gdb/gdbserver/mem-break.c +++ b/gdb/gdbserver/mem-break.c @@ -996,7 +996,7 @@ find_gdb_breakpoint (char z_type, CORE_ADDR addr, int kind) for (bp = proc->breakpoints; bp != NULL; bp = bp->next) if (bp->type == type && bp->raw->pc == addr && (kind == -1 || bp->raw->kind == kind)) - return (gdb_breakpoint *) bp; + return (struct gdb_breakpoint *) bp; return NULL; }