From patchwork Fri Jul 15 15:43:38 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 13811 Received: (qmail 82458 invoked by alias); 15 Jul 2016 15:44:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 82428 invoked by uid 89); 15 Jul 2016 15:44:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=among X-HELO: gproxy5-pub.mail.unifiedlayer.com Received: from gproxy5-pub.mail.unifiedlayer.com (HELO gproxy5-pub.mail.unifiedlayer.com) (67.222.38.55) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Fri, 15 Jul 2016 15:43:50 +0000 Received: (qmail 1668 invoked by uid 0); 15 Jul 2016 15:43:48 -0000 Received: from unknown (HELO cmgw3) (10.0.90.84) by gproxy5.mail.unifiedlayer.com with SMTP; 15 Jul 2016 15:43:48 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id K3jk1t00R2f2jeq013jnsi; Fri, 15 Jul 2016 09:43:48 -0600 X-Authority-Analysis: v=2.1 cv=LOD1Hvm9 c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=PnD2wP_eR3oA:10 a=C6ZbYQPAFpEA:10 a=cAmyUtKerLwA:10 a=zstS-IiYAAAA:8 a=6I5d2MoRAAAA:8 a=EyoeE4aQD08zMBX1x_cA:9 a=4G6NA9xxw8l3yy4pmD5M:22 a=IjZwj45LgO3ly-622nXo:22 Received: from [75.171.160.169] (port=43818 helo=bapiya.Home) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_2) (envelope-from ) id 1bO5HE-0001nh-Bg; Fri, 15 Jul 2016 09:43:44 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [RFA] Allow use of ATTRIBUTE_UNUSED in gdb Date: Fri, 15 Jul 2016 09:43:38 -0600 Message-Id: <1468597418-28043-1-git-send-email-tom@tromey.com> X-Identified-User: {36111:box522.bluehost.com:elynrobi:tromey.com} {sentby:smtp auth 75.171.160.169 authed with tom+tromey.com} X-Exim-ID: 1bO5HE-0001nh-Bg X-Source-Sender: (bapiya.Home) [75.171.160.169]:43818 X-Source-Auth: tom+tromey.com X-Email-Count: 0 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== Recently gdb was changed to add a few uses of ATTRIBUTE_UNUSED. This is useful for -Wunused-but-set-variable, among other things. This patch changes ARI to allow these uses. Tested by re-running ARI locally. 2016-07-15 Tom Tromey * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED rule. --- gdb/ChangeLog | 4 ++++ gdb/contrib/ari/gdb_ari.sh | 11 ----------- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 6c187dc..c10b9b3 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2016-07-15 Tom Tromey + + * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED rule. + 2016-07-15 John Baldwin * common/signals.c (gdb_signal_from_host): Handle SIGLIBRT. diff --git a/gdb/contrib/ari/gdb_ari.sh b/gdb/contrib/ari/gdb_ari.sh index 43f0206..3670624 100644 --- a/gdb/contrib/ari/gdb_ari.sh +++ b/gdb/contrib/ari/gdb_ari.sh @@ -620,17 +620,6 @@ Do not use `long long'\'', instead use LONGEST" fail("long long") } -BEGIN { doc["ATTRIBUTE_UNUSED"] = "\ -Do not use ATTRIBUTE_UNUSED, do not bother (GDB is compiled with -Werror and, \ -consequently, is not able to tolerate false warnings. Since -Wunused-param \ -produces such warnings, neither that warning flag nor ATTRIBUTE_UNUSED \ -are used by GDB" - category["ATTRIBUTE_UNUSED"] = ari_regression -} -/(^|[^_[:alnum:]])ATTRIBUTE_UNUSED([^_[:alnum:]]|$)/ { - fail("ATTRIBUTE_UNUSED") -} - BEGIN { doc["ATTR_FORMAT"] = "\ Do not use ATTR_FORMAT, use ATTRIBUTE_PRINTF instead" category["ATTR_FORMAT"] = ari_regression