From patchwork Thu Jun 9 16:46:28 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 12921 Received: (qmail 39115 invoked by alias); 9 Jun 2016 16:46:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 39106 invoked by uid 89); 9 Jun 2016 16:46:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=AWL, BAYES_00, FSL_HELO_HOME, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=no version=3.3.2 spammy=HX-Identified-User:sentby, HX-Identified-User:auth, HX-Identified-User:authed, HX-Identified-User:smtp X-HELO: gproxy1-pub.mail.unifiedlayer.com Received: from gproxy1-pub.mail.unifiedlayer.com (HELO gproxy1-pub.mail.unifiedlayer.com) (69.89.25.95) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Thu, 09 Jun 2016 16:46:44 +0000 Received: (qmail 28335 invoked by uid 0); 9 Jun 2016 16:46:40 -0000 Received: from unknown (HELO cmgw2) (10.0.90.83) by gproxy1.mail.unifiedlayer.com with SMTP; 9 Jun 2016 16:46:40 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw2 with id 4gmZ1t01U2f2jeq01gmcuD; Thu, 09 Jun 2016 10:46:38 -0600 X-Authority-Analysis: v=2.1 cv=ff4+lSgF c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=PnD2wP_eR3oA:10 a=-N9Dh3nx2ZYA:10 a=pD_ry4oyNxEA:10 a=zstS-IiYAAAA:8 a=0FD05c-RAAAA:8 a=XtSApF_AqrY8UhYa-psA:9 a=4G6NA9xxw8l3yy4pmD5M:22 a=l1rpMCqCXRGZwUSuRcM3:22 Received: from [65.128.48.199] (port=34944 helo=bapiya.Home) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_2) (envelope-from ) id 1bB36I-0000oP-Oo; Thu, 09 Jun 2016 10:46:34 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [RFA] PR python/19819 - remove unused globals from py-xmethods.c Date: Thu, 9 Jun 2016 10:46:28 -0600 Message-Id: <1465490788-8356-1-git-send-email-tom@tromey.com> X-Identified-User: {36111:box522.bluehost.com:elynrobi:tromey.com} {sentby:smtp auth 65.128.48.199 authed with tom+tromey.com} X-Exim-ID: 1bB36I-0000oP-Oo X-Source-Sender: (bapiya.Home) [65.128.48.199]:34944 X-Source-Auth: tom+tromey.com X-Email-Count: 0 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== PR python/19819 concerns some unused global variables in py-xmethods.c. This patch deletes the unused globals. Tested by rebuilding. 2016-06-09 Tom Tromey PR python/19819: * python/py-xmethods.c (invoke_method_name) (py_get_result_type_method_name, py_invoke_method_name): Remove. (gdbpy_initialize_xmethods): Don't initialize py_invoke_method_name, py_get_result_type_method_name. --- gdb/ChangeLog | 8 ++++++++ gdb/python/py-xmethods.c | 12 ------------ 2 files changed, 8 insertions(+), 12 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 9c09269..72f8a3e 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,11 @@ +2016-06-09 Tom Tromey + + PR python/19819: + * python/py-xmethods.c (invoke_method_name) + (py_get_result_type_method_name, py_invoke_method_name): Remove. + (gdbpy_initialize_xmethods): Don't initialize + py_invoke_method_name, py_get_result_type_method_name. + 2016-06-07 Simon Marchi * mi/mi-interp.c (mi_record_changed): Add missing braces. diff --git a/gdb/python/py-xmethods.c b/gdb/python/py-xmethods.c index 58bb783..48205d8 100644 --- a/gdb/python/py-xmethods.c +++ b/gdb/python/py-xmethods.c @@ -31,13 +31,10 @@ static const char enabled_field_name[] = "enabled"; static const char match_method_name[] = "match"; static const char get_arg_types_method_name[] = "get_arg_types"; static const char get_result_type_method_name[] = "get_result_type"; -static const char invoke_method_name[] = "invoke"; static const char matchers_attr_str[] = "xmethods"; static PyObject *py_match_method_name = NULL; static PyObject *py_get_arg_types_method_name = NULL; -static PyObject *py_get_result_type_method_name = NULL; -static PyObject *py_invoke_method_name = NULL; struct gdbpy_worker_data { @@ -735,19 +732,10 @@ gdbpy_initialize_xmethods (void) if (py_match_method_name == NULL) return -1; - py_invoke_method_name = PyString_FromString (invoke_method_name); - if (py_invoke_method_name == NULL) - return -1; - py_get_arg_types_method_name = PyString_FromString (get_arg_types_method_name); if (py_get_arg_types_method_name == NULL) return -1; - py_get_result_type_method_name - = PyString_FromString (get_result_type_method_name); - if (py_get_result_type_method_name == NULL) - return -1; - return 1; }