From patchwork Wed Jun 8 09:26:16 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 12874 Received: (qmail 42864 invoked by alias); 8 Jun 2016 09:26:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 42819 invoked by uid 89); 8 Jun 2016 09:26:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=2016-06-08 X-HELO: mail-wm0-f47.google.com Received: from mail-wm0-f47.google.com (HELO mail-wm0-f47.google.com) (74.125.82.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 08 Jun 2016 09:26:32 +0000 Received: by mail-wm0-f47.google.com with SMTP id n184so172335877wmn.1 for ; Wed, 08 Jun 2016 02:26:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=2J05F/jydrMDDoa22a8Sodl9n4D9mwGJt/naGvBfp+4=; b=CZJQtraHT3txwDZd8m4sXtDX/rIknn7D13BUNwaDqOyqu06aIyme5bOmiLIX9FjuRk rE8KuvKc66YWOHCH/dv5PowJdgAQIRZauA+1ttO9MNljt1xRMHmBoDK1LuNqZZQaHa0K OSof1M4VmBh91kORWshkvR0p4V8OLmzowf4IaWw7KOvYGWpnMAfHsR0NJKi4yxp07/m3 xuIRGNw3I22IRxhaNWQ4kk5Y+6adr/7F+SSMD8CUghnWrUY/YXsyWKz2MceAw9ax7iw/ e1sXdFjVT1gMxSOyRzNHERBskKa/Bh2lDdhiCH7ak6g7zPgGRepC+4CjaZPqw175nBxg /fxQ== X-Gm-Message-State: ALyK8tL+qNNemWNnVqoeI+Nhbc5UzUeB6eG4LrD/y0xNvCptN/TWO5Yv6+XotiCzqCtlcw== X-Received: by 10.194.84.74 with SMTP id w10mr3453488wjy.118.1465377989006; Wed, 08 Jun 2016 02:26:29 -0700 (PDT) Received: from localhost (cust64-dsl91-135-5.idnet.net. [91.135.5.64]) by smtp.gmail.com with ESMTPSA id o203sm23755334wmg.22.2016.06.08.02.26.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Jun 2016 02:26:28 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH] gdb: Use UNSUPPORTED not FAIL for unsupported target features Date: Wed, 8 Jun 2016 10:26:16 +0100 Message-Id: <1465377976-21678-1-git-send-email-andrew.burgess@embecosm.com> X-IsSubscribed: yes If a target does not support making function calls from GDB then we abandon the gdb.base/callfuncs.exp test file early. Currently we report a single FAIL before leaving the test file, this commit changes this to a single UNSUPPORTED. gdb/testsuite/ChangeLog: * gdb.base/callfuncs.exp: Report unsupported rather than fail for unsupported target features. --- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/gdb.base/callfuncs.exp | 3 +-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 98a798b..9a08c73 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2016-06-08 Andrew Burgess + + * gdb.base/callfuncs.exp: Report unsupported rather than fail for + unsupported target features. + 2016-06-06 Simon Marchi * gdb.mi/mi-record-changed.exp: Adjust =record-started output diff --git a/gdb/testsuite/gdb.base/callfuncs.exp b/gdb/testsuite/gdb.base/callfuncs.exp index fbe896c..1ec33d8 100644 --- a/gdb/testsuite/gdb.base/callfuncs.exp +++ b/gdb/testsuite/gdb.base/callfuncs.exp @@ -26,8 +26,7 @@ if [support_complex_tests] { # Some targets can't do function calls, so don't even bother with this # test. if [target_info exists gdb,cannot_call_functions] { - setup_xfail "*-*-*" 2416 - fail "This target can not call functions" + unsupported "This target can not call functions" continue }