From patchwork Wed Apr 6 03:15:42 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 11644 Received: (qmail 46995 invoked by alias); 6 Apr 2016 03:15:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 46887 invoked by uid 89); 6 Apr 2016 03:15:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=BAYES_00, SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=Hx-spam-relays-external:sk:cable-1, H*r:sk:cable-1, H*RU:sk:cable-1, brand X-HELO: smtp.electronicbox.net Received: from smtp.electronicbox.net (HELO smtp.electronicbox.net) (96.127.255.82) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 06 Apr 2016 03:15:48 +0000 Received: from localhost.localdomain (cable-192.222.137.139.electronicbox.net [192.222.137.139]) by smtp.electronicbox.net (Postfix) with ESMTP id 00710440E80; Tue, 5 Apr 2016 23:15:45 -0400 (EDT) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 3/4] Fix detach.exp remote check Date: Tue, 5 Apr 2016 23:15:42 -0400 Message-Id: <1459912543-15328-3-git-send-email-simon.marchi@polymtl.ca> In-Reply-To: <1459912543-15328-1-git-send-email-simon.marchi@polymtl.ca> References: <1459912543-15328-1-git-send-email-simon.marchi@polymtl.ca> This test seems to work with both native-gdbserver and native-extended-gdbserver, so I removed the remote check. When running with native-gdbserver (a stub-like target), detach makes gdbserver stop and gdb disconnect. runto_main just spawns a brand new gdbserver. So it tests the exact same thing twice. It doesn't hurt though. With native-extended-gdbserver, the test is probably a bit more useful (and similar to native). It tests running/detaching twice using the same gdb/gdbserver instances, since with extended-remote, you can detach/attach/run all you want, unlike with remote. gdb/testsuite/ChangeLog: * gdb.base/detach.exp: Remove is_remote check. --- gdb/testsuite/gdb.base/detach.exp | 5 ----- 1 file changed, 5 deletions(-) diff --git a/gdb/testsuite/gdb.base/detach.exp b/gdb/testsuite/gdb.base/detach.exp index 920dac2..b9343ee 100644 --- a/gdb/testsuite/gdb.base/detach.exp +++ b/gdb/testsuite/gdb.base/detach.exp @@ -22,11 +22,6 @@ if { ! [istarget "*-*-linux*"] } { return 0 } -# Are we on a target board? -if [is_remote target] then { - return 0 -} - standard_testfile attach.c set escapedbinfile [string_to_regexp ${binfile}]