From patchwork Fri Mar 18 19:18:16 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pedro Alves X-Patchwork-Id: 11400 Received: (qmail 37668 invoked by alias); 18 Mar 2016 19:25:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 37642 invoked by uid 89); 18 Mar 2016 19:25:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:1034 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 18 Mar 2016 19:25:02 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id E5D897F080 for ; Fri, 18 Mar 2016 19:18:45 +0000 (UTC) Received: from cascais.lan (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2IJIYkA028091 for ; Fri, 18 Mar 2016 15:18:45 -0400 From: Pedro Alves To: gdb-patches@sourceware.org Subject: [PATCH 12/30] Don't call clear_quit_flag in command_handler Date: Fri, 18 Mar 2016 19:18:16 +0000 Message-Id: <1458328714-4938-13-git-send-email-palves@redhat.com> In-Reply-To: <1458328714-4938-1-git-send-email-palves@redhat.com> References: <1458328714-4938-1-git-send-email-palves@redhat.com> This just looks totally wrong to me, for completetly discarding a user-requested Ctrl-C. I can't think of why we'd want do this here. Actually, I digged the history, and found out that this has been here since at least 7b4ac7e1ed2c (gdb-2.4, the initial revision, 1988), at a time were we had a top level setjmp/longjmp, long before that got wrapped in throw_exception and friends, and this code was in an explicit loop, with the quit_flag cleared on every iteration, before executing a command... gdb/ChangeLog: yyyy-mm-dd Pedro Alves * event-top.c (command_handler): Don't call clear_quit_flag. --- gdb/event-top.c | 1 - 1 file changed, 1 deletion(-) diff --git a/gdb/event-top.c b/gdb/event-top.c index da72b1d..7fedb48 100644 --- a/gdb/event-top.c +++ b/gdb/event-top.c @@ -459,7 +459,6 @@ command_handler (char *command) struct cleanup *stat_chain; char *c; - clear_quit_flag (); if (instream == stdin) reinitialize_more_filter ();