From patchwork Fri Mar 18 15:00:51 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yao Qi X-Patchwork-Id: 11380 Received: (qmail 68348 invoked by alias); 18 Mar 2016 15:01:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 68329 invoked by uid 89); 18 Mar 2016 15:01:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 spammy=1988, HX-Received:10.66.140.39 X-HELO: mail-pf0-f193.google.com Received: from mail-pf0-f193.google.com (HELO mail-pf0-f193.google.com) (209.85.192.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 18 Mar 2016 15:00:59 +0000 Received: by mail-pf0-f193.google.com with SMTP id u190so17363864pfb.2 for ; Fri, 18 Mar 2016 08:00:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id; bh=UyZGyRiQ03h2tGt3EAJVI9lzatT1O5pb5mWNHyUGQX8=; b=ZLIgD1dsCT5tY7WsxxfQsT9EtfTTCNBZbeJDw8XcmLRHVjqspijXMPlAozHXGjg0iN 1hvQrhMJsVazczeFzYDvaJ3bKKY3mSG3UC5binRdes53TFAC6Ry8DmquuqEPk/Il+8ag 2a0PIMp63p0bacl1JaGwVZwZqyAPzf2thyDjjloQdBAi4nL0myIMKKEHtlCQtaJk/C6v VTCixUIiz+6JETG08uJpVaLOOxxTp/8PvsZvwHbavTFqgQPqoUhd4vaBab0jUjpDrRP4 6H1D1K5r7p7dAnxa+c5+KDRT4Nh6Nw3HXSXf0iCvj1DTr5tJxi9QP2K84Dtakpi/kXyX 3NwA== X-Gm-Message-State: AD7BkJJg3M4VBS45QQVsOgisS1u9lgwBnKnSy5eC0fGH0scEFV0nAsXXuGjhZo+lS+KV+g== X-Received: by 10.66.140.39 with SMTP id rd7mr24378058pab.92.1458313257798; Fri, 18 Mar 2016 08:00:57 -0700 (PDT) Received: from E107787-LIN.cambridge.arm.com (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id i1sm21708946pfj.17.2016.03.18.08.00.56 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 18 Mar 2016 08:00:56 -0700 (PDT) From: Yao Qi X-Google-Original-From: Yao Qi To: gdb-patches@sourceware.org Subject: [PATCH OBV] Make sparc_software_single_step static Date: Fri, 18 Mar 2016 15:00:51 +0000 Message-Id: <1458313251-32036-1-git-send-email-yao.qi@linaro.org> X-IsSubscribed: yes sparc_software_single_step is not used out of sparc-tdep.c, so this patch makes it static. It is obvious. I'll push it in. gdb: 2016-03-18 Yao Qi * sparc-tdep.c (sparc_software_single_step): Make it static. * sparc-tdep.h (sparc_software_single_step): Remove declaration. --- gdb/ChangeLog | 5 +++++ gdb/sparc-tdep.c | 2 +- gdb/sparc-tdep.h | 2 -- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index c074568..c15a6be 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,10 @@ 2016-03-18 Yao Qi + * sparc-tdep.c (sparc_software_single_step): Make it static. + * sparc-tdep.h (sparc_software_single_step): Remove declaration. + +2016-03-18 Yao Qi + * spu-tdep.c (spu_software_single_step): Throw error when target_read_memory fails. diff --git a/gdb/sparc-tdep.c b/gdb/sparc-tdep.c index b85b15f..863ef8f 100644 --- a/gdb/sparc-tdep.c +++ b/gdb/sparc-tdep.c @@ -1605,7 +1605,7 @@ sparc_step_trap (struct frame_info *frame, unsigned long insn) return 0; } -int +static int sparc_software_single_step (struct frame_info *frame) { struct gdbarch *arch = get_frame_arch (frame); diff --git a/gdb/sparc-tdep.h b/gdb/sparc-tdep.h index 9e951eb..6785e01 100644 --- a/gdb/sparc-tdep.h +++ b/gdb/sparc-tdep.h @@ -198,8 +198,6 @@ extern int -extern int sparc_software_single_step (struct frame_info *frame); - extern void sparc_supply_rwindow (struct regcache *regcache, CORE_ADDR sp, int regnum); extern void sparc_collect_rwindow (const struct regcache *regcache,