diff mbox

Set breakpoint condition-evaluation in forking-threads-plus-breakpoint.exp

Message ID 1455793143-25234-1-git-send-email-yao.qi@linaro.org
State New, archived
Headers

Commit Message

Yao Qi Feb. 18, 2016, 10:59 a.m. UTC 
  Proc do_test in forking-threads-plus-breakpoint.exp has an argument
cond_bp_target, but the test doesn't use it to set
"breakpoint condition-evaluation", which is an oversight in the test.

This patch fixes it by setting "breakpoint condition-evaluation" per
$cond_bp_target.

gdb/testsuite:

2016-02-18  Yao Qi  <yao.qi@linaro.org>

	* gdb.threads/forking-threads-plus-breakpoint.exp (do_test):
	Set "set breakpoint condition-evaluation" per $cond_bp_target.
---
 .../gdb.threads/forking-threads-plus-breakpoint.exp       | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

Comments

Pedro Alves Feb. 18, 2016, 11:25 a.m. UTC | #1 
On 02/18/2016 10:59 AM, Yao Qi wrote:
> Proc do_test in forking-threads-plus-breakpoint.exp has an argument
> cond_bp_target, but the test doesn't use it to set
> "breakpoint condition-evaluation", which is an oversight in the test.

Whoops, indeed.

> 
> This patch fixes it by setting "breakpoint condition-evaluation" per
> $cond_bp_target.
> 
> gdb/testsuite:
> 
> 2016-02-18  Yao Qi  <yao.qi@linaro.org>
> 
> 	* gdb.threads/forking-threads-plus-breakpoint.exp (do_test):
> 	Set "set breakpoint condition-evaluation" per $cond_bp_target.

Thanks, LGTM.

Thanks,
Pedro Alves
Yao Qi Feb. 18, 2016, 12:05 p.m. UTC | #2 
Pedro Alves <palves@redhat.com> writes:

> Thanks, LGTM.

Patch is pushed in.
diff mbox

Patch

diff --git a/gdb/testsuite/gdb.threads/forking-threads-plus-breakpoint.exp b/gdb/testsuite/gdb.threads/forking-threads-plus-breakpoint.exp
index ff3ca9a..3d8b308 100644
--- a/gdb/testsuite/gdb.threads/forking-threads-plus-breakpoint.exp
+++ b/gdb/testsuite/gdb.threads/forking-threads-plus-breakpoint.exp
@@ -83,6 +83,21 @@  proc do_test { cond_bp_target detach_on_fork displaced } {
 	return 0
     }
 
+    if {$cond_bp_target} {
+	set test "set breakpoint condition-evaluation target"
+	gdb_test_multiple $test $test {
+	    -re "warning: Target does not support breakpoint condition evaluation.\r\nUsing host evaluation mode instead.\r\n$gdb_prompt $" {
+		# Target doesn't support breakpoint condition
+		# evaluation on its side.  Skip the test.
+		return 0
+	    }
+	    -re "^$test\r\n$gdb_prompt $" {
+	    }
+	}
+    } else {
+	gdb_test_no_output "set breakpoint condition-evaluation host"
+    }
+
     gdb_test_no_output "set detach-on-fork $detach_on_fork"
     gdb_test_no_output "set displaced $displaced"