diff mbox

gdb.trace/testsuite: Bump stack collection fudge factor.

Message ID 1453560587-30161-1-git-send-email-koriakin@0x04.net
State New, archived
Headers

Commit Message

Marcin Kościelnicki Jan. 23, 2016, 2:49 p.m. UTC 
  These two tests collect 64 words from $sp onwards, hoping that's enough
to capture a few whole stack frames.  Unfortunately, that's not enough
for s390, which tends to have large frame sizes - minimum 24 words on
s390, 20 on s390x (which just barely passes).  Bump it to 128 words,
let's hope no machine needs more.

Tested on x86_64, s390, s390x.

gdb/testsuite/ChangeLog:

	* gdb.trace/backtrace.exp: Bump stack collection fudge factor.
	* gdb.trace/entry-values.exp: Bump stack collection fudge factor.
---
 gdb/testsuite/ChangeLog                  | 5 +++++
 gdb/testsuite/gdb.trace/backtrace.exp    | 2 +-
 gdb/testsuite/gdb.trace/entry-values.exp | 2 +-
 3 files changed, 7 insertions(+), 2 deletions(-)

Comments

Pedro Alves Jan. 25, 2016, 11:56 a.m. UTC | #1 
On 01/23/2016 02:49 PM, Marcin Kościelnicki wrote:
> These two tests collect 64 words from $sp onwards, hoping that's enough
> to capture a few whole stack frames.  Unfortunately, that's not enough
> for s390, which tends to have large frame sizes - minimum 24 words on
> s390, 20 on s390x (which just barely passes).  Bump it to 128 words,
> let's hope no machine needs more.

OK.

Thanks,
Pedro Alves
Marcin Kościelnicki Jan. 25, 2016, 12:19 p.m. UTC | #2 
On 25/01/16 12:56, Pedro Alves wrote:
> On 01/23/2016 02:49 PM, Marcin Kościelnicki wrote:
>> These two tests collect 64 words from $sp onwards, hoping that's enough
>> to capture a few whole stack frames.  Unfortunately, that's not enough
>> for s390, which tends to have large frame sizes - minimum 24 words on
>> s390, 20 on s390x (which just barely passes).  Bump it to 128 words,
>> let's hope no machine needs more.
>
> OK.
>
> Thanks,
> Pedro Alves
>

Thanks, pushed.
diff mbox

Patch

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 8ee2efa..a201b66 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,5 +1,10 @@ 
 2016-01-23  Marcin Kościelnicki  <koriakin@0x04.net>
 
+	* gdb.trace/backtrace.exp: Bump stack collection fudge factor.
+	* gdb.trace/entry-values.exp: Bump stack collection fudge factor.
+
+2016-01-23  Marcin Kościelnicki  <koriakin@0x04.net>
+
 	* gdb.trace/unavailable-dwarf-piece.exp: Fix bitfield handling on big
 	endian targets.
 
diff --git a/gdb/testsuite/gdb.trace/backtrace.exp b/gdb/testsuite/gdb.trace/backtrace.exp
index ad18f15..881a798 100644
--- a/gdb/testsuite/gdb.trace/backtrace.exp
+++ b/gdb/testsuite/gdb.trace/backtrace.exp
@@ -142,7 +142,7 @@  gdb_trace_setactions "8.6: setup TP to collect regs, args, and locals" \
 
 gdb_trace_setactions "8.6: setup TP to collect stack mem cast expr" \
        "$tdp6" \
-       "collect \$$fpreg, \(\*\(void \*\*\) \(\$$spreg\)\) @ 64" "^$"
+       "collect \$$fpreg, \(\*\(void \*\*\) \(\$$spreg\)\) @ 128" "^$"
 
 gdb_test_no_output "tstart" ""
 
diff --git a/gdb/testsuite/gdb.trace/entry-values.exp b/gdb/testsuite/gdb.trace/entry-values.exp
index 7f60b8c..825928d 100644
--- a/gdb/testsuite/gdb.trace/entry-values.exp
+++ b/gdb/testsuite/gdb.trace/entry-values.exp
@@ -219,7 +219,7 @@  gdb_test "trace foo" "Tracepoint $decimal at .*"
 # argument j.
 
 gdb_trace_setactions "set action for tracepoint 1" "" \
-    "collect i, j, global1, \(\*\(void \*\*\) \(\$$spreg\)\) @ 64" "^$"
+    "collect i, j, global1, \(\*\(void \*\*\) \(\$$spreg\)\) @ 128" "^$"
 
 gdb_test_no_output "tstart"