From patchwork Thu Jan 21 14:12:45 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yao Qi X-Patchwork-Id: 10504 Received: (qmail 130105 invoked by alias); 21 Jan 2016 14:12:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 130085 invoked by uid 89); 21 Jan 2016 14:12:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 spammy=sk:perror_, sk:ptrace_, sk:PTRACE_, 350, 7 X-HELO: mail-pa0-f47.google.com Received: from mail-pa0-f47.google.com (HELO mail-pa0-f47.google.com) (209.85.220.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 21 Jan 2016 14:12:52 +0000 Received: by mail-pa0-f47.google.com with SMTP id uo6so24484697pac.1 for ; Thu, 21 Jan 2016 06:12:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id; bh=WZo1Tr8FNsBwlz5DaLZWkBy2LxC/Jrw4tmKhMUiGWhw=; b=d0dcOJwAvtE9rr3PNsInoh9utdv+Ij5I6ptHiUotTcGJNjwn6LzUMN5Yzwk6Ebv+zI yYMbCYG5V0b2XeCYNxdn9ERzaROwtI3L7S3AqblbCIpHPoKirxnZIJuDFrFHZ5D1SkPK dTCgZYASyGelesHsTfg4gXIAoDQPjmYW4D/GYwHyXR2zEiuy6r2CkFyNs8fn8tWdMYh4 jxYzA7Is04MEvGMlNhdcRXOcq+DAnyZ9+4qjQpcVjH5dooE9NWE97bABOu0Q2mhmYIhl QDYH1KveJpT2ddcuMvct43oDyNtOlmLieqx1fv6PEoopBOSX7XdGssk10iWye0iNIh/a ysEw== X-Gm-Message-State: ALoCoQn4LN6aHu99fqa/bo/KDYgUCTDuV1kVS0wLsTWNCvcHRjzdD3lLJ3/4L3SNBev2nq4UKhKL7xu4FKUoZS1+a6iFSkahrw== X-Received: by 10.66.90.166 with SMTP id bx6mr61870708pab.75.1453385570263; Thu, 21 Jan 2016 06:12:50 -0800 (PST) Received: from E107787-LIN.cambridge.arm.com (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id n8sm3060350pfj.46.2016.01.21.06.12.48 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 21 Jan 2016 06:12:49 -0800 (PST) From: Yao Qi X-Google-Original-From: Yao Qi To: gdb-patches@sourceware.org Subject: [PATCH] [ARM] perror_with_name when failed to fetch/store registers Date: Thu, 21 Jan 2016 14:12:45 +0000 Message-Id: <1453385565-25186-1-git-send-email-yao.qi@linaro.org> X-IsSubscribed: yes I see the following test fail on native arm-linux gdb testing... (gdb) PASS: gdb.base/killed-outside.exp: registers: get pid of inferior Executing on target: kill -9 2346 (timeout = 300) spawn kill -9 2346^M flushregs^M Register cache flushed.^M warning: Unable to fetch general registers.^M PC not available^M (gdb) PASS: gdb.base/killed-outside.exp: registers: flushregs info threads^M Id Target Id Frame ^M * 1 process 2346 "killed-outside" (gdb) FAIL: gdb.base/killed-outside.exp: registers: info threads (timeout) since the inferior disappeared, ptrace will fail. In that case, the exception should be thrown, so that the caller can handle that. Regression tested on arm-linux natively. I'll push it in tomorrow. gdb: 2016-01-21 Yao Qi * arm-linux-nat.c (fetch_fpregs): Call perror_with_name instead of warning. (store_fpregs, fetch_regs, store_regs): Likewise. (fetch_wmmx_regs, store_wmmx_regs): Likewise. (fetch_vfp_regs, store_vfp_regs): Likewise. --- gdb/arm-linux-nat.c | 60 +++++++++++------------------------------------------ 1 file changed, 12 insertions(+), 48 deletions(-) diff --git a/gdb/arm-linux-nat.c b/gdb/arm-linux-nat.c index ed72bb3..d77ca93 100644 --- a/gdb/arm-linux-nat.c +++ b/gdb/arm-linux-nat.c @@ -92,10 +92,7 @@ fetch_fpregs (struct regcache *regcache) ret = ptrace (PT_GETFPREGS, tid, 0, fp); if (ret < 0) - { - warning (_("Unable to fetch the floating point registers.")); - return; - } + perror_with_name (_("Unable to fetch the floating point registers.")); /* Fetch fpsr. */ regcache_raw_supply (regcache, ARM_FPS_REGNUM, @@ -133,10 +130,7 @@ store_fpregs (const struct regcache *regcache) ret = ptrace (PT_GETFPREGS, tid, 0, fp); if (ret < 0) - { - warning (_("Unable to fetch the floating point registers.")); - return; - } + perror_with_name (_("Unable to fetch the floating point registers.")); /* Store fpsr. */ if (REG_VALID == regcache_register_status (regcache, ARM_FPS_REGNUM)) @@ -160,10 +154,7 @@ store_fpregs (const struct regcache *regcache) ret = ptrace (PTRACE_SETFPREGS, tid, 0, fp); if (ret < 0) - { - warning (_("Unable to store floating point registers.")); - return; - } + perror_with_name (_("Unable to store floating point registers.")); } /* Fetch all general registers of the process and store into @@ -191,10 +182,7 @@ fetch_regs (struct regcache *regcache) ret = ptrace (PTRACE_GETREGS, tid, 0, ®s); if (ret < 0) - { - warning (_("Unable to fetch general registers.")); - return; - } + perror_with_name (_("Unable to fetch general registers.")); aarch32_gp_regcache_supply (regcache, (uint32_t *) regs, arm_apcs_32); } @@ -222,10 +210,7 @@ store_regs (const struct regcache *regcache) ret = ptrace (PTRACE_GETREGS, tid, 0, ®s); if (ret < 0) - { - warning (_("Unable to fetch general registers.")); - return; - } + perror_with_name (_("Unable to fetch general registers.")); aarch32_gp_regcache_collect (regcache, (uint32_t *) regs, arm_apcs_32); @@ -242,10 +227,7 @@ store_regs (const struct regcache *regcache) ret = ptrace (PTRACE_SETREGS, tid, 0, ®s); if (ret < 0) - { - warning (_("Unable to store general registers.")); - return; - } + perror_with_name (_("Unable to store general registers.")); } /* Fetch all WMMX registers of the process and store into @@ -264,10 +246,7 @@ fetch_wmmx_regs (struct regcache *regcache) ret = ptrace (PTRACE_GETWMMXREGS, tid, 0, regbuf); if (ret < 0) - { - warning (_("Unable to fetch WMMX registers.")); - return; - } + perror_with_name (_("Unable to fetch WMMX registers.")); for (regno = 0; regno < 16; regno++) regcache_raw_supply (regcache, regno + ARM_WR0_REGNUM, @@ -293,10 +272,7 @@ store_wmmx_regs (const struct regcache *regcache) ret = ptrace (PTRACE_GETWMMXREGS, tid, 0, regbuf); if (ret < 0) - { - warning (_("Unable to fetch WMMX registers.")); - return; - } + perror_with_name (_("Unable to fetch WMMX registers.")); for (regno = 0; regno < 16; regno++) if (REG_VALID == regcache_register_status (regcache, @@ -319,10 +295,7 @@ store_wmmx_regs (const struct regcache *regcache) ret = ptrace (PTRACE_SETWMMXREGS, tid, 0, regbuf); if (ret < 0) - { - warning (_("Unable to store WMMX registers.")); - return; - } + perror_with_name (_("Unable to store WMMX registers.")); } static void @@ -348,10 +321,7 @@ fetch_vfp_regs (struct regcache *regcache) ret = ptrace (PTRACE_GETVFPREGS, tid, 0, regbuf); if (ret < 0) - { - warning (_("Unable to fetch VFP registers.")); - return; - } + perror_with_name (_("Unable to fetch VFP registers.")); aarch32_vfp_regcache_supply (regcache, regbuf, tdep->vfp_register_count); @@ -380,10 +350,7 @@ store_vfp_regs (const struct regcache *regcache) ret = ptrace (PTRACE_GETVFPREGS, tid, 0, regbuf); if (ret < 0) - { - warning (_("Unable to fetch VFP registers (for update).")); - return; - } + perror_with_name (_("Unable to fetch VFP registers (for update).")); aarch32_vfp_regcache_collect (regcache, regbuf, tdep->vfp_register_count); @@ -400,10 +367,7 @@ store_vfp_regs (const struct regcache *regcache) ret = ptrace (PTRACE_SETVFPREGS, tid, 0, regbuf); if (ret < 0) - { - warning (_("Unable to store VFP registers.")); - return; - } + perror_with_name (_("Unable to store VFP registers.")); } /* Fetch registers from the child process. Fetch all registers if