diff mbox

Fix missing IPA lib in tspeed.exp in some configurations.

Message ID 1453296401-31209-1-git-send-email-antoine.tremblay@ericsson.com
State New
Headers show

Commit Message

Antoine Tremblay Jan. 20, 2016, 1:26 p.m. UTC 
On Ubuntu 14.04 the following failure would be seen when running the
tspeed.exp test on a target that supports fast tracepoints like x86_64:

Target returns error code '.In-process agent library not loaded in
process.  Fast and static tracepoints unavailable.'.
(gdb) FAIL: gdb.trace/tspeed.exp: start trace experiment

This is because the default is to link with --as-needed and the
gdb_compile for the test is using the libs argument instead of shlib which
corrects this issue since 6ebea266fd0a7a56c90db3ab6237ff9f6c919747 by
adding -Wl,--no-as-needed.

This patch fixes the issue by passing the lib as the shlib argument to
gdb_compile.

Tested on Ubuntu 14.04 x86_64.

gdb/testsuite/ChangeLog:

	* gdb.trace/tspeed.exp:  Use shlib instead of libs in gdb_compile
	command.
---
 gdb/testsuite/gdb.trace/tspeed.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Yao Qi Jan. 20, 2016, 4:50 p.m. UTC | #1 
Antoine Tremblay <antoine.tremblay@ericsson.com> writes:

> gdb/testsuite/ChangeLog:
>
> 	* gdb.trace/tspeed.exp:  Use shlib instead of libs in gdb_compile
> 	command.

OK with me.
Antoine Tremblay Jan. 20, 2016, 5:32 p.m. UTC | #2 
On 01/20/2016 11:50 AM, Yao Qi wrote:
> Antoine Tremblay <antoine.tremblay@ericsson.com> writes:
>
>> gdb/testsuite/ChangeLog:
>>
>> 	* gdb.trace/tspeed.exp:  Use shlib instead of libs in gdb_compile
>> 	command.
>
> OK with me.
>

Thanks, pushed in.
diff mbox

Patch

diff --git a/gdb/testsuite/gdb.trace/tspeed.exp b/gdb/testsuite/gdb.trace/tspeed.exp
index 6f89a2b..e638839 100644
--- a/gdb/testsuite/gdb.trace/tspeed.exp
+++ b/gdb/testsuite/gdb.trace/tspeed.exp
@@ -21,7 +21,7 @@  set executable $testfile
 set ipalib [get_in_proc_agent]
 
 if { [gdb_compile "$srcdir/$subdir/$srcfile" $binfile \
-	  executable [concat {debug nowarnings c} libs=$ipalib]] != "" } {
+	  executable [concat {debug nowarnings c} shlib=$ipalib]] != "" } {
     untested tspeed.exp
     return -1
 }