From patchwork Mon Jan 18 02:27:24 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Baldwin X-Patchwork-Id: 10415 Received: (qmail 109607 invoked by alias); 18 Jan 2016 02:28:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 109283 invoked by uid 89); 18 Jan 2016 02:28:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.0 required=5.0 tests=AWL, BAYES_20, SPF_HELO_PASS, SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=270, 2.7.0, HX-Greylist:succeeded, HX-Greylist:SMTP X-Spam-User: qpsmtpd, 2 recipients X-HELO: bigwig.baldwin.cx Received: from bigwig.baldwin.cx (HELO bigwig.baldwin.cx) (96.47.65.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Mon, 18 Jan 2016 02:28:15 +0000 Received: from ralph.com (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 01BA5B989; Sun, 17 Jan 2016 21:28:12 -0500 (EST) From: John Baldwin To: gdb-patches@sourceware.org, binutils@sourceware.org Subject: [PATCH v3 3/6] Display per-thread information for threads in FreeBSD cores. Date: Sun, 17 Jan 2016 18:27:24 -0800 Message-Id: <1453084047-16175-4-git-send-email-jhb@FreeBSD.org> In-Reply-To: <1453084047-16175-1-git-send-email-jhb@FreeBSD.org> References: <1453084047-16175-1-git-send-email-jhb@FreeBSD.org> X-IsSubscribed: yes Display the LWP ID of each thread in a FreeBSD core. Extract thread names from the per-thread THRMISC note. gdb/ChangeLog: * fbsd_tdep.c (fbsd_core_pid_to_str): New function. (fbsd_init_abi): Add "core_pid_to_str" gdbarch method. --- gdb/ChangeLog | 5 +++++ gdb/fbsd-tdep.c | 47 +++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 52 insertions(+) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index fe8fd6c..8f28959 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2016-01-16 John Baldwin + + * fbsd_tdep.c (fbsd_core_pid_to_str): New function. + (fbsd_init_abi): Add "core_pid_to_str" gdbarch method. + 2016-01-15 Sandra Loosemore * charset.c [PHONY_ICONV] (GDB_DEFAULT_HOST_CHARSET): diff --git a/gdb/fbsd-tdep.c b/gdb/fbsd-tdep.c index 0ef94d6..88342cd 100644 --- a/gdb/fbsd-tdep.c +++ b/gdb/fbsd-tdep.c @@ -28,6 +28,52 @@ #include "fbsd-tdep.h" +/* This is how we want PTIDs from core files to be printed. */ + +static char * +fbsd_core_pid_to_str (struct gdbarch *gdbarch, ptid_t ptid) +{ + static char buf[80]; + struct bfd_section *section; + bfd_size_type size; + char sectionstr[32]; + + if (ptid_get_lwp (ptid) != 0) + { + xsnprintf (sectionstr, sizeof sectionstr, ".thrmisc/%ld", + ptid_get_lwp (ptid)); + section = bfd_get_section_by_name (core_bfd, sectionstr); + if (section != NULL && bfd_section_size (core_bfd, section) > 0) + { + char *name; + + size = bfd_section_size (core_bfd, section); + name = alloca (size + 1); + if (bfd_get_section_contents (core_bfd, section, name, (file_ptr) 0, + size) + && name[0] != '\0') + { + name[size] = '\0'; + + /* Note that each thread will report the process command + as its thread name instead of an empty name if a name + has not been set explicitly. Return a NULL name in + that case. */ + if (strcmp (name, elf_tdata (core_bfd)->core->program) != 0) + { + xsnprintf (buf, sizeof buf, "LWP %ld \"%s\"", + ptid_get_lwp (ptid), name); + return buf; + } + } + } + xsnprintf (buf, sizeof buf, "LWP %ld", ptid_get_lwp (ptid)); + return buf; + } + + return normal_pid_to_str (ptid); +} + static int find_signalled_thread (struct thread_info *info, void *data) { @@ -132,5 +178,6 @@ fbsd_make_corefile_notes (struct gdbarch *gdbarch, bfd *obfd, int *note_size) void fbsd_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch) { + set_gdbarch_core_pid_to_str (gdbarch, fbsd_core_pid_to_str); set_gdbarch_make_corefile_notes (gdbarch, fbsd_make_corefile_notes); }