From patchwork Mon Jan 11 19:16:14 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Frysinger X-Patchwork-Id: 10337 Received: (qmail 37143 invoked by alias); 11 Jan 2016 19:16:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 36473 invoked by uid 89); 11 Jan 2016 19:16:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 spammy=regno, regnum, sk:support, Attach X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 11 Jan 2016 19:16:21 +0000 Received: from localhost.localdomain (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id E63123407B8 for ; Mon, 11 Jan 2016 19:16:18 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: [PATCH 1/2] gdbserver: fix various warnings Date: Mon, 11 Jan 2016 14:16:14 -0500 Message-Id: <1452539775-32541-1-git-send-email-vapier@gentoo.org> X-IsSubscribed: yes Delete unused funcs, update old prototypes, and mark local funcs as static. This doesn't cover all missing prototype warnings. --- gdb/gdbserver/ax.c | 2 +- gdb/gdbserver/linux-low.c | 6 +++--- gdb/gdbserver/mem-break.c | 4 ++-- gdb/gdbserver/regcache.c | 12 ------------ gdb/gdbserver/remote-utils.c | 2 +- gdb/gdbserver/server.c | 12 ++++++------ 6 files changed, 13 insertions(+), 25 deletions(-) diff --git a/gdb/gdbserver/ax.c b/gdb/gdbserver/ax.c index 91894c2..d5144c2 100644 --- a/gdb/gdbserver/ax.c +++ b/gdb/gdbserver/ax.c @@ -375,7 +375,7 @@ emit_le_goto (int *offset_p, int *size_p) /* Scan an agent expression for any evidence that the given PC is the target of a jump bytecode in the expression. */ -int +static int is_goto_target (struct agent_expr *aexpr, int pc) { int i; diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c index 4f8f573..a6c986d 100644 --- a/gdb/gdbserver/linux-low.c +++ b/gdb/gdbserver/linux-low.c @@ -5227,7 +5227,7 @@ linux_register_in_regsets (const struct regs_info *regs_info, int regno) #ifdef HAVE_LINUX_USRREGS -int +static int register_addr (const struct usrregs_info *usrregs, int regnum) { int addr; @@ -5389,7 +5389,7 @@ usr_store_inferior_registers (const struct regs_info *regs_info, #endif -void +static void linux_fetch_registers (struct regcache *regcache, int regno) { int use_regsets; @@ -5422,7 +5422,7 @@ linux_fetch_registers (struct regcache *regcache, int regno) } } -void +static void linux_store_registers (struct regcache *regcache, int regno) { int use_regsets; diff --git a/gdb/gdbserver/mem-break.c b/gdb/gdbserver/mem-break.c index 2e220b8..b06f8e9 100644 --- a/gdb/gdbserver/mem-break.c +++ b/gdb/gdbserver/mem-break.c @@ -267,7 +267,7 @@ Z_packet_to_raw_bkpt_type (char z_type) } int -any_persistent_commands () +any_persistent_commands (void) { struct process_info *proc = current_process (); struct breakpoint *bp; @@ -1269,7 +1269,7 @@ gdb_condition_true_at_breakpoint (CORE_ADDR where) /* Add commands COMMANDS to GDBserver's breakpoint BP. */ -void +static void add_commands_to_breakpoint (struct breakpoint *bp, struct agent_expr *commands, int persist) { diff --git a/gdb/gdbserver/regcache.c b/gdb/gdbserver/regcache.c index cd8d9db..6a737ea 100644 --- a/gdb/gdbserver/regcache.c +++ b/gdb/gdbserver/regcache.c @@ -253,18 +253,6 @@ registers_from_string (struct regcache *regcache, char *buf) hex2bin (buf, registers, len / 2); } -struct reg * -find_register_by_name (const struct target_desc *tdesc, const char *name) -{ - int i; - - for (i = 0; i < tdesc->num_registers; i++) - if (strcmp (name, tdesc->reg_defs[i].name) == 0) - return &tdesc->reg_defs[i]; - internal_error (__FILE__, __LINE__, "Unknown register %s requested", - name); -} - int find_regno (const struct target_desc *tdesc, const char *name) { diff --git a/gdb/gdbserver/remote-utils.c b/gdb/gdbserver/remote-utils.c index c5f4647..40bd373 100644 --- a/gdb/gdbserver/remote-utils.c +++ b/gdb/gdbserver/remote-utils.c @@ -526,7 +526,7 @@ write_ptid (char *buf, ptid_t ptid) return buf; } -ULONGEST +static ULONGEST hex_or_minus_one (char *buf, char **obuf) { ULONGEST ret; diff --git a/gdb/gdbserver/server.c b/gdb/gdbserver/server.c index fe7195d..171b04d 100644 --- a/gdb/gdbserver/server.c +++ b/gdb/gdbserver/server.c @@ -805,7 +805,7 @@ get_features_xml (const char *annex) return NULL; } -void +static void monitor_show_help (void) { monitor_output ("The following monitor commands are supported:\n"); @@ -1966,7 +1966,7 @@ supported_btrace_packets (char *buf) /* Handle all of the extended 'q' packets. */ -void +static void handle_query (char *own_buf, int packet_len, int *new_packet_len_p) { static struct inferior_list_entry *thread_ptr; @@ -2568,7 +2568,7 @@ handle_pending_status (const struct thread_resume *resumption, } /* Parse vCont packets. */ -void +static void handle_v_cont (char *own_buf) { char *p, *q; @@ -2735,7 +2735,7 @@ resume (struct thread_resume *actions, size_t num_actions) } /* Attach to a new program. Return 1 if successful, 0 if failure. */ -int +static int handle_v_attach (char *own_buf) { int pid; @@ -2858,7 +2858,7 @@ handle_v_run (char *own_buf) } /* Kill process. Return 1 if successful, 0 if failure. */ -int +static int handle_v_kill (char *own_buf) { int pid; @@ -2884,7 +2884,7 @@ handle_v_kill (char *own_buf) } /* Handle all of the extended 'v' packets. */ -void +static void handle_v_requests (char *own_buf, int packet_len, int *new_packet_len) { if (!disable_packet_vCont)