diff mbox

[DOC] Interrupt when program is stopped

Message ID 1452513460-24295-1-git-send-email-yao.qi@linaro.org
State New, archived
Headers

Commit Message

Yao Qi Jan. 11, 2016, 11:57 a.m. UTC 
  This patch changes the document that interrupt (ctrl-c) is not ignored
when the program is stopped.

When the interrupt was supported in remote target, people thought interrupt
is meaningless when the program is stopped.  See

  https://www.sourceware.org/ml/gdb/2005-11/msg00349.html
  https://www.sourceware.org/ml/gdb-patches/2005-11/msg00307.html

recently we find it is hard to preserve this feature "ignore interrupt
while program is stopped" when we fix some other bugs.  See
https://sourceware.org/ml/gdb-patches/2016-01/msg00039.html

so we think we can go to the simpler approach "not ignoring ctrl-c when
program is stopped".  As a result, we tweak the documentation here.

gdb/doc:

2016-01-11  Yao Qi  <yao.qi@linaro.org>

	* gdb.texinfo (Interrupts): Update the document on handling
	interrupt when program is stopped.
---
 gdb/doc/gdb.texinfo | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Eli Zaretskii Jan. 11, 2016, 3:42 p.m. UTC | #1 
> From: Yao Qi <qiyaoltc@gmail.com>
> Cc: palves@redhat.com
> Date: Mon, 11 Jan 2016 11:57:40 +0000
> 
> gdb/doc:
> 
> 2016-01-11  Yao Qi  <yao.qi@linaro.org>
> 
> 	* gdb.texinfo (Interrupts): Update the document on handling
> 	interrupt when program is stopped.

OK, thanks.
Pedro Alves Jan. 12, 2016, 12:29 p.m. UTC | #2 
On 01/11/2016 11:57 AM, Yao Qi wrote:
> This patch changes the document that interrupt (ctrl-c) is not ignored
> when the program is stopped.
> 
> When the interrupt was supported in remote target, people thought interrupt
> is meaningless when the program is stopped.  See
> 
>   https://www.sourceware.org/ml/gdb/2005-11/msg00349.html
>   https://www.sourceware.org/ml/gdb-patches/2005-11/msg00307.html
> 
> recently we find it is hard to preserve this feature "ignore interrupt
> while program is stopped" when we fix some other bugs.  See
> https://sourceware.org/ml/gdb-patches/2016-01/msg00039.html
> 
> so we think we can go to the simpler approach "not ignoring ctrl-c when
> program is stopped".  As a result, we tweak the documentation here.
> 
> gdb/doc:
> 
> 2016-01-11  Yao Qi  <yao.qi@linaro.org>
> 
> 	* gdb.texinfo (Interrupts): Update the document on handling
> 	interrupt when program is stopped.

LGTM.

Thanks,
Pedro Alves
Yao Qi Jan. 12, 2016, 3:19 p.m. UTC | #3 
Eli Zaretskii <eliz@gnu.org> writes:

> OK, thanks.

Patch is pushed in.
diff mbox

Patch

diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 0778383..da9c7db 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -38130,7 +38130,8 @@  reply packets (@pxref{Stop Reply Packets}) to @value{GDBN} as a result
 of successfully stopping the program in all-stop mode, and a stop reply
 for each stopped thread in non-stop mode.
 Interrupts received while the
-program is stopped are discarded.
+program is stopped are queued and the program will be interrupted when
+it is resumed next time.
 
 @node Notification Packets
 @section Notification Packets