diff mbox

[3/3] libiberty: dupargv: rewrite to use xstrdup

Message ID 1452024298-31220-4-git-send-email-vapier@gentoo.org
State Committed
Headers show

Commit Message

Mike Frysinger Jan. 5, 2016, 8:04 p.m. UTC
This func is basically open coding the xstrdup function, so gut it
and use it directly.
---
 libiberty/ChangeLog | 4 ++++
 libiberty/argv.c    | 6 +-----
 2 files changed, 5 insertions(+), 5 deletions(-)
diff mbox

Patch

diff --git a/libiberty/ChangeLog b/libiberty/ChangeLog
index aa598f2..ba1e0a5 100644
--- a/libiberty/ChangeLog
+++ b/libiberty/ChangeLog
@@ -1,3 +1,7 @@ 
+2016-01-05  Mike Frysinger  <vapier@gentoo.org>
+
+	* argv.c (dupargv): Replace strlen/xmalloc/strcpy with xstrdup.
+
 2015-12-28  Patrick Palka  <ppalka@gcc.gnu.org>
 
 	* crc32.c: In the documentation, don't refer to GDB's
diff --git a/libiberty/argv.c b/libiberty/argv.c
index f2727e8..5c3dd70 100644
--- a/libiberty/argv.c
+++ b/libiberty/argv.c
@@ -76,11 +76,7 @@  dupargv (char **argv)
 
   /* the strings */
   for (argc = 0; argv[argc] != NULL; argc++)
-    {
-      int len = strlen (argv[argc]);
-      copy[argc] = (char *) xmalloc (len + 1);
-      strcpy (copy[argc], argv[argc]);
-    }
+    copy[argc] = xstrdup (argv[argc]);
   copy[argc] = NULL;
   return copy;
 }