[v3,4/4] Add testcases to break.exp

Message ID 1447142188-20759-5-git-send-email-feij.fnst@cn.fujitsu.com
State New, archived
Headers

Commit Message

Fei Jie Nov. 10, 2015, 7:56 a.m. UTC
  add testcases to break.exp as follows:
    *break with non-existed condition
    *break with out-ou-ranged address
    *break at offset -1

gdb/testsuite/ChangeLog:

    * gdb.base/break.exp: Add new testcases.
---
 gdb/testsuite/gdb.base/break.exp | 9 +++++++++
 1 file changed, 9 insertions(+)
  

Comments

Joel Brobecker Dec. 6, 2015, 2:10 p.m. UTC | #1
>     add testcases to break.exp as follows:
>     *break with non-existed condition
>     *break with out-ou-ranged address
>     *break at offset -1
> 
> gdb/testsuite/ChangeLog:
> 
>     * gdb.base/break.exp: Add new testcases.

Same comments as before...
The changes themselves look OK to me.
  

Patch

diff --git a/gdb/testsuite/gdb.base/break.exp b/gdb/testsuite/gdb.base/break.exp
index f879bc8..117a18f 100644
--- a/gdb/testsuite/gdb.base/break.exp
+++ b/gdb/testsuite/gdb.base/break.exp
@@ -334,6 +334,11 @@  gdb_test "enable" "" ""
 gdb_test "disable 10" "No breakpoint number 10." \
     "disable non-existent breakpoint 10"
 
+gdb_test "break main if donot_exist == 0" \
+    "No symbol \"donot_exist\" in current context\\."
+gdb_test "break \*0xfffffffffffffffff" \
+    "Numeric constant too large\\."
+
 gdb_test_no_output "set \$baz = 1.234"
 gdb_test "disable \$baz" \
     "Convenience variable must have integer value.*" \
@@ -399,6 +404,10 @@  set bp_location10 [gdb_get_line_number "set breakpoint 10 here"]
 gdb_test "break +1" \
     "Breakpoint.*at.* file .*$srcfile, line $bp_location10\\." \
     "breakpoint offset +1"
+# Test break at offset -1.
+gdb_test "break -1" \
+    "Note: breakpoint .* also set at.*Breakpoint.*at.* file .*$srcfile, line.*" \
+    "breakpoint offset -1"
 
 # Check to see if breakpoint is hit when stepped onto