From patchwork Mon Nov 2 19:58:38 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marcin_Ko=C5=9Bcielnicki?= X-Patchwork-Id: 9512 Received: (qmail 77179 invoked by alias); 2 Nov 2015 19:58:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 77167 invoked by uid 89); 2 Nov 2015 19:58:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL, BAYES_00, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: xyzzy.0x04.net Received: from xyzzy.0x04.net (HELO xyzzy.0x04.net) (109.74.193.254) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 02 Nov 2015 19:58:43 +0000 Received: from hogfather.0x04.net (89-65-84-110.dynamic.chello.pl [89.65.84.110]) by xyzzy.0x04.net (Postfix) with ESMTPS id D7425400E4; Mon, 2 Nov 2015 20:58:58 +0100 (CET) Received: by hogfather.0x04.net (Postfix, from userid 1000) id 12C685800D4; Mon, 2 Nov 2015 20:58:41 +0100 (CET) From: =?UTF-8?q?Marcin=20Ko=C5=9Bcielnicki?= To: palves@redhat.com Cc: gdb-patches@sourceware.org, =?UTF-8?q?Marcin=20Ko=C5=9Bcielnicki?= Subject: [PATCH 1/2] gdb/reverse: Fix continue_to_breakpoint in syscall testcases. Date: Mon, 2 Nov 2015 20:58:38 +0100 Message-Id: <1446494319-5810-1-git-send-email-koriakin@0x04.net> In-Reply-To: <5637B6C0.8060500@redhat.com> References: <5637B6C0.8060500@redhat.com> MIME-Version: 1.0 continue_to_breakpoint always continues to the next breakpoint, not to the one named in parameter. This rendered the tests effectively useless, since marker2 was never reached. gdb/testsuite/ChangeLog: * gdb.reverse/fstatat-reverse.exp: Set breakpoint on marker1 after reaching marker2. * gdb.reverse/getresuid-reverse.exp: Likewise. * gdb.reverse/pipe-reverse.exp: Likewise. * gdb.reverse/readv-reverse.exp: Likewise. * gdb.reverse/recvmsg-reverse.exp: Likewise. * gdb.reverse/time-reverse.exp: Likewise. * gdb.reverse/waitpid-reverse.exp: Likewise and add KFAILs. --- Fixed and split as requested. gdb/testsuite/ChangeLog | 11 +++++++++++ gdb/testsuite/gdb.reverse/fstatat-reverse.exp | 8 ++++---- gdb/testsuite/gdb.reverse/getresuid-reverse.exp | 8 ++++---- gdb/testsuite/gdb.reverse/pipe-reverse.exp | 8 ++++---- gdb/testsuite/gdb.reverse/readv-reverse.exp | 8 ++++---- gdb/testsuite/gdb.reverse/recvmsg-reverse.exp | 8 ++++---- gdb/testsuite/gdb.reverse/time-reverse.exp | 8 ++++---- gdb/testsuite/gdb.reverse/waitpid-reverse.exp | 10 ++++++---- 8 files changed, 41 insertions(+), 28 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index e01ee86..ced4a87 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,14 @@ +2015-11-02 Marcin Kościelnicki + + * gdb.reverse/fstatat-reverse.exp: Set breakpoint on marker1 after + reaching marker2. + * gdb.reverse/getresuid-reverse.exp: Likewise. + * gdb.reverse/pipe-reverse.exp: Likewise. + * gdb.reverse/readv-reverse.exp: Likewise. + * gdb.reverse/recvmsg-reverse.exp: Likewise. + * gdb.reverse/time-reverse.exp: Likewise. + * gdb.reverse/waitpid-reverse.exp: Likewise and add KFAILs. + 2015-10-30 Yao Qi * gdb.threads/wp-replication.c (watch_count_done): Remove. diff --git a/gdb/testsuite/gdb.reverse/fstatat-reverse.exp b/gdb/testsuite/gdb.reverse/fstatat-reverse.exp index 09deb6c..e9b2ca8 100644 --- a/gdb/testsuite/gdb.reverse/fstatat-reverse.exp +++ b/gdb/testsuite/gdb.reverse/fstatat-reverse.exp @@ -36,16 +36,16 @@ if [supports_process_record] { gdb_test_no_output "record" "Turn on process record" } -gdb_test "break marker1" \ - "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ - "set breakpoint at marker1" - gdb_test "break marker2" \ "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ "set breakpoint at marker2" gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*" +gdb_test "break marker1" \ + "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ + "set breakpoint at marker1" + gdb_test "reverse-continue" ".*$srcfile:$decimal.*" "reverse to marker1" # If the variable was recorded properly on syscall, the old contents (0) diff --git a/gdb/testsuite/gdb.reverse/getresuid-reverse.exp b/gdb/testsuite/gdb.reverse/getresuid-reverse.exp index b93fb91..a625113 100644 --- a/gdb/testsuite/gdb.reverse/getresuid-reverse.exp +++ b/gdb/testsuite/gdb.reverse/getresuid-reverse.exp @@ -36,16 +36,16 @@ if [supports_process_record] { gdb_test_no_output "record" "Turn on process record" } -gdb_test "break marker1" \ - "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ - "set breakpoint at marker1" - gdb_test "break marker2" \ "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ "set breakpoint at marker2" gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*" +gdb_test "break marker1" \ + "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ + "set breakpoint at marker1" + gdb_test "reverse-continue" ".*$srcfile:$decimal.*" "reverse to marker1" # If the variables were recorded properly on syscall, the old contents (-1) diff --git a/gdb/testsuite/gdb.reverse/pipe-reverse.exp b/gdb/testsuite/gdb.reverse/pipe-reverse.exp index 482893a..5d50488 100644 --- a/gdb/testsuite/gdb.reverse/pipe-reverse.exp +++ b/gdb/testsuite/gdb.reverse/pipe-reverse.exp @@ -36,16 +36,16 @@ if [supports_process_record] { gdb_test_no_output "record" "Turn on process record" } -gdb_test "break marker1" \ - "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ - "set breakpoint at marker1" - gdb_test "break marker2" \ "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ "set breakpoint at marker2" gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*" +gdb_test "break marker1" \ + "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ + "set breakpoint at marker1" + gdb_test "reverse-continue" ".*$srcfile:$decimal.*" "reverse to marker1" # If the variables were recorded properly on syscall, the old contents (-1) diff --git a/gdb/testsuite/gdb.reverse/readv-reverse.exp b/gdb/testsuite/gdb.reverse/readv-reverse.exp index 4158c10..c9178d9 100644 --- a/gdb/testsuite/gdb.reverse/readv-reverse.exp +++ b/gdb/testsuite/gdb.reverse/readv-reverse.exp @@ -36,16 +36,16 @@ if [supports_process_record] { gdb_test_no_output "record" "Turn on process record" } -gdb_test "break marker1" \ - "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ - "set breakpoint at marker1" - gdb_test "break marker2" \ "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ "set breakpoint at marker2" gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*" +gdb_test "break marker1" \ + "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ + "set breakpoint at marker1" + gdb_test "reverse-continue" ".*$srcfile:$decimal.*" "reverse to marker1" # If the variables were recorded properly on syscall, the old contents ("") diff --git a/gdb/testsuite/gdb.reverse/recvmsg-reverse.exp b/gdb/testsuite/gdb.reverse/recvmsg-reverse.exp index 7293a3d..2540b91 100644 --- a/gdb/testsuite/gdb.reverse/recvmsg-reverse.exp +++ b/gdb/testsuite/gdb.reverse/recvmsg-reverse.exp @@ -36,16 +36,16 @@ if [supports_process_record] { gdb_test_no_output "record" "Turn on process record" } -gdb_test "break marker1" \ - "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ - "set breakpoint at marker1" - gdb_test "break marker2" \ "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ "set breakpoint at marker2" gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*" +gdb_test "break marker1" \ + "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ + "set breakpoint at marker1" + gdb_test "reverse-continue" ".*$srcfile:$decimal.*" "reverse to marker1" # If the variables were recorded properly on syscall, the old contents will diff --git a/gdb/testsuite/gdb.reverse/time-reverse.exp b/gdb/testsuite/gdb.reverse/time-reverse.exp index 9cec3c3..1cc111b 100644 --- a/gdb/testsuite/gdb.reverse/time-reverse.exp +++ b/gdb/testsuite/gdb.reverse/time-reverse.exp @@ -36,16 +36,16 @@ if [supports_process_record] { gdb_test_no_output "record" "Turn on process record" } -gdb_test "break marker1" \ - "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ - "set breakpoint at marker1" - gdb_test "break marker2" \ "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ "set breakpoint at marker2" gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*" +gdb_test "break marker1" \ + "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ + "set breakpoint at marker1" + gdb_test "reverse-continue" ".*$srcfile:$decimal.*" "reverse to marker1" # If the variable was recorded properly on syscall, the old contents (-1) diff --git a/gdb/testsuite/gdb.reverse/waitpid-reverse.exp b/gdb/testsuite/gdb.reverse/waitpid-reverse.exp index f4a4403..ddd8d7b 100644 --- a/gdb/testsuite/gdb.reverse/waitpid-reverse.exp +++ b/gdb/testsuite/gdb.reverse/waitpid-reverse.exp @@ -36,16 +36,18 @@ if [supports_process_record] { gdb_test_no_output "record" "Turn on process record" } -gdb_test "break marker1" \ - "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ - "set breakpoint at marker1" - gdb_test "break marker2" \ "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ "set breakpoint at marker2" +setup_kfail "gdb/19187" *-*-* gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*" +gdb_test "break marker1" \ + "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ + "set breakpoint at marker1" + +setup_kfail "gdb/19187" *-*-* gdb_test "reverse-continue" ".*$srcfile:$decimal.*" "reverse to marker1" # If the variable was recorded properly on syscall, the old contents (-1)