From patchwork Thu Oct 22 13:39:16 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marcin_Ko=C5=9Bcielnicki?= X-Patchwork-Id: 9314 Received: (qmail 108876 invoked by alias); 22 Oct 2015 13:39:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 108797 invoked by uid 89); 22 Oct 2015 13:39:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: xyzzy.0x04.net Received: from xyzzy.0x04.net (HELO xyzzy.0x04.net) (109.74.193.254) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 Oct 2015 13:39:41 +0000 Received: from hogfather.0x04.net (89-65-84-110.dynamic.chello.pl [89.65.84.110]) by xyzzy.0x04.net (Postfix) with ESMTPS id 38CB040133; Thu, 22 Oct 2015 15:39:53 +0200 (CEST) Received: by hogfather.0x04.net (Postfix, from userid 1000) id 238255800AC; Thu, 22 Oct 2015 15:39:39 +0200 (CEST) From: =?UTF-8?q?Marcin=20Ko=C5=9Bcielnicki?= To: palves@redhat.com, qiyaoltc@gmail.com Cc: gdb-patches@sourceware.org, =?UTF-8?q?Marcin=20Ko=C5=9Bcielnicki?= Subject: [PATCH v2 03/13] gdb/linux-record: Fix size_[ug]id values Date: Thu, 22 Oct 2015 15:39:16 +0200 Message-Id: <1445521166-14492-3-git-send-email-koriakin@0x04.net> In-Reply-To: <1445521166-14492-1-git-send-email-koriakin@0x04.net> References: <5628E5D6.5020706@0x04.net> <1445521166-14492-1-git-send-email-koriakin@0x04.net> MIME-Version: 1.0 i386 and arm wrongly set them to 2, when it should be 4. size_[ug]id is used by getgroups32 etc syscalls, while size_old_[ug]id is used for getgroups16 and friends. gdb/ChangeLog: * arm-linux-tdep.c (arm_linux_init_abi): Fix size_[ug]id. * i386-linux-tdep.c (i386_linux_init_abi): Fix size_[ug]id. --- gdb/ChangeLog | 5 +++++ gdb/arm-linux-tdep.c | 4 ++-- gdb/i386-linux-tdep.c | 4 ++-- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 128ee16..c88a331 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,10 @@ 2015-10-22 Marcin Kościelnicki + * arm-linux-tdep.c (arm_linux_init_abi): Fix size_[ug]id. + * i386-linux-tdep.c (i386_linux_init_abi): Fix size_[ug]id. + +2015-10-22 Marcin Kościelnicki + * aarch64-linux-tdep.c (aarch64_linux_init_abi): Remove size_siginfo. * amd64-linux-tdep.c (amd64_linux_init_abi): Remove size_siginfo. (amd64_x32_linux_init_abi): Remove size_siginfo. diff --git a/gdb/arm-linux-tdep.c b/gdb/arm-linux-tdep.c index 4a100c8..940f01f 100644 --- a/gdb/arm-linux-tdep.c +++ b/gdb/arm-linux-tdep.c @@ -1531,8 +1531,8 @@ arm_linux_init_abi (struct gdbarch_info info, arm_linux_record_tdep.size_stack_t = 12; arm_linux_record_tdep.size_off_t = arm_linux_record_tdep.size_long; arm_linux_record_tdep.size_stat64 = 96; - arm_linux_record_tdep.size_gid_t = 2; - arm_linux_record_tdep.size_uid_t = 2; + arm_linux_record_tdep.size_gid_t = 4; + arm_linux_record_tdep.size_uid_t = 4; arm_linux_record_tdep.size_PAGE_SIZE = 4096; arm_linux_record_tdep.size_flock64 = 24; arm_linux_record_tdep.size_user_desc = 16; diff --git a/gdb/i386-linux-tdep.c b/gdb/i386-linux-tdep.c index 8dce146..af9c28a 100644 --- a/gdb/i386-linux-tdep.c +++ b/gdb/i386-linux-tdep.c @@ -850,8 +850,8 @@ i386_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch) i386_linux_record_tdep.size_stack_t = 12; i386_linux_record_tdep.size_off_t = i386_linux_record_tdep.size_long; i386_linux_record_tdep.size_stat64 = 96; - i386_linux_record_tdep.size_gid_t = 2; - i386_linux_record_tdep.size_uid_t = 2; + i386_linux_record_tdep.size_gid_t = 4; + i386_linux_record_tdep.size_uid_t = 4; i386_linux_record_tdep.size_PAGE_SIZE = 4096; i386_linux_record_tdep.size_flock64 = 24; i386_linux_record_tdep.size_user_desc = 16;