From patchwork Sun Oct 11 07:59:33 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Frysinger X-Patchwork-Id: 9045 X-Patchwork-Delegate: vapier@gentoo.org Received: (qmail 33650 invoked by alias); 11 Oct 2015 07:59:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 33616 invoked by uid 89); 11 Oct 2015 07:59:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sun, 11 Oct 2015 07:59:37 +0000 Received: from localhost.localdomain (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id D03DF340649 for ; Sun, 11 Oct 2015 07:59:35 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: [PATCH] sim: moxie: fix leakage in error path [BZ #18273] Date: Sun, 11 Oct 2015 03:59:33 -0400 Message-Id: <1444550373-4613-1-git-send-email-vapier@gentoo.org> X-IsSubscribed: yes Committed. Reported-by: dcb --- sim/moxie/ChangeLog | 5 +++++ sim/moxie/interp.c | 1 + 2 files changed, 6 insertions(+) diff --git a/sim/moxie/ChangeLog b/sim/moxie/ChangeLog index fe37e82..04b74ce 100644 --- a/sim/moxie/ChangeLog +++ b/sim/moxie/ChangeLog @@ -1,3 +1,8 @@ +2015-10-11 Mike Frysinger + + PR sim/18273 + * interp.c (load_dtb): Close open file in error path. + 2015-06-23 Mike Frysinger * configure: Regenerate. diff --git a/sim/moxie/interp.c b/sim/moxie/interp.c index 35ee2a7..df92cee 100644 --- a/sim/moxie/interp.c +++ b/sim/moxie/interp.c @@ -1273,6 +1273,7 @@ load_dtb (SIM_DESC sd, const char *filename) if (size != fread (buf, 1, size, f)) { sim_io_eprintf (sd, "ERROR: error reading ``%s''.\n", filename); + fclose (f); return; } sim_core_write_buffer (sd, scpu, write_map, buf, 0xE0000000, size);