diff mbox

sim: moxie: fix leakage in error path [BZ #18273]

Message ID 1444550373-4613-1-git-send-email-vapier@gentoo.org
State Committed
Delegated to: Mike Frysinger
Headers show

Commit Message

Mike Frysinger Oct. 11, 2015, 7:59 a.m. UTC
Committed.

Reported-by: dcb <dcb314@hotmail.com>
---
 sim/moxie/ChangeLog | 5 +++++
 sim/moxie/interp.c  | 1 +
 2 files changed, 6 insertions(+)
diff mbox

Patch

diff --git a/sim/moxie/ChangeLog b/sim/moxie/ChangeLog
index fe37e82..04b74ce 100644
--- a/sim/moxie/ChangeLog
+++ b/sim/moxie/ChangeLog
@@ -1,3 +1,8 @@ 
+2015-10-11  Mike Frysinger  <vapier@gentoo.org>
+
+	PR sim/18273
+	* interp.c (load_dtb): Close open file in error path.
+
 2015-06-23  Mike Frysinger  <vapier@gentoo.org>
 
 	* configure: Regenerate.
diff --git a/sim/moxie/interp.c b/sim/moxie/interp.c
index 35ee2a7..df92cee 100644
--- a/sim/moxie/interp.c
+++ b/sim/moxie/interp.c
@@ -1273,6 +1273,7 @@  load_dtb (SIM_DESC sd, const char *filename)
   if (size != fread (buf, 1, size, f))
     {
       sim_io_eprintf (sd, "ERROR: error reading ``%s''.\n", filename);
+      fclose (f);
       return;
     }
   sim_core_write_buffer (sd, scpu, write_map, buf, 0xE0000000, size);