From patchwork Mon Oct 5 16:44:11 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Antoine Tremblay X-Patchwork-Id: 8928 Received: (qmail 129573 invoked by alias); 5 Oct 2015 16:44:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 129419 invoked by uid 89); 5 Oct 2015 16:44:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL, BAYES_00, SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg21.ericsson.net Received: from usevmg21.ericsson.net (HELO usevmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 05 Oct 2015 16:44:38 +0000 Received: from EUSAAHC003.ericsson.se (Unknown_Domain [147.117.188.81]) by usevmg21.ericsson.net (Symantec Mail Security) with SMTP id BE.E3.26730.90D32165; Mon, 5 Oct 2015 11:04:09 +0200 (CEST) Received: from elxa4wqvvz1.dyn.mo.ca.am.ericsson.se (147.117.188.8) by smtps-am.internal.ericsson.com (147.117.188.81) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 5 Oct 2015 12:44:31 -0400 From: Antoine Tremblay To: CC: Antoine Tremblay Subject: [PATCH v2 3/7] Implement breakpoint_from_kind for supported architectures in GDBServer. Date: Mon, 5 Oct 2015 12:44:11 -0400 Message-ID: <1444063455-31558-4-git-send-email-antoine.tremblay@ericsson.com> In-Reply-To: <1444063455-31558-1-git-send-email-antoine.tremblay@ericsson.com> References: <1444063455-31558-1-git-send-email-antoine.tremblay@ericsson.com> MIME-Version: 1.0 X-IsSubscribed: yes This patch implements the breakpoint_from_kind linux_target_ops for architectures that support software breakpoints, namely : x86 and aarch64. No regressions, tested on Ubuntu 14.04 x86. With gdbserver-{native,extended}. Compilation was also tested on aarch64. --- gdb/gdbserver/linux-aarch64-low.c | 9 +++++++++ gdb/gdbserver/linux-x86-low.c | 9 +++++++++ 2 files changed, 18 insertions(+) diff --git a/gdb/gdbserver/linux-aarch64-low.c b/gdb/gdbserver/linux-aarch64-low.c index 1e7a0ff..46b79a5 100644 --- a/gdb/gdbserver/linux-aarch64-low.c +++ b/gdb/gdbserver/linux-aarch64-low.c @@ -3238,6 +3238,14 @@ aarch64_supports_range_stepping (void) return 1; } +/* Implementation of linux_target_ops method "breakpoint_from_kind". */ + +static const unsigned char * +aarch64_breakpoint_from_kind (int *kind) +{ + return (const unsigned char *) &aarch64_breakpoint; +} + struct linux_target_ops the_low_target = { aarch64_arch_setup, @@ -3270,6 +3278,7 @@ struct linux_target_ops the_low_target = aarch64_emit_ops, aarch64_get_min_fast_tracepoint_insn_len, aarch64_supports_range_stepping, + aarch64_breakpoint_from_kind, }; void diff --git a/gdb/gdbserver/linux-x86-low.c b/gdb/gdbserver/linux-x86-low.c index 41803c4..e64b498 100644 --- a/gdb/gdbserver/linux-x86-low.c +++ b/gdb/gdbserver/linux-x86-low.c @@ -3258,6 +3258,14 @@ x86_supports_range_stepping (void) return 1; } +/* Implementation of linux_target_ops method "breakpoint_from_kind". */ + +static const unsigned char * +x86_breakpoint_from_kind (int *kind) +{ + return x86_breakpoint; +} + /* This is initialized assuming an amd64 target. x86_arch_setup will correct it for i386 or amd64 targets. */ @@ -3297,6 +3305,7 @@ struct linux_target_ops the_low_target = x86_emit_ops, x86_get_min_fast_tracepoint_insn_len, x86_supports_range_stepping, + x86_breakpoint_from_kind, }; void