From patchwork Fri Oct 2 11:23:57 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yao Qi X-Patchwork-Id: 8912 Received: (qmail 108894 invoked by alias); 2 Oct 2015 11:24:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 108752 invoked by uid 89); 2 Oct 2015 11:24:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-pa0-f45.google.com Received: from mail-pa0-f45.google.com (HELO mail-pa0-f45.google.com) (209.85.220.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 02 Oct 2015 11:24:08 +0000 Received: by pablk4 with SMTP id lk4so104090108pab.3; Fri, 02 Oct 2015 04:24:06 -0700 (PDT) X-Received: by 10.68.68.197 with SMTP id y5mr19230142pbt.88.1443785046318; Fri, 02 Oct 2015 04:24:06 -0700 (PDT) Received: from E107787-LIN.cambridge.arm.com (power-aix.osuosl.org. [140.211.15.154]) by smtp.gmail.com with ESMTPSA id yq2sm11561338pbb.39.2015.10.02.04.24.04 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 02 Oct 2015 04:24:05 -0700 (PDT) From: Yao Qi X-Google-Original-From: Yao Qi To: marcus.shawcroft@gmail.com Cc: gdb-patches@sourceware.org, binutils@sourceware.org Subject: [PATCH 1/3] [aarch64] Remove argument pc from disas_aarch64_insn Date: Fri, 2 Oct 2015 12:23:57 +0100 Message-Id: <1443785039-24602-2-git-send-email-yao.qi@linaro.org> In-Reply-To: <1443785039-24602-1-git-send-email-yao.qi@linaro.org> References: <1443785039-24602-1-git-send-email-yao.qi@linaro.org> X-IsSubscribed: yes I happen to see that argument pc is not used inside disas_aarch64_insn at all. This patch is to remove it. OK to apply? opcodes: 2015-10-01 Yao Qi * aarch64-dis.c (disas_aarch64_insn): Remove argument PC. (print_insn_aarch64_word): Caller updated. --- opcodes/aarch64-dis.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/opcodes/aarch64-dis.c b/opcodes/aarch64-dis.c index 5fec4ee..e0faeb5 100644 --- a/opcodes/aarch64-dis.c +++ b/opcodes/aarch64-dis.c @@ -2032,8 +2032,7 @@ user_friendly_fixup (aarch64_inst *inst) /* Decode INSN and fill in *INST the instruction information. */ static int -disas_aarch64_insn (uint64_t pc ATTRIBUTE_UNUSED, uint32_t insn, - aarch64_inst *inst) +disas_aarch64_insn (uint32_t insn, aarch64_inst *inst) { const aarch64_opcode *opcode = aarch64_opcode_lookup (insn); @@ -2172,7 +2171,7 @@ print_insn_aarch64_word (bfd_vma pc, addresses, since the addend is not currently pc-relative. */ pc = 0; - ret = disas_aarch64_insn (pc, word, &inst); + ret = disas_aarch64_insn (word, &inst); if (((word >> 21) & 0x3ff) == 1) {