[1/3,aarch64] Remove argument pc from disas_aarch64_insn

Message ID 1443785039-24602-2-git-send-email-yao.qi@linaro.org
State New, archived
Headers

Commit Message

Yao Qi Oct. 2, 2015, 11:23 a.m. UTC
  I happen to see that argument pc is not used inside disas_aarch64_insn
at all.  This patch is to remove it.

OK to apply?

opcodes:

2015-10-01  Yao Qi  <yao.qi@linaro.org>

	* aarch64-dis.c (disas_aarch64_insn): Remove argument PC.
	(print_insn_aarch64_word): Caller updated.
---
 opcodes/aarch64-dis.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
  

Comments

Marcus Shawcroft Oct. 2, 2015, 12:30 p.m. UTC | #1
On 2 October 2015 at 12:23, Yao Qi <qiyaoltc@gmail.com> wrote:
> I happen to see that argument pc is not used inside disas_aarch64_insn
> at all.  This patch is to remove it.
>
> OK to apply?
>
> opcodes:
>
> 2015-10-01  Yao Qi  <yao.qi@linaro.org>
>
>         * aarch64-dis.c (disas_aarch64_insn): Remove argument PC.
>         (print_insn_aarch64_word): Caller updated.

Ok /Marcus
  

Patch

diff --git a/opcodes/aarch64-dis.c b/opcodes/aarch64-dis.c
index 5fec4ee..e0faeb5 100644
--- a/opcodes/aarch64-dis.c
+++ b/opcodes/aarch64-dis.c
@@ -2032,8 +2032,7 @@  user_friendly_fixup (aarch64_inst *inst)
 /* Decode INSN and fill in *INST the instruction information.  */
 
 static int
-disas_aarch64_insn (uint64_t pc ATTRIBUTE_UNUSED, uint32_t insn,
-		    aarch64_inst *inst)
+disas_aarch64_insn (uint32_t insn, aarch64_inst *inst)
 {
   const aarch64_opcode *opcode = aarch64_opcode_lookup (insn);
 
@@ -2172,7 +2171,7 @@  print_insn_aarch64_word (bfd_vma pc,
        addresses, since the addend is not currently pc-relative.  */
     pc = 0;
 
-  ret = disas_aarch64_insn (pc, word, &inst);
+  ret = disas_aarch64_insn (word, &inst);
 
   if (((word >> 21) & 0x3ff) == 1)
     {