From patchwork Wed Sep 2 04:37:58 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergio Durigan Junior X-Patchwork-Id: 8554 Received: (qmail 8981 invoked by alias); 2 Sep 2015 04:38:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 8971 invoked by uid 89); 2 Sep 2015 04:38:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.1 required=5.0 tests=AWL, BAYES_50, KAM_LAZY_DOMAIN_SECURITY, SPF_HELO_PASS, T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 02 Sep 2015 04:38:11 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id B6C44C0EE05D for ; Wed, 2 Sep 2015 04:38:10 +0000 (UTC) Received: from psique.yyz.redhat.com (unused-10-15-17-51.yyz.redhat.com [10.15.17.51]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t824cAwH017649; Wed, 2 Sep 2015 00:38:10 -0400 From: Sergio Durigan Junior To: GDB Patches Cc: Sergio Durigan Junior Subject: [PATCH] Initialize variable and silence GCC warning from last commit Date: Wed, 2 Sep 2015 00:37:58 -0400 Message-Id: <1441168678-15805-1-git-send-email-sergiodj@redhat.com> In-Reply-To: <87pp215u3f.fsf@redhat.com> References: <87pp215u3f.fsf@redhat.com> X-IsSubscribed: yes BuildBot e-mailed me to let me know that my last commit broke GDB on RHEL-7.1 s390x. On solib-svr4.c:svr4_handle_solib_event, 'val' now needs to be initialized as NULL because it is inside a TRY..CATCH block. This patch does that. Pushed as obvious. gdb/ChangeLog: 2015-09-01 Sergio Durigan Junior * solib-svr4.c (svr4_handle_solib_event): Initialize 'val' as NULL --- gdb/ChangeLog | 4 ++++ gdb/solib-svr4.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 8ed469f..80fff7e 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,9 @@ 2015-09-01 Sergio Durigan Junior + * solib-svr4.c (svr4_handle_solib_event): Initialize 'val' as NULL + +2015-09-01 Sergio Durigan Junior + * solib-svr4.c (solib_event_probe_action): Call get_probe_argument_count using TRY...CATCH. (svr4_handle_solib_event): Likewise, for evaluate_probe_argument. diff --git a/gdb/solib-svr4.c b/gdb/solib-svr4.c index 5d2b9dd..d3411fa 100644 --- a/gdb/solib-svr4.c +++ b/gdb/solib-svr4.c @@ -1908,7 +1908,7 @@ svr4_handle_solib_event (void) struct probe_and_action *pa; enum probe_action action; struct cleanup *old_chain, *usm_chain; - struct value *val; + struct value *val = NULL; CORE_ADDR pc, debug_base, lm = 0; int is_initial_ns; struct frame_info *frame = get_current_frame ();