From patchwork Wed Aug 5 21:44:39 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 8027 Received: (qmail 88615 invoked by alias); 5 Aug 2015 21:44:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 88605 invoked by uid 89); 5 Aug 2015 21:44:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL, BAYES_05, SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg21.ericsson.net Received: from usevmg21.ericsson.net (HELO usevmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 05 Aug 2015 21:44:46 +0000 Received: from EUSAAHC006.ericsson.se (Unknown_Domain [147.117.188.90]) by usevmg21.ericsson.net (Symantec Mail Security) with SMTP id 38.92.00712.40B12C55; Wed, 5 Aug 2015 16:17:40 +0200 (CEST) Received: from elxcz23q12-y4.dyn.mo.ca.am.ericsson.se (147.117.188.8) by smtps-am.internal.ericsson.com (147.117.188.90) with Microsoft SMTP Server (TLS) id 14.3.210.2; Wed, 5 Aug 2015 17:44:43 -0400 From: Simon Marchi To: CC: Simon Marchi Subject: [PATCH] Change type of struct complaints::series Date: Wed, 5 Aug 2015 17:44:39 -0400 Message-ID: <1438811079-25809-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 X-IsSubscribed: yes Found while processing the C++ enum changes. It seems like series should be of type enum complaint_series, instead of adding a cast. If somebody could guide me a little bit, I think I could clean up the comments around this. The comments on enum complaint_series and the series field seem redundant and maybe out of date. Do the "case N" in the comments refer to the enum values? If so they don't seem to match the actual values. gdb/ChangeLog: * complaints.c (enum complaint_series): Add newlines. (struct complaints) : Change type to enum complaint_series. (symfile_complaint_hook): Use equivalent enum value ISOLATED_MESSAGE instead of 0. --- gdb/complaints.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/gdb/complaints.c b/gdb/complaints.c index dbacb2a..3566904 100644 --- a/gdb/complaints.c +++ b/gdb/complaints.c @@ -34,11 +34,14 @@ extern void _initialize_complaints (void); enum complaint_series { /* Isolated self explanatory message. */ ISOLATED_MESSAGE, + /* First message of a series, includes an explanation. */ FIRST_MESSAGE, + /* First message of a series, but does not need to include any sort of explanation. */ SHORT_FIRST_MESSAGE, + /* Subsequent message of a series that needs no explanation (the user already knows we have a problem so we can just state our piece). */ @@ -75,7 +78,7 @@ struct complaints must start off with explanation. case 2: Subsequent message of a series that needs no explanation (the user already knows we have a problem so we can just state our piece). */ - int series; + enum complaint_series series; /* The explanatory messages that should accompany the complaint. NOTE: cagney/2002-08-14: In a desperate attempt at being vaguely @@ -99,7 +102,7 @@ static struct explanation symfile_explanations[] = { static struct complaints symfile_complaint_book = { &complaint_sentinel, - 0, + ISOLATED_MESSAGE, symfile_explanations }; struct complaints *symfile_complaints = &symfile_complaint_book;