diff mbox

Remove xfail in gdb.mi/mi-watch.exp

Message ID 1437848090-19119-1-git-send-email-simon.marchi@polymtl.ca
State New, archived
Headers

Commit Message

Simon Marchi July 25, 2015, 6:14 p.m. UTC 
  I noticed there was an unexpected pass in mi-watch.exp when running on
x86_64.  Doing a bit of archeology shows that the xfail was added by
4a543da.  This particular test failed on the MIPS architecture, which
the original contributor was working with.  Here is the thread:

https://www.sourceware.org/ml/gdb-patches/2007-09/msg00151.html

Looking at the latest buildbot results for MIPS, it seems that it's also
an unexpected pass on that architecture.  Therefore, I see no reason to
leave the xfail in place.

gdb/testsuite/ChangeLog:

	* gdb.mi/mi-watch.exp (test_watchpoint_triggering): Remove xfail.
---
 gdb/testsuite/gdb.mi/mi-watch.exp | 4 ----
 1 file changed, 4 deletions(-)

Comments

Doug Evans July 26, 2015, 4:58 p.m. UTC | #1 
On Sat, Jul 25, 2015 at 11:14 AM, Simon Marchi <simon.marchi@polymtl.ca> wrote:
> I noticed there was an unexpected pass in mi-watch.exp when running on
> x86_64.  Doing a bit of archeology shows that the xfail was added by
> 4a543da.  This particular test failed on the MIPS architecture, which
> the original contributor was working with.  Here is the thread:
>
> https://www.sourceware.org/ml/gdb-patches/2007-09/msg00151.html
>
> Looking at the latest buildbot results for MIPS, it seems that it's also
> an unexpected pass on that architecture.  Therefore, I see no reason to
> leave the xfail in place.
>
> gdb/testsuite/ChangeLog:
>
>         * gdb.mi/mi-watch.exp (test_watchpoint_triggering): Remove xfail.
> ---
>  gdb/testsuite/gdb.mi/mi-watch.exp | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/gdb/testsuite/gdb.mi/mi-watch.exp b/gdb/testsuite/gdb.mi/mi-watch.exp
> index 2551d42..4f87a5a 100644
> --- a/gdb/testsuite/gdb.mi/mi-watch.exp
> +++ b/gdb/testsuite/gdb.mi/mi-watch.exp
> @@ -131,14 +131,10 @@ proc test_watchpoint_triggering {type} {
>          {"" "wpt=\{number=\"2\",exp=\"C\"\},value=\{old=\".*\",new=\"3\"\}"} \
>          "watchpoint trigger"
>
> -    if { $type == "sw" } {
> -      setup_xfail *-*-*
> -    }
>      mi_execute_to "exec-continue" "watchpoint-scope" "callee3" ".*" \
>          ".*basics.c" $line_callee3_close_brace \
>          {"" "wpnum=\"2\""} \
>          "watchpoint trigger"
> -    clear_xfail *-*-*
>  }
>
>  proc test_watchpoint_all {type} {

LGTM.  Thanks!
Simon Marchi July 27, 2015, 7:03 p.m. UTC | #2 
On 15-07-26 12:58 PM, Doug Evans wrote:
> LGTM.  Thanks!

Pushed, thanks!
diff mbox

Patch

diff --git a/gdb/testsuite/gdb.mi/mi-watch.exp b/gdb/testsuite/gdb.mi/mi-watch.exp
index 2551d42..4f87a5a 100644
--- a/gdb/testsuite/gdb.mi/mi-watch.exp
+++ b/gdb/testsuite/gdb.mi/mi-watch.exp
@@ -131,14 +131,10 @@  proc test_watchpoint_triggering {type} {
         {"" "wpt=\{number=\"2\",exp=\"C\"\},value=\{old=\".*\",new=\"3\"\}"} \
         "watchpoint trigger"
 
-    if { $type == "sw" } {
-      setup_xfail *-*-*
-    }
     mi_execute_to "exec-continue" "watchpoint-scope" "callee3" ".*" \
         ".*basics.c" $line_callee3_close_brace \
         {"" "wpnum=\"2\""} \
         "watchpoint trigger"
-    clear_xfail *-*-*
 }
 
 proc test_watchpoint_all {type} {