From patchwork Sat Jul 25 15:38:33 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrick Palka X-Patchwork-Id: 7853 Received: (qmail 41724 invoked by alias); 25 Jul 2015 15:38:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 41715 invoked by uid 89); 25 Jul 2015 15:38:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mail-qg0-f42.google.com Received: from mail-qg0-f42.google.com (HELO mail-qg0-f42.google.com) (209.85.192.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sat, 25 Jul 2015 15:38:41 +0000 Received: by qged69 with SMTP id d69so26554461qge.0 for ; Sat, 25 Jul 2015 08:38:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=vWubJOgtBkQpOIRS+PvS4HuBdnyLY1Ky2unxy4+Knp4=; b=lYI3Y24W8iUysQYFBUWABnVIC+l9C31X7OwLfw4m+Du41owy6vtIw7FVlX9wkrI+Ij IpuKOdRcnRmsf7ykc11indzA/7Uwi/qEcviARO/lVt5YwI1G/Hz21ZN3vmAMTQ3EZcqk RltOl+dCxi2vXyhEztE739yay68KgDyk8inQkMS+G/CBNNWPakgtnYbBJdNn5rK5I5Px zJZL4VrH4advWnP0RbuUh2cuZu9GGg4QilenxqWDPoJfxSHiUtTQwezekqMTKqePjoC8 VMaVohh8GwNHCtdZmn6sU0m4CYFwxEapm4PxXU9B8J8LgdhGAYvFsKmg0OGeoNEyPOR2 ChTA== X-Gm-Message-State: ALoCoQnpJLyIrw2Zn+0kYp+Vq9u9gxui6OQg9jEXrviChSfBJrtGqgJKT6wVjWyDtqCQQd/1xtxq X-Received: by 10.140.83.178 with SMTP id j47mr28331372qgd.18.1437838719667; Sat, 25 Jul 2015 08:38:39 -0700 (PDT) Received: from localhost.localdomain (ool-4353acd8.dyn.optonline.net. [67.83.172.216]) by smtp.gmail.com with ESMTPSA id f189sm5805235qhc.6.2015.07.25.08.38.38 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 25 Jul 2015 08:38:39 -0700 (PDT) From: Patrick Palka To: gdb-patches@sourceware.org Cc: sergiodj@redhat.com, palves@redhat.com, Patrick Palka Subject: [PATCH] [COMMITTED] Don't build readline's shared libs by default Date: Sat, 25 Jul 2015 11:38:33 -0400 Message-Id: <1437838713-8216-1-git-send-email-patrick@parcs.ath.cx> Since the sync to version 7.0-alpho, readline now by default builds (unused) shared libraries alongside static libraries, whereas before it only built static libraries. A couple of GDB buildbots were not happy with this change: http://gdb-build.sergiodj.net/builders/AIX-POWER7-plain/builds/240 http://gdb-build.sergiodj.net/builders/Fedora-i686/builds/1518 To get these buildbots building again, this patch alters readline's configure.ac file to not build shared libraries by default, as was the case with readline 6.2. A more permanent fix may be to alter the top-level Makefile.def to pass --disable-shared to readline, or to investigate why these building these shared libraries are giving the buildbots trouble. (I think the proximate reason why the i686 buildbot fails is because it passes CFLAGS=-m32 instead of CC="gcc -m32" to the top-level configure script, and readline's linker commands don't inherit CFLAGS. Not sure about the AIX failure.) readline/ChangeLog.gdb: * configure.ac: Default opt_shared_libs to no. * configure: Regenerate. --- readline/ChangeLog.gdb | 5 +++++ readline/configure | 2 +- readline/configure.ac | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/readline/ChangeLog.gdb b/readline/ChangeLog.gdb index 2a9a1b2..013727d 100644 --- a/readline/ChangeLog.gdb +++ b/readline/ChangeLog.gdb @@ -1,5 +1,10 @@ 2015-07-25 Patrick Palka + * configure.ac: Default opt_shared_libs to no. + * configure: Regenerate. + +2015-07-25 Patrick Palka + Import readline 7.0 alpha * configure: Regenerate. * examples/rlfe/configure: Regenerate. diff --git a/readline/configure b/readline/configure index 3af8fbe..813e379 100755 --- a/readline/configure +++ b/readline/configure @@ -2352,7 +2352,7 @@ fi opt_multibyte=yes opt_static_libs=yes -opt_shared_libs=yes +opt_shared_libs=no # Check whether --enable-multibyte was given. if test "${enable_multibyte+set}" = set; then : diff --git a/readline/configure.ac b/readline/configure.ac index 42e21fa..b4fa645 100644 --- a/readline/configure.ac +++ b/readline/configure.ac @@ -58,7 +58,7 @@ fi dnl option parsing for optional features opt_multibyte=yes opt_static_libs=yes -opt_shared_libs=yes +opt_shared_libs=no AC_ARG_ENABLE(multibyte, AC_HELP_STRING([--enable-multibyte], [enable multibyte characters if OS supports them]), opt_multibyte=$enableval) AC_ARG_ENABLE(shared, AC_HELP_STRING([--enable-shared], [build shared libraries [[default=YES]]]), opt_shared_libs=$enableval)