From patchwork Thu Jul 9 16:54:05 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre Langlois X-Patchwork-Id: 7620 Received: (qmail 105430 invoked by alias); 9 Jul 2015 16:54:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 105415 invoked by uid 89); 9 Jul 2015 16:54:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL, BAYES_00, SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (207.82.80.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 09 Jul 2015 16:54:17 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-8-Z5DNPaFNR6OuoFfK_9o2cQ-1; Thu, 09 Jul 2015 17:54:06 +0100 Received: from e105615-lin.cambridge.arm.com ([10.1.2.79]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 9 Jul 2015 17:54:06 +0100 From: Pierre Langlois To: gdb-patches@sourceware.org Cc: Pierre Langlois Subject: [PATCH] [testsuite] Skip gdb.trace/range-stepping.exp test case if not supported Date: Thu, 9 Jul 2015 17:54:05 +0100 Message-Id: <1436460845-22411-1-git-send-email-pierre.langlois@arm.com> X-MC-Unique: Z5DNPaFNR6OuoFfK_9o2cQ-1 X-IsSubscribed: yes Hi all, Tracepoints and range stepping are independent features. This patch skips the gdb.trace/range-stepping.exp test case if the target does not support range stepping. Thanks, Pierre gdb/testsuite/ChangeLog: * gdb.base/range-stepping.exp (gdb_range_stepping_enabled): Move * lib/range-stepping-support.exp (gdb_range_stepping_enabled): ... to here. * gdb.trace/range-stepping.exp: Check that the target supports range stepping. --- gdb/testsuite/gdb.base/range-stepping.exp | 21 --------------------- gdb/testsuite/gdb.trace/range-stepping.exp | 5 +++++ gdb/testsuite/lib/range-stepping-support.exp | 21 +++++++++++++++++++++ 3 files changed, 26 insertions(+), 21 deletions(-) diff --git a/gdb/testsuite/gdb.base/range-stepping.exp b/gdb/testsuite/gdb.base/range-stepping.exp index 3b8db7b..2ff371d 100644 --- a/gdb/testsuite/gdb.base/range-stepping.exp +++ b/gdb/testsuite/gdb.base/range-stepping.exp @@ -27,27 +27,6 @@ if ![runto_main] { return -1 } -# Check whether range stepping is supported by the target. - -proc gdb_range_stepping_enabled { } { - global gdb_prompt - - set command "set range-stepping on" - set message "probe range-stepping support" - gdb_test_multiple $command $message { - -re "Range stepping is not supported.*\r\n$gdb_prompt $" { - pass $message - return 0 - } - -re "^$command\r\n$gdb_prompt $" { - pass $message - return 1 - } - } - - return 0 -} - if ![gdb_range_stepping_enabled] { unsupported "range stepping not supported by the target" return -1 diff --git a/gdb/testsuite/gdb.trace/range-stepping.exp b/gdb/testsuite/gdb.trace/range-stepping.exp index e711072..dfc16d5 100644 --- a/gdb/testsuite/gdb.trace/range-stepping.exp +++ b/gdb/testsuite/gdb.trace/range-stepping.exp @@ -34,6 +34,11 @@ if ![gdb_target_supports_trace] { return -1 } +if ![gdb_range_stepping_enabled] { + unsupported "range stepping not supported by the target" + return -1 +} + # Check that range stepping works well with tracepoints. proc range_stepping_with_tracepoint { type } { diff --git a/gdb/testsuite/lib/range-stepping-support.exp b/gdb/testsuite/lib/range-stepping-support.exp index 986216e..d6c0e85 100644 --- a/gdb/testsuite/lib/range-stepping-support.exp +++ b/gdb/testsuite/lib/range-stepping-support.exp @@ -52,3 +52,24 @@ proc exec_cmd_expect_vCont_count { cmd exp_vCont_s exp_vCont_r } { gdb_test_no_output "set debug remote 0" "" return $ret } + +# Check whether range stepping is supported by the target. + +proc gdb_range_stepping_enabled { } { + global gdb_prompt + + set command "set range-stepping on" + set message "probe range-stepping support" + gdb_test_multiple $command $message { + -re "Range stepping is not supported.*\r\n$gdb_prompt $" { + pass $message + return 0 + } + -re "^$command\r\n$gdb_prompt $" { + pass $message + return 1 + } + } + + return 0 +}