From patchwork Sun Jul 5 21:03:57 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrick Palka X-Patchwork-Id: 7519 Received: (qmail 65158 invoked by alias); 5 Jul 2015 21:04:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 65148 invoked by uid 89); 5 Jul 2015 21:04:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mail-qk0-f178.google.com Received: from mail-qk0-f178.google.com (HELO mail-qk0-f178.google.com) (209.85.220.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sun, 05 Jul 2015 21:04:14 +0000 Received: by qkeo142 with SMTP id o142so105968639qke.1 for ; Sun, 05 Jul 2015 14:04:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=4DvnVrmoUOPp51w6cUb5/M3hl5GAudeFDnsGpinsyJ0=; b=Hs5q3037/TFgosb6/h3u3BaWKL9hJ/Logk6A8KUHha+DELHGjJtCFguOqAVcPMBMe6 YHyVdv+a63r+5Qc5qvxcPwwj2WGI0VG9OwjGsvx1EKC/EnwaJuOfADKfeIprTL2eT4c7 saVKTFTo4MGX4+wKVey+wTIOd+wgfXRaofZ2mKbjIayIkOYV1FISs8fL9UDsTPqeMl8+ LXhF98GJlQsC2FDtxGTi9OcYMAwGelaoyHxVMED7cgflM4D7Kzr+hXRpg0bZoUVj3mBY pb9utKbPG4dNvqEc1yExvSyyp09LmZo+81dpXNIH/1/v8egDdcNtL0mH2wRXieQJ/cL6 dlcQ== X-Gm-Message-State: ALoCoQk+zb7hznzHfqQS6JSDCuTDMsuM5DmlObWSRExzkkezxb6xoVSTnDKuO8OZDdePM8u28oYY X-Received: by 10.55.23.218 with SMTP id 87mr88674728qkx.36.1436130251845; Sun, 05 Jul 2015 14:04:11 -0700 (PDT) Received: from localhost.localdomain (ool-4353acd8.dyn.optonline.net. [67.83.172.216]) by mx.google.com with ESMTPSA id 131sm8181073qhf.14.2015.07.05.14.04.10 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 05 Jul 2015 14:04:11 -0700 (PDT) From: Patrick Palka To: gdb-patches@sourceware.org Cc: Patrick Palka Subject: [PATCH 1/5] tui: reset start_line whenever cur_line is reset Date: Sun, 5 Jul 2015 17:03:57 -0400 Message-Id: <1436130241-21443-1-git-send-email-patrick@parcs.ath.cx> In-Reply-To: <1436130177-21362-1-git-send-email-patrick@parcs.ath.cx> References: <1436130177-21362-1-git-send-email-patrick@parcs.ath.cx> Whenever the command window's cur_line is reset to 0, so should start_line. This is because there is an implicit invariant that 0 <= start_line <= cur_line. gdb/ChangeLog: * tui/tui-data.c (tui_clear_win_detail) [CMD_WIN]: Also reset start_line. (init_win_info) [CMD_WIN]: Ditto. * tui/tui-win.c (make_visible_with_new_height) [CMD_WIN]: Ditto. --- gdb/tui/tui-data.c | 6 ++++-- gdb/tui/tui-win.c | 1 + 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/gdb/tui/tui-data.c b/gdb/tui/tui-data.c index ed42c8d..e9aa7b3 100644 --- a/gdb/tui/tui-data.c +++ b/gdb/tui/tui-data.c @@ -212,8 +212,9 @@ tui_clear_win_detail (struct tui_win_info *win_info) win_info->detail.source_info.horizontal_offset = 0; break; case CMD_WIN: - win_info->detail.command_info.cur_line = - win_info->detail.command_info.curch = 0; + win_info->detail.command_info.start_line = 0; + win_info->detail.command_info.cur_line = 0; + win_info->detail.command_info.curch = 0; break; case DATA_WIN: win_info->detail.data_display_info.data_content = @@ -545,6 +546,7 @@ init_win_info (struct tui_win_info *win_info) win_info->detail.data_display_info.current_group = 0; break; case CMD_WIN: + win_info->detail.command_info.start_line = 0; win_info->detail.command_info.cur_line = 0; win_info->detail.command_info.curch = 0; break; diff --git a/gdb/tui/tui-win.c b/gdb/tui/tui-win.c index feb360b..0150900 100644 --- a/gdb/tui/tui-win.c +++ b/gdb/tui/tui-win.c @@ -1510,6 +1510,7 @@ make_visible_with_new_height (struct tui_win_info *win_info) tui_display_all_data (); break; case CMD_WIN: + win_info->detail.command_info.start_line = 0; win_info->detail.command_info.cur_line = 0; win_info->detail.command_info.curch = 0; #ifdef HAVE_WRESIZE