From patchwork Sun Jun 28 04:00:30 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Galvan X-Patchwork-Id: 7415 Received: (qmail 58673 invoked by alias); 28 Jun 2015 04:01:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 58621 invoked by uid 89); 28 Jun 2015 04:00:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qc0-f175.google.com Received: from mail-qc0-f175.google.com (HELO mail-qc0-f175.google.com) (209.85.216.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sun, 28 Jun 2015 04:00:52 +0000 Received: by qczu9 with SMTP id u9so10675456qcz.3 for ; Sat, 27 Jun 2015 21:00:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id; bh=R4GhT5qQ2aH+0DI3bqFIJuWejIsUn5ezp4y1NdrtM4o=; b=mnkdsg0kSm3a3TZtHCwunf8BXy9hX6nguHogQPB3eTwbOGUjfl/SFz5vvC6vP3J3W/ eC1InX/EtSpfNTX1F+sGWM8tGRdrAS5dX/tYaC4CndtcASFRtBuupm4LhtE0409+jWrU YUVU5Lmsmwe1TV8lipdqoE9wwe4rRfSIpjVV+m/OH3PBls366bZFrKbuYdYjbLww0Tx8 +lAh8tjJrQWBNGftwhfG4bLKcETxLByo/2+LRN/n1oGJWWLCFLaOInnSN5ZDZyQnZl1N RTiaiGIssnXKVOokFY594JFjGkgmmfRw71/pwHTuvO/2l8UWn46F6cakcY2sI28oaCgl xc2g== X-Gm-Message-State: ALoCoQmakzUGnHTyS8rHRi5t5J+cTxt2ET8HV6AvQRIeg8n3DgR+AELOs+P5puRAJ9dPdT4F/Ejb X-Received: by 10.140.108.201 with SMTP id j67mr11857793qgf.83.1435464050321; Sat, 27 Jun 2015 21:00:50 -0700 (PDT) Received: from localhost.localdomain ([181.31.101.84]) by mx.google.com with ESMTPSA id b77sm8302282qkb.8.2015.06.27.21.00.46 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 27 Jun 2015 21:00:49 -0700 (PDT) From: Martin Galvan To: gdb-patches@sourceware.org, qiyaoltc@gmail.com, dje@google.com Subject: [PATCH] testsuite: Remove the unneeded escaping of '[' and ']' characters in test_class_help Date: Sun, 28 Jun 2015 01:00:30 -0300 Message-Id: <1435464030-22372-1-git-send-email-martin.galvan@tallertechnologies.com> From here: https://sourceware.org/ml/gdb-patches/2015-06/msg00484.html we concluded that, as these characters don't need to be escaped for strings wrapped inside {} braces, we can remove the unneeded backslashes. Ok to commit? --- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/lib/gdb.exp | 8 +++++--- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 89d8e32..014132a 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2015-06-28 Martin Galvan + + * lib/gdb.exp (test_class_help): Remove the unneeded escaping of + '[' and ']' characters. + 2015-06-26 Keith Seitz Doug Evans diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index c0e0cb1..381297a 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -4694,11 +4694,13 @@ proc help_test_raw { gdb_command expected_lines args } { # are regular expressions that should match the beginning of output, # before the list of commands in that class. The presence of # command list and standard epilogue will be tested automatically. +# Notice that the '[' and ']' characters don't need to be escaped for strings +# wrapped in {} braces. proc test_class_help { command_class expected_initial_lines args } { set l_stock_body { - "List of commands\:.*\[\r\n\]+" - "Type \"help\" followed by command name for full documentation\.\[\r\n\]+" - "Type \"apropos word\" to search for commands related to \"word\"\.[\r\n\]+" + "List of commands\:.*[\r\n]+" + "Type \"help\" followed by command name for full documentation\.[\r\n]+" + "Type \"apropos word\" to search for commands related to \"word\"\.[\r\n]+" "Command name abbreviations are allowed if unambiguous\." } set l_entire_body [concat $expected_initial_lines $l_stock_body]