[2/2,GDBServer,AArch64] Enable support for Z0 packets

Message ID 1435326128-13705-3-git-send-email-pierre.langlois@arm.com
State New, archived
Headers

Commit Message

Pierre Langlois June 26, 2015, 1:42 p.m. UTC
  This patch lets GDBServer handle software breakpoints instead of relying
on GDB.

gdb/gdbserver/ChangeLog:

	* linux-aarch64-low.c (aarch64_supports_z_point_type): Enable for
	Z_PACKET_SW_BP.
---
 gdb/gdbserver/ChangeLog           | 5 +++++
 gdb/gdbserver/linux-aarch64-low.c | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)
  

Comments

Yao Qi June 29, 2015, 8:08 a.m. UTC | #1
Pierre Langlois <pierre.langlois@arm.com> writes:

> This patch lets GDBServer handle software breakpoints instead of relying
> on GDB.
>
> gdb/gdbserver/ChangeLog:
>
> 	* linux-aarch64-low.c (aarch64_supports_z_point_type): Enable for
> 	Z_PACKET_SW_BP.

This patch is OK to me.
  

Patch

diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
index dde7e9e..6873b0c 100644
--- a/gdb/gdbserver/ChangeLog
+++ b/gdb/gdbserver/ChangeLog
@@ -1,5 +1,10 @@ 
 2015-06-26  Pierre Langlois  <pierre.langlois@arm.com>
 
+	* linux-aarch64-low.c (aarch64_supports_z_point_type): Enable for
+	Z_PACKET_SW_BP.
+
+2015-06-26  Pierre Langlois  <pierre.langlois@arm.com>
+
 	* linux-aarch64-low.c: Remove comment about endianness.
 	(aarch64_breakpoint): Change type to gdb_byte[].  Set to "brk #0".
 	(aarch64_breakpoint_at): Change type of insn to gdb_byte[].  Use
diff --git a/gdb/gdbserver/linux-aarch64-low.c b/gdb/gdbserver/linux-aarch64-low.c
index b0a2775..8a30b00 100644
--- a/gdb/gdbserver/linux-aarch64-low.c
+++ b/gdb/gdbserver/linux-aarch64-low.c
@@ -952,13 +952,13 @@  aarch64_supports_z_point_type (char z_type)
 {
   switch (z_type)
     {
+    case Z_PACKET_SW_BP:
     case Z_PACKET_HW_BP:
     case Z_PACKET_WRITE_WP:
     case Z_PACKET_READ_WP:
     case Z_PACKET_ACCESS_WP:
       return 1;
     default:
-      /* Leave the handling of sw breakpoints with the gdb client.  */
       return 0;
     }
 }