sim: syscall: simplify unknown syscall trace
Commit Message
Since we always include the raw syscall number when tracing, also
including it in the name when it's unknown is redundant. Simplify
the code by using a constant string.
Committed.
---
sim/common/ChangeLog | 5 +++++
sim/common/sim-syscall.c | 7 ++-----
2 files changed, 7 insertions(+), 5 deletions(-)
@@ -1,5 +1,10 @@
2015-06-18 Mike Frysinger <vapier@gentoo.org>
+ * sim-syscall.c (sim_syscall_multi): Change unknown_syscall to a
+ constant string.
+
+2015-06-18 Mike Frysinger <vapier@gentoo.org>
+
* callback.c (cb_target_map_entry, cb_host_map_entry): Change map to
m for sentinel testing.
@@ -60,7 +60,7 @@ sim_syscall_multi (SIM_CPU *cpu, int func, long arg1, long arg2, long arg3,
SIM_DESC sd = CPU_STATE (cpu);
host_callback *cb = STATE_CALLBACK (sd);
CB_SYSCALL sc;
- char unknown_syscall[30];
+ const char unknown_syscall[] = "<UNKNOWN SYSCALL>";
const char *syscall;
CB_SYSCALL_INIT (&sc);
@@ -85,10 +85,7 @@ sim_syscall_multi (SIM_CPU *cpu, int func, long arg1, long arg2, long arg3,
syscall = cb_target_str_syscall (cb, func);
if (!syscall)
- {
- sprintf (unknown_syscall, "syscall_%i", func);
- syscall = unknown_syscall;
- }
+ syscall = unknown_syscall;
if (sc.result == -1)
TRACE_SYSCALL (cpu, "%s[%i](%#lx, %#lx, %#lx) = %li (error = %s[%i])",