diff mbox

py-prettyprint.exp: Add is_address_zero_readable check

Message ID 1433883156-31475-1-git-send-email-simon.marchi@ericsson.com
State New
Headers show

Commit Message

Simon Marchi June 9, 2015, 8:52 p.m. UTC
gdb/testsuite/ChangeLog:

	* gdb.python/py-prettyprint.exp (run_lang_tests): Add
	is_address_zero_readable check.
---
 gdb/testsuite/gdb.python/py-prettyprint.exp | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Simon Marchi June 22, 2015, 2:24 p.m. UTC | #1
On 15-06-09 04:52 PM, Simon Marchi wrote:
> gdb/testsuite/ChangeLog:
> 
> 	* gdb.python/py-prettyprint.exp (run_lang_tests): Add
> 	is_address_zero_readable check.
> ---
>  gdb/testsuite/gdb.python/py-prettyprint.exp | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/gdb/testsuite/gdb.python/py-prettyprint.exp b/gdb/testsuite/gdb.python/py-prettyprint.exp
> index 399f041..bbcee56 100644
> --- a/gdb/testsuite/gdb.python/py-prettyprint.exp
> +++ b/gdb/testsuite/gdb.python/py-prettyprint.exp
> @@ -92,8 +92,10 @@ proc run_lang_tests {exefile lang} {
>      gdb_test "print cstring" " = \"const string\""
>  
>      gdb_test "print estring" " = \"embedded x\\\\201\\\\202\\\\203\\\\204\""
> -    gdb_test "print estring3" \
> -	" = <error reading variable: Cannot create a lazy string with address 0x0, and a non-zero length.>"
> +    if { ![is_address_zero_readable] } {
> +	    gdb_test "print estring3" \
> +		" = <error reading variable: Cannot create a lazy string with address 0x0, and a non-zero length.>"
> +    }
>  
>      gdb_test_no_output "python pp_ls_encoding = 'UTF-8'"
>      gdb_test "print estring2" "\"embedded \", <incomplete sequence \\\\302>"

Ping.
Pedro Alves June 24, 2015, 10:30 a.m. UTC | #2
On 06/09/2015 09:52 PM, Simon Marchi wrote:
> gdb/testsuite/ChangeLog:
> 
> 	* gdb.python/py-prettyprint.exp (run_lang_tests): Add
> 	is_address_zero_readable check.

OK.

Thanks,
Pedro Alves
Simon Marchi June 25, 2015, 5:34 p.m. UTC | #3
On 15-06-24 06:30 AM, Pedro Alves wrote:
> On 06/09/2015 09:52 PM, Simon Marchi wrote:
>> gdb/testsuite/ChangeLog:
>>
>> 	* gdb.python/py-prettyprint.exp (run_lang_tests): Add
>> 	is_address_zero_readable check.
> 
> OK.
> 
> Thanks,
> Pedro Alves

Thanks, pushed.
diff mbox

Patch

diff --git a/gdb/testsuite/gdb.python/py-prettyprint.exp b/gdb/testsuite/gdb.python/py-prettyprint.exp
index 399f041..bbcee56 100644
--- a/gdb/testsuite/gdb.python/py-prettyprint.exp
+++ b/gdb/testsuite/gdb.python/py-prettyprint.exp
@@ -92,8 +92,10 @@  proc run_lang_tests {exefile lang} {
     gdb_test "print cstring" " = \"const string\""
 
     gdb_test "print estring" " = \"embedded x\\\\201\\\\202\\\\203\\\\204\""
-    gdb_test "print estring3" \
-	" = <error reading variable: Cannot create a lazy string with address 0x0, and a non-zero length.>"
+    if { ![is_address_zero_readable] } {
+	    gdb_test "print estring3" \
+		" = <error reading variable: Cannot create a lazy string with address 0x0, and a non-zero length.>"
+    }
 
     gdb_test_no_output "python pp_ls_encoding = 'UTF-8'"
     gdb_test "print estring2" "\"embedded \", <incomplete sequence \\\\302>"