From patchwork Tue May 5 18:02:49 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Brobecker X-Patchwork-Id: 6569 Received: (qmail 94769 invoked by alias); 5 May 2015 18:02:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 94752 invoked by uid 89); 5 May 2015 18:02:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL, BAYES_00, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 05 May 2015 18:02:53 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 696F7285AE for ; Tue, 5 May 2015 14:02:51 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id FiiV7lYuU7aU for ; Tue, 5 May 2015 14:02:51 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 39819D3CE8 for ; Tue, 5 May 2015 14:02:51 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 4794F40EAD; Tue, 5 May 2015 11:02:51 -0700 (PDT) From: Joel Brobecker To: gdb-patches@sourceware.org Subject: [RFA/doco/commit] Make the "info dll" command available on all platform. Date: Tue, 5 May 2015 11:02:49 -0700 Message-Id: <1430848969-10842-1-git-send-email-brobecker@adacore.com> Hello, A follow-up on a discussion we had a while back: https://www.sourceware.org/ml/gdb-patches/2015-01/msg00050.html The "info dll", an alias of the "info sharedlibrary" command, is currently only defined in windows native versions. This patch makes it universally available by moving the alias declaration to solib.c, and adjusts the documentation accordingly. Making it universally available has two benefits: - Windows users moving to a Unix platforms are still able to use the same command for getting the list of shared libraries; - Unix to Windows cross debuggers now provide that command also. gdb/ChangeLog: * solib.c (_initialize_solib): Add "info dll" alias creation. * windows-nat.c (set_windows_aliases): Delete. (_initialize_windows_nat): Remove deprecated_init_ui_hook assignment. * NEWS: Add news entry about "info dll" now being available on all platforms. gdb/doc/ChangeLog: * gdb.texinfo (Files): Add "info dll" documentation. (Cygwin Native): Remove "info dll" documentation. Tested on x86_64-linux, no regression (obviously). I'll push the patch once documentation is reviewed. Note that I looked at getting rid of deprecated_init_ui_hook, but I found that insight might still be needing it :-( (to be confirmed, though, as my sources are fairly old). Thanks, diff --git a/gdb/NEWS b/gdb/NEWS index 651401d..0c7084a 100644 --- a/gdb/NEWS +++ b/gdb/NEWS @@ -23,6 +23,9 @@ present in the debug info. This typically includes the compiler version and may include things like its command line arguments. +* The "info dll", an alias of the "info sharedlibrary" command, + is now available on all platforms. + * Directory names supplied to the "set sysroot" commands may be prefixed with "target:" to tell GDB to access shared libraries from the target system, be it local or remote. This replaces the prefix diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index 9e2787d..19d8bb3 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -17854,6 +17854,10 @@ Print the names of the shared libraries which are currently loaded that match @var{regex}. If @var{regex} is omitted then print all shared libraries that are loaded. +@kindex info dll +@item info dll @var{regex} +This is an alias of @code{info sharedlibrary}. + @kindex sharedlibrary @kindex share @item sharedlibrary @var{regex} @@ -20701,10 +20705,6 @@ This command displays thread specific information stored in the Thread Information Block (readable on the X86 CPU family using @code{$fs} selector for 32-bit programs and @code{$gs} for 64-bit programs). -@kindex info dll -@item info dll -This is a Cygwin-specific alias of @code{info shared}. - @kindex set cygwin-exceptions @cindex debugging the Cygwin DLL @cindex Cygwin DLL, debugging diff --git a/gdb/solib.c b/gdb/solib.c index 358a0a2..0010c2f 100644 --- a/gdb/solib.c +++ b/gdb/solib.c @@ -1675,6 +1675,7 @@ _initialize_solib (void) _("Load shared object library symbols for files matching REGEXP.")); add_info ("sharedlibrary", info_sharedlibrary_command, _("Status of loaded shared object libraries.")); + add_info_alias ("dll", "sharedlibrary", 1); add_com ("nosharedlibrary", class_files, no_shared_libraries, _("Unload all shared object library symbols.")); diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c index be5d7e8..701d2c5 100644 --- a/gdb/windows-nat.c +++ b/gdb/windows-nat.c @@ -2502,12 +2502,6 @@ windows_target (void) return t; } -static void -set_windows_aliases (char *argv0) -{ - add_info_alias ("dll", "sharedlibrary", 1); -} - /* -Wmissing-prototypes */ extern initialize_file_ftype _initialize_windows_nat; @@ -2601,7 +2595,6 @@ Show whether to display kernel exceptions in child process."), NULL, add_cmd ("selector", class_info, display_selectors, _("Display selectors infos."), &info_w32_cmdlist); - deprecated_init_ui_hook = set_windows_aliases; } /* Hardware watchpoint support, adapted from go32-nat.c code. */