From patchwork Sat Mar 28 21:45:52 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Frysinger X-Patchwork-Id: 5876 Received: (qmail 63022 invoked by alias); 28 Mar 2015 21:55:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 63012 invoked by uid 89); 28 Mar 2015 21:55:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL, BAYES_00, SPF_PASS, T_RP_MATCHES_RCVD, UNSUBSCRIBE_BODY autolearn=no version=3.3.2 X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sat, 28 Mar 2015 21:55:08 +0000 Received: from localhost.localdomain (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 2AADE340B13 for ; Sat, 28 Mar 2015 21:45:56 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: [PATCH 5/5] sim: sh: convert to nrun Date: Sat, 28 Mar 2015 17:45:52 -0400 Message-Id: <1427579152-7275-5-git-send-email-vapier@gentoo.org> In-Reply-To: <1427579152-7275-1-git-send-email-vapier@gentoo.org> References: <1427579152-7275-1-git-send-email-vapier@gentoo.org> X-IsSubscribed: yes A lot of cpu state is stored in global variables, as is memory handling. The sim_size support needs unwinding at some point. But at least this is an improvement on the status quo. Committed. --- sim/sh/ChangeLog | 23 +++++ sim/sh/Makefile.in | 15 +-- sim/sh/interp.c | 278 ++++++++++++++--------------------------------------- sim/sh/sim-main.h | 154 +++++++++++++++++++++++++++++ sim/sh/tconfig.h | 17 ---- 5 files changed, 260 insertions(+), 227 deletions(-) create mode 100644 sim/sh/sim-main.h delete mode 100644 sim/sh/tconfig.h diff --git a/sim/sh/ChangeLog b/sim/sh/ChangeLog index 0ee6dac..8a37e4c 100644 --- a/sim/sh/ChangeLog +++ b/sim/sh/ChangeLog @@ -1,5 +1,28 @@ 2015-03-28 Mike Frysinger + * Makefile.in (SIM_RUN_OBJS, SIM_EXTRA_CFLAGS): Delete. + (SIM_OBJS): Change to $(SIM_NEW_COMMON_OBJS). + * interp.c: Delete run-sim.h include. Include sim-main.h, sim-base.h, + and sim-options.h. + (SEXT, SEXT32): Undefine. + (sim_write): Delete prototype. + (regstacktype, saved_state_type): Move to sim-main.h. + (target_little_endian): Replace with CURRENT_TARGET_BYTE_ORDER. + (host_little_endian): Replace with CURRENT_HOST_BYTE_ORDER. + (sim_kind, myname, tracing, sim_stop, sim_trace, sim_set_profile, + sim_set_profile_size, sim_load, sim_set_callbacks, + sim_complete_command): Delete. + (sim_size): Mark static. + (init_pointers): Delete host_little_endian setup. + (sim_resume): Delete tracing check. + (free_state): New cleanup function. + (sim_open): Rewrite to use new common logic. + (sim_create_inferior): Call init_dsp. + * sim-main.h: New file. + * tconfig.h: Delete file. + +2015-03-28 Mike Frysinger + * gencode.c (ppi_gensim): Convert old style prototype with ppi_insn. * interp.c: Include ctype.h and run-sim.h. [HAVE_TIME_H]: Include time.h diff --git a/sim/sh/Makefile.in b/sim/sh/Makefile.in index 0594a6e..ecfb287 100644 --- a/sim/sh/Makefile.in +++ b/sim/sh/Makefile.in @@ -1,7 +1,7 @@ # Makefile template for Configure for the SH sim library. # Copyright (C) 1990-2015 Free Software Foundation, Inc. # Written by Cygnus Support. -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 3 of the License, or @@ -17,11 +17,14 @@ ## COMMON_PRE_CONFIG_FRAG -# Use the deprecated run frontend until we migrate to nrun.o -SIM_RUN_OBJS = run.o -SIM_EXTRA_CFLAGS = -DSIM_USE_DEPRECATED_RUN_FRONTEND - -SIM_OBJS = interp.o table.o sim-load.o +SIM_OBJS = \ + interp.o \ + $(SIM_NEW_COMMON_OBJS) \ + sim-cpu.o \ + sim-engine.o \ + sim-hload.o \ + sim-stop.o \ + table.o SIM_EXTRA_LIBS = -lm SIM_EXTRA_CLEAN = sh-clean diff --git a/sim/sh/interp.c b/sim/sh/interp.c index adf05ee..13f6e65 100644 --- a/sim/sh/interp.c +++ b/sim/sh/interp.c @@ -67,7 +67,10 @@ #include "gdb/callback.h" #include "gdb/remote-sim.h" #include "gdb/sim-sh.h" -#include "run-sim.h" + +#include "sim-main.h" +#include "sim-base.h" +#include "sim-options.h" /* This file is local - if newlib changes, then so should this. */ #include "syscall.h" @@ -91,9 +94,11 @@ #define SIGTRAP 5 #endif -extern unsigned short sh_jump_table[], sh_dsp_table[0x1000], ppi_table[]; +/* TODO: Stop using these names. */ +#undef SEXT +#undef SEXT32 -int sim_write (SIM_DESC sd, SIM_ADDR addr, const unsigned char *buffer, int size); +extern unsigned short sh_jump_table[], sh_dsp_table[0x1000], ppi_table[]; #define O_RECOMPILE 85 #define DEFINE_TABLE @@ -103,108 +108,7 @@ int sim_write (SIM_DESC sd, SIM_ADDR addr, const unsigned char *buffer, int size for a quit. */ #define POLL_QUIT_INTERVAL 0x60000 -typedef struct -{ - int regs[20]; -} regstacktype; - -typedef union -{ - - struct - { - int regs[16]; - int pc; - - /* System registers. For sh-dsp this also includes A0 / X0 / X1 / Y0 / Y1 - which are located in fregs, i.e. strictly speaking, these are - out-of-bounds accesses of sregs.i . This wart of the code could be - fixed by making fregs part of sregs, and including pc too - to avoid - alignment repercussions - but this would cause very onerous union / - structure nesting, which would only be managable with anonymous - unions and structs. */ - union - { - struct - { - int mach; - int macl; - int pr; - int dummy3, dummy4; - int fpul; /* A1 for sh-dsp - but only for movs etc. */ - int fpscr; /* dsr for sh-dsp */ - } named; - int i[7]; - } sregs; - - /* sh3e / sh-dsp */ - union fregs_u - { - float f[16]; - double d[8]; - int i[16]; - } - fregs[2]; - - /* Control registers; on the SH4, ldc / stc is privileged, except when - accessing gbr. */ - union - { - struct - { - int sr; - int gbr; - int vbr; - int ssr; - int spc; - int mod; - /* sh-dsp */ - int rs; - int re; - /* sh3 */ - int bank[8]; - int dbr; /* debug base register */ - int sgr; /* saved gr15 */ - int ldst; /* load/store flag (boolean) */ - int tbr; - int ibcr; /* sh2a bank control register */ - int ibnr; /* sh2a bank number register */ - } named; - int i[16]; - } cregs; - - unsigned char *insn_end; - - int ticks; - int stalls; - int memstalls; - int cycles; - int insts; - - int prevlock; - int thislock; - int exception; - - int end_of_registers; - - int msize; -#define PROFILE_FREQ 1 -#define PROFILE_SHIFT 2 - int profile; - unsigned short *profile_hist; - unsigned char *memory; - int xyram_select, xram_start, yram_start; - unsigned char *xmem; - unsigned char *ymem; - unsigned char *xmem_offset; - unsigned char *ymem_offset; - unsigned long bfd_mach; - regstacktype *regstack; - } - asregs; - int asints[40]; -} saved_state_type; - +/* TODO: Move into sim_cpu. */ saved_state_type saved_state; struct loop_bounds { unsigned char *start, *end; }; @@ -212,20 +116,15 @@ struct loop_bounds { unsigned char *start, *end; }; /* These variables are at file scope so that functions other than sim_resume can use the fetch/store macros */ -static int target_little_endian; +#define target_little_endian (CURRENT_TARGET_BYTE_ORDER == LITTLE_ENDIAN) static int global_endianw, endianb; static int target_dsp; -static int host_little_endian; +#define host_little_endian (CURRENT_HOST_BYTE_ORDER == LITTLE_ENDIAN) static char **prog_argv; static int maskw = 0; static int maskl = 0; -static SIM_OPEN_KIND sim_kind; -static char *myname; -static int tracing = 0; - - /* Short hand definitions of the registers */ #define SBIT(x) ((x)&sbit) @@ -1687,7 +1586,7 @@ mcalloc (size_t nmemb, size_t size) /* Set the memory size to the power of two provided. */ -void +static void sim_size (int power) { sim_memory_size = power; @@ -1809,10 +1708,6 @@ init_dsp (struct bfd *abfd) static void init_pointers (void) { - host_little_endian = 0; - * (char*) &host_little_endian = 1; - host_little_endian &= 1; - if (saved_state.asregs.msize != 1 << sim_memory_size) { sim_size (sim_memory_size); @@ -1869,13 +1764,6 @@ gotcall (int from, int to) #define MMASKB ((saved_state.asregs.msize -1) & ~0) -int -sim_stop (SIM_DESC sd) -{ - raise_exception (SIGINT); - return 1; -} - void sim_resume (SIM_DESC sd, int step, int siggnal) { @@ -1968,9 +1856,6 @@ sim_resume (SIM_DESC sd, int step, int siggnal) insts++; #endif top: - if (tracing) - fprintf (stderr, "PC: %08lx, insn: %04x\n", - (unsigned long) PH2T (insn_ptr), iword); #include "code.c" @@ -2436,15 +2321,6 @@ sim_fetch_register (SIM_DESC sd, int rn, unsigned char *memory, int length) return length; } -int -sim_trace (SIM_DESC sd) -{ - tracing = 1; - sim_resume (sd, 0, 0); - tracing = 0; - return 1; -} - void sim_stop_reason (SIM_DESC sd, enum sim_stop *reason, int *sigrc) { @@ -2497,23 +2373,19 @@ sim_info (SIM_DESC sd, int verbose) } } -void -sim_set_profile (int n) -{ - saved_state.asregs.profile = n; -} - -void -sim_set_profile_size (int n) +static void +free_state (SIM_DESC sd) { - sim_profile_size = n; + if (STATE_MODULES (sd) != NULL) + sim_module_uninstall (sd); + sim_cpu_free_all (sd); + sim_state_free (sd); } SIM_DESC sim_open (SIM_OPEN_KIND kind, host_callback *cb, struct bfd *abfd, char **argv) { char **p; - int endian_set = 0; int i; union { @@ -2523,32 +2395,65 @@ sim_open (SIM_OPEN_KIND kind, host_callback *cb, struct bfd *abfd, char **argv) } mem_word; - sim_kind = kind; - myname = argv[0]; + SIM_DESC sd = sim_state_alloc (kind, cb); + SIM_ASSERT (STATE_MAGIC (sd) == SIM_MAGIC_NUMBER); + callback = cb; + /* The cpu data is kept in a separately allocated chunk of memory. */ + if (sim_cpu_alloc_all (sd, 1, /*cgen_cpu_max_extra_bytes ()*/0) != SIM_RC_OK) + { + free_state (sd); + return 0; + } + + if (sim_pre_argv_init (sd, argv[0]) != SIM_RC_OK) + { + free_state (sd); + return 0; + } + + /* getopt will print the error message so we just have to exit if this fails. + FIXME: Hmmm... in the case of gdb we need getopt to call + print_filtered. */ + if (sim_parse_args (sd, argv) != SIM_RC_OK) + { + free_state (sd); + return 0; + } + + /* Check for/establish the a reference program image. */ + if (sim_analyze_program (sd, + (STATE_PROG_ARGV (sd) != NULL + ? *STATE_PROG_ARGV (sd) + : NULL), abfd) != SIM_RC_OK) + { + free_state (sd); + return 0; + } + + /* Configure/verify the target byte order and other runtime + configuration options. */ + if (sim_config (sd) != SIM_RC_OK) + { + sim_module_uninstall (sd); + return 0; + } + + if (sim_post_argv_init (sd) != SIM_RC_OK) + { + /* Uninstall the modules to avoid memory leaks, + file descriptor leaks, etc. */ + sim_module_uninstall (sd); + return 0; + } + for (p = argv + 1; *p != NULL; ++p) { - if (strcmp (*p, "-E") == 0) - { - ++p; - if (*p == NULL) - { - /* FIXME: This doesn't use stderr, but then the rest of the - file doesn't either. */ - callback->printf_filtered (callback, "Missing argument to `-E'.\n"); - return 0; - } - target_little_endian = strcmp (*p, "big") != 0; - endian_set = 1; - } - else if (isdigit (**p)) + if (isdigit (**p)) parse_and_set_memory_size (*p); } - if (abfd != NULL && ! endian_set) - target_little_endian = ! bfd_big_endian (abfd); - if (abfd) init_dsp (abfd); @@ -2560,8 +2465,7 @@ sim_open (SIM_OPEN_KIND kind, host_callback *cb, struct bfd *abfd, char **argv) mem_word.c[i] = i; endianb = mem_word.i >> (target_little_endian ? 0 : 24) & 0xff; - /* fudge our descriptor for now */ - return (SIM_DESC) 1; + return sd; } static void @@ -2583,31 +2487,6 @@ sim_close (SIM_DESC sd, int quitting) } SIM_RC -sim_load (SIM_DESC sd, const char *prog, bfd *abfd, int from_tty) -{ - extern bfd *sim_load_file (); /* ??? Don't know where this should live. */ - bfd *prog_bfd; - - prog_bfd = sim_load_file (sd, myname, callback, prog, abfd, - sim_kind == SIM_OPEN_DEBUG, - 0, sim_write); - - /* Set the bfd machine type. */ - if (prog_bfd) - saved_state.asregs.bfd_mach = bfd_get_mach (prog_bfd); - else if (abfd) - saved_state.asregs.bfd_mach = bfd_get_mach (abfd); - else - saved_state.asregs.bfd_mach = 0; - - if (prog_bfd == NULL) - return SIM_RC_FAIL; - if (abfd == NULL) - bfd_close (prog_bfd); - return SIM_RC_OK; -} - -SIM_RC sim_create_inferior (SIM_DESC sd, struct bfd *prog_bfd, char **argv, char **env) { /* Clear the registers. */ @@ -2622,6 +2501,9 @@ sim_create_inferior (SIM_DESC sd, struct bfd *prog_bfd, char **argv, char **env) if (prog_bfd != NULL) saved_state.asregs.bfd_mach = bfd_get_mach (prog_bfd); + if (prog_bfd != NULL) + init_dsp (prog_bfd); + /* Record the program's arguments. */ prog_argv = argv; @@ -2657,15 +2539,3 @@ sim_do_command (SIM_DESC sd, const char *cmd) (callback->printf_filtered) (callback, "Error: \"%s\" is not a valid SH simulator command.\n", cmd); } } - -void -sim_set_callbacks (host_callback *p) -{ - callback = p; -} - -char ** -sim_complete_command (SIM_DESC sd, const char *text, const char *word) -{ - return NULL; -} diff --git a/sim/sh/sim-main.h b/sim/sh/sim-main.h new file mode 100644 index 0000000..e15a26a --- /dev/null +++ b/sim/sh/sim-main.h @@ -0,0 +1,154 @@ +/* Moxie Simulator definition. + Copyright (C) 2009-2015 Free Software Foundation, Inc. + +This file is part of GDB, the GNU debugger. + +This program is free software; you can redistribute it and/or modify +it under the terms of the GNU General Public License as published by +the Free Software Foundation; either version 3 of the License, or +(at your option) any later version. + +This program is distributed in the hope that it will be useful, +but WITHOUT ANY WARRANTY; without even the implied warranty of +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +GNU General Public License for more details. + +You should have received a copy of the GNU General Public License +along with this program. If not, see . */ + +#ifndef SIM_MAIN_H +#define SIM_MAIN_H + +#include "sim-basics.h" + +typedef address_word sim_cia; + +#define CIA_GET(cpu) saved_state.asregs.pc +#define CIA_SET(cpu,val) saved_state.asregs.pc = (val) + +typedef struct _sim_cpu SIM_CPU; + +#include "sim-base.h" + +typedef struct +{ + int regs[20]; +} regstacktype; + +typedef union +{ + + struct + { + int regs[16]; + int pc; + + /* System registers. For sh-dsp this also includes A0 / X0 / X1 / Y0 / Y1 + which are located in fregs, i.e. strictly speaking, these are + out-of-bounds accesses of sregs.i . This wart of the code could be + fixed by making fregs part of sregs, and including pc too - to avoid + alignment repercussions - but this would cause very onerous union / + structure nesting, which would only be managable with anonymous + unions and structs. */ + union + { + struct + { + int mach; + int macl; + int pr; + int dummy3, dummy4; + int fpul; /* A1 for sh-dsp - but only for movs etc. */ + int fpscr; /* dsr for sh-dsp */ + } named; + int i[7]; + } sregs; + + /* sh3e / sh-dsp */ + union fregs_u + { + float f[16]; + double d[8]; + int i[16]; + } + fregs[2]; + + /* Control registers; on the SH4, ldc / stc is privileged, except when + accessing gbr. */ + union + { + struct + { + int sr; + int gbr; + int vbr; + int ssr; + int spc; + int mod; + /* sh-dsp */ + int rs; + int re; + /* sh3 */ + int bank[8]; + int dbr; /* debug base register */ + int sgr; /* saved gr15 */ + int ldst; /* load/store flag (boolean) */ + int tbr; + int ibcr; /* sh2a bank control register */ + int ibnr; /* sh2a bank number register */ + } named; + int i[16]; + } cregs; + + unsigned char *insn_end; + + int ticks; + int stalls; + int memstalls; + int cycles; + int insts; + + int prevlock; + int thislock; + int exception; + + int end_of_registers; + + int msize; +#define PROFILE_FREQ 1 +#define PROFILE_SHIFT 2 + int profile; + unsigned short *profile_hist; + unsigned char *memory; + int xyram_select, xram_start, yram_start; + unsigned char *xmem; + unsigned char *ymem; + unsigned char *xmem_offset; + unsigned char *ymem_offset; + unsigned long bfd_mach; + regstacktype *regstack; + } asregs; + int asints[40]; +} saved_state_type; + +/* TODO: Move into sim_cpu. */ +extern saved_state_type saved_state; + +struct _sim_cpu { + + sim_cpu_base base; +}; + +struct sim_state { + + sim_cpu *cpu[MAX_NR_PROCESSORS]; +#if (WITH_SMP) +#define STATE_CPU(sd,n) ((sd)->cpu[n]) +#else +#define STATE_CPU(sd,n) ((sd)->cpu[0]) +#endif + + sim_state_base base; +}; + +#endif diff --git a/sim/sh/tconfig.h b/sim/sh/tconfig.h deleted file mode 100644 index c5ec4fa..0000000 --- a/sim/sh/tconfig.h +++ /dev/null @@ -1,17 +0,0 @@ -/* sh target config file */ - -/* Define this if the simulator supports profiling. - See the mips simulator for an example. - This enables the `-p foo' and `-s bar' options. - The target is required to provide sim_set_profile{,_size}. */ -/* #define SIM_HAVE_PROFILE */ - -/* Define this if the simulator uses an instruction cache. - See the h8/300 simulator for an example. - This enables the `-c size' option to set the size of the cache. - The target is required to provide sim_set_simcache_size. */ -/* #define SIM_HAVE_SIMCACHE */ - -/* Define this if the target cpu is bi-endian - and the simulator supports it. */ -#define SIM_HAVE_BIENDIAN