From patchwork Tue Mar 17 21:02:43 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Gaisler X-Patchwork-Id: 5667 Received: (qmail 40260 invoked by alias); 17 Mar 2015 21:03:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 39932 invoked by uid 89); 17 Mar 2015 21:03:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: bin-vsp-out-03.atm.binero.net Received: from vsp-unauthed01.binero.net (HELO bin-vsp-out-03.atm.binero.net) (195.74.38.225) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 17 Mar 2015 21:03:06 +0000 X-Halon-ID: fe413309-cce8-11e4-9958-0050569116f7 Authorized-sender: jiri@gaisler.se Received: from localhost.localdomain (unknown [46.246.62.93]) by bin-vsp-out-03.atm.binero.net (Halon Mail Gateway) with ESMTPSA; Tue, 17 Mar 2015 22:02:59 +0100 (CET) From: Jiri Gaisler To: gdb-patches@sourceware.org Cc: Jiri Gaisler Subject: [PATCH v4 06/13] sim/erc32: Use gdb callback for UART I/O when linked with gdb. Date: Tue, 17 Mar 2015 22:02:43 +0100 Message-Id: <1426626170-21401-7-git-send-email-jiri@gaisler.se> In-Reply-To: <1426626170-21401-1-git-send-email-jiri@gaisler.se> References: <1426626170-21401-1-git-send-email-jiri@gaisler.se> X-IsSubscribed: yes Use the host_callback feature for printing when linked with gdb. --- sim/erc32/erc32.c | 98 +++++++++++++++++++++++++++++++++++++++++++++--------- sim/erc32/func.c | 4 +++ sim/erc32/interf.c | 5 +-- sim/erc32/sis.c | 2 ++ sim/erc32/sis.h | 4 +++ 5 files changed, 95 insertions(+), 18 deletions(-) diff --git a/sim/erc32/erc32.c b/sim/erc32/erc32.c index c6d67ac..43f0644 100644 --- a/sim/erc32/erc32.c +++ b/sim/erc32/erc32.c @@ -22,6 +22,7 @@ /* The control space devices */ #include "config.h" +#include #include #include #include @@ -38,7 +39,7 @@ extern int32 sparclite, sparclite_board; extern int rom8,wrp,uben; extern char uart_dev1[], uart_dev2[]; -int dumbio = 0; /* normal, smart, terminal oriented IO by default */ +static int tty_setup = 1; /* default setup if not a tty */ /* MEC registers */ #define MEC_START 0x01f80000 @@ -301,12 +302,15 @@ static void store_bytes (unsigned char *mem, uint32 waddr, extern int ext_irl; +static host_callback *callback; + /* One-time init */ void init_sim() { + callback = sim_callback; port_init(); } @@ -944,10 +948,14 @@ init_stdio() { if (dumbio) return; /* do nothing */ - if (!ifd1) + if (ifd1 == 0 && f1open) { tcsetattr(0, TCSANOW, &ioc1); - if (!ifd2) + tcflush(ifd1, TCIFLUSH); + } + if (ifd2 == 0 && f1open) { tcsetattr(0, TCSANOW, &ioc2); + tcflush(ifd2, TCIFLUSH); + } } void @@ -955,16 +963,18 @@ restore_stdio() { if (dumbio) return; /* do nothing */ - if (!ifd1) + if (ifd1 == 0 && f1open && tty_setup) tcsetattr(0, TCSANOW, &iocold1); - if (!ifd2) + if (ifd2 == 0 && f2open && tty_setup) tcsetattr(0, TCSANOW, &iocold2); } #define DO_STDIO_READ( _fd_, _buf_, _len_ ) \ - ( dumbio \ + ( dumbio || nouartrx \ ? (0) /* no bytes read, no delay */ \ - : read( _fd_, _buf_, _len_ ) ) + : (_fd_) == 1 && callback ? \ + callback->read_stdin (callback, _buf_, _len_) : \ + read( _fd_, _buf_, _len_ ) ) static void @@ -994,21 +1004,26 @@ port_init() } if (f1in) ifd1 = fileno(f1in); if (ifd1 == 0) { + if (callback && !callback->isatty(callback, ifd1)) { + tty_setup = 0; + } if (sis_verbose) printf("serial port A on stdin/stdout\n"); if (!dumbio) { tcgetattr(ifd1, &ioc1); + if (tty_setup) { iocold1 = ioc1; ioc1.c_lflag &= ~(ICANON | ECHO); ioc1.c_cc[VMIN] = 0; ioc1.c_cc[VTIME] = 0; } + } f1open = 1; } if (f1out) { ofd1 = fileno(f1out); - if (!dumbio && ofd1 == 1) setbuf(f1out, NULL); + if (!dumbio && tty_setup && ofd1 == 1) setbuf(f1out, NULL); } if (uart_dev2[0] != 0) @@ -1027,17 +1042,19 @@ port_init() printf("serial port B on stdin/stdout\n"); if (!dumbio) { tcgetattr(ifd2, &ioc2); + if (tty_setup) { iocold2 = ioc2; ioc2.c_lflag &= ~(ICANON | ECHO); ioc2.c_cc[VMIN] = 0; ioc2.c_cc[VTIME] = 0; } + } f2open = 1; } if (f2out) { ofd2 = fileno(f2out); - if (!dumbio && ofd2 == 1) setbuf(f2out, NULL); + if (!dumbio && tty_setup && ofd2 == 1) setbuf(f2out, NULL); } wnuma = wnumb = 0; @@ -1066,6 +1083,9 @@ read_uart(addr) if (f1open) { anum = DO_STDIO_READ(ifd1, aq, UARTBUF); } + else { + anum = 0; + } if (anum > 0) { aind = 0; if ((aind + 1) < anum) @@ -1098,6 +1118,9 @@ read_uart(addr) if (f2open) { bnum = DO_STDIO_READ(ifd2, bq, UARTBUF); } + else { + bnum = 0; + } if (bnum > 0) { bind = 0; if ((bind + 1) < bnum) @@ -1130,6 +1153,9 @@ read_uart(addr) if (f1open) { anum = DO_STDIO_READ(ifd1, aq, UARTBUF); } + else { + anum = 0; + } if (anum > 0) { Ucontrol |= 0x00000001; aind = 0; @@ -1142,6 +1168,9 @@ read_uart(addr) if (f2open) { bnum = DO_STDIO_READ(ifd2, bq, UARTBUF); } + else { + bnum = 0; + } if (bnum > 0) { Ucontrol |= 0x00010000; bind = 0; @@ -1182,8 +1211,12 @@ write_uart(addr, data) if (wnuma < UARTBUF) wbufa[wnuma++] = c; else { - while (wnuma) + while (wnuma) { + if (ofd1 == 1 && callback) + wnuma -= callback->write_stdout(callback, wbufa, wnuma); + else wnuma -= fwrite(wbufa, 1, wnuma, f1out); + } wbufa[wnuma++] = c; } } @@ -1206,8 +1239,12 @@ write_uart(addr, data) if (wnumb < UARTBUF) wbufb[wnumb++] = c; else { - while (wnumb) + while (wnumb) { + if (ofd1 == 1 && callback) + wnumb -= callback->write_stdout(callback, wbufb, wnumb); + else wnumb -= fwrite(wbufb, 1, wnumb, f2out); + } wbufb[wnumb++] = c; } } @@ -1245,19 +1282,37 @@ write_uart(addr, data) static void flush_uart() { - while (wnuma && f1open) + while (wnuma && f1open) { + if (ofd1 == 1 && callback) { + wnuma -= callback->write_stdout(callback, wbufa, wnuma); + callback->flush_stdout(callback); + } + else wnuma -= fwrite(wbufa, 1, wnuma, f1out); - while (wnumb && f2open) + } + while (wnumb && f2open) { + if (ofd2 == 1 && callback) { + wnuma -= callback->write_stdout(callback, wbufb, wnuma); + callback->flush_stdout(callback); + } + else wnumb -= fwrite(wbufb, 1, wnumb, f2out); } +} static void uarta_tx() { - - while (f1open && fwrite(&uarta_sreg, 1, 1, f1out) != 1); + while (f1open) { + if (ofd1 == 1 && callback) { + while (callback->write_stdout(callback, &uarta_sreg, 1) != 1); + } + else { + while (fwrite(&uarta_sreg, 1, 1, f1out) != 1); + } + } if (uart_stat_reg & UARTA_HRE) { uart_stat_reg |= UARTA_SRE; } else { @@ -1271,7 +1326,14 @@ uarta_tx() static void uartb_tx() { - while (f2open && fwrite(&uartb_sreg, 1, 1, f2out) != 1); + while (f2open) { + if (ofd2 == 1 && callback) { + while (callback->write_stdout(callback, &uarta_sreg, 1) != 1); + } + else { + while (fwrite(&uartb_sreg, 1, 1, f2out) != 1); + } + } if (uart_stat_reg & UARTB_HRE) { uart_stat_reg |= UARTB_SRE; } else { @@ -1293,6 +1355,8 @@ uart_rx(arg) rsize = 0; if (f1open) rsize = DO_STDIO_READ(ifd1, &rxd, 1); + else + rsize = 0; if (rsize > 0) { uarta_data = UART_DR | rxd; if (uart_stat_reg & UARTA_HRE) @@ -1309,6 +1373,8 @@ uart_rx(arg) rsize = 0; if (f2open) rsize = DO_STDIO_READ(ifd2, &rxd, 1); + else + rsize = 0; if (rsize) { uartb_data = UART_DR | rxd; if (uart_stat_reg & UARTB_HRE) diff --git a/sim/erc32/func.c b/sim/erc32/func.c index 0dcdf93..1cb156d 100644 --- a/sim/erc32/func.c +++ b/sim/erc32/func.c @@ -34,6 +34,8 @@ #define VAL(x) strtoul(x,(char **)NULL,0) extern int current_target_byte_order; +int dumbio = 0; /* normal, smart, terminal oriented IO by default */ + struct disassemble_info dinfo; struct pstate sregs; extern struct estate ebase; @@ -52,6 +54,8 @@ char uart_dev1[128] = ""; char uart_dev2[128] = ""; extern int ext_irl; uint32 last_load_addr = 0; +int nouartrx = 0; +host_callback *sim_callback; #ifdef ERRINJ uint32 errcnt = 0; diff --git a/sim/erc32/interf.c b/sim/erc32/interf.c index 098b9ce..1686cc3 100644 --- a/sim/erc32/interf.c +++ b/sim/erc32/interf.c @@ -62,8 +62,6 @@ extern char uart_dev1[], uart_dev2[]; int sis_gdb_break = 1; -host_callback *sim_callback; - int run_sim(sregs, icount, dis) struct pstate *sregs; @@ -211,6 +209,9 @@ sim_open (kind, callback, abfd, argv) if (strcmp(argv[stat], "-dumbio") == 0) { dumbio = 1; } else + if (strcmp(argv[stat], "-nouartrx") == 0) { + nouartrx = 1; + } else if (strcmp(argv[stat], "-wrp") == 0) { wrp = 1; } else diff --git a/sim/erc32/sis.c b/sim/erc32/sis.c index b066a56..2623fc5 100644 --- a/sim/erc32/sis.c +++ b/sim/erc32/sis.c @@ -202,6 +202,8 @@ main(argc, argv) #endif } else if (strcmp(argv[stat], "-dumbio") == 0) { dumbio = 1; + } else if (strcmp(argv[stat], "-nouartrx") == 0) { + nouartrx = 1; } else if (strcmp(argv[stat], "-v") == 0) { sis_verbose += 1; } else { diff --git a/sim/erc32/sis.h b/sim/erc32/sis.h index ae39ad1..45a0cc6 100644 --- a/sim/erc32/sis.h +++ b/sim/erc32/sis.h @@ -204,6 +204,10 @@ extern void sys_reset (void); extern void sys_halt (void); extern int bfd_load (const char *fname); extern double get_time (void); +extern int nouartrx; +extern host_callback *sim_callback; +extern int dumbio; + /* exec.c */ extern int dispatch_instruction (struct pstate *sregs);