diff mbox

testsuite: Don't set SYMBOL_PREFIX for x86_64-*-cygwin

Message ID 1425646888-4332-1-git-send-email-jon.turney@dronecode.org.uk
State New
Headers show

Commit Message

Jon TURNEY March 6, 2015, 1:01 p.m. UTC
Exactly like x86_64-*-mingw, SYMBOL_PREFIX should not be set to "_" for
x86_64-*-cygwin

I'm not sure that testsuite results on x86_64-*-cygwin tell you a great deal,
but for the record:

-# of expected passes           20510
-# of unexpected failures       649
+# of expected passes           21456
+# of unexpected failures       729
 # of unexpected successes      2
 # of expected failures         42
-# of known failures            50
-# of untested testcases                90
-# of unresolved testcases      9
-# of unsupported tests         114
+# of known failures            52
+# of untested testcases                80
+# of unresolved testcases      184
+# of unsupported tests         118

ChangeLog/gdb/testuite:

2015-03-04  Jon TURNEY  <jon.turney@dronecode.org.uk>

	* lib/gdb.exp (gdb_target_symbol_prefix_flags): Don't set
	SYMBOL_PREFIX for x86_64-*-cygwin.

Signed-off-by: Jon TURNEY <jon.turney@dronecode.org.uk>
---
 gdb/testsuite/lib/gdb.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Pedro Alves March 18, 2015, 11:34 p.m. UTC | #1
On 03/06/2015 01:01 PM, Jon TURNEY wrote:
> Exactly like x86_64-*-mingw, SYMBOL_PREFIX should not be set to "_" for
> x86_64-*-cygwin
> 
> I'm not sure that testsuite results on x86_64-*-cygwin tell you a great deal,
> but for the record:
> 
> -# of expected passes           20510
> -# of unexpected failures       649
> +# of expected passes           21456
> +# of unexpected failures       729
>  # of unexpected successes      2
>  # of expected failures         42
> -# of known failures            50
> -# of untested testcases                90
> -# of unresolved testcases      9
> -# of unsupported tests         114
> +# of known failures            52
> +# of untested testcases                80
> +# of unresolved testcases      184
> +# of unsupported tests         118
> 
> ChangeLog/gdb/testuite:
> 
> 2015-03-04  Jon TURNEY  <jon.turney@dronecode.org.uk>
> 
> 	* lib/gdb.exp (gdb_target_symbol_prefix_flags): Don't set
> 	SYMBOL_PREFIX for x86_64-*-cygwin.

OK.

Thanks,
Pedro Alves
Jon TURNEY March 20, 2015, 4:06 p.m. UTC | #2
On 18/03/2015 23:34, Pedro Alves wrote:
> On 03/06/2015 01:01 PM, Jon TURNEY wrote:
>> Exactly like x86_64-*-mingw, SYMBOL_PREFIX should not be set to "_" for
>> x86_64-*-cygwin
[...]
>> 2015-03-04  Jon TURNEY  <jon.turney@dronecode.org.uk>
>>
>> 	* lib/gdb.exp (gdb_target_symbol_prefix_flags): Don't set
>> 	SYMBOL_PREFIX for x86_64-*-cygwin.
>
> OK.

I do not have write access, so can you apply this, please.
Pedro Alves March 20, 2015, 5:23 p.m. UTC | #3
On 03/20/2015 04:06 PM, Jon TURNEY wrote:
> On 18/03/2015 23:34, Pedro Alves wrote:
>> On 03/06/2015 01:01 PM, Jon TURNEY wrote:
>>> Exactly like x86_64-*-mingw, SYMBOL_PREFIX should not be set to "_" for
>>> x86_64-*-cygwin
> [...]
>>> 2015-03-04  Jon TURNEY  <jon.turney@dronecode.org.uk>
>>>
>>> 	* lib/gdb.exp (gdb_target_symbol_prefix_flags): Don't set
>>> 	SYMBOL_PREFIX for x86_64-*-cygwin.
>>
>> OK.
> 
> I do not have write access, so can you apply this, please.

Are you planning on working on GDB further?  (That'd be
awesome, btw.)  We can get you write access so you can
push your own patches.  Let me know if you'd like that.

Thanks,
Pedro Alves
Jon TURNEY March 23, 2015, 2:39 p.m. UTC | #4
On 20/03/2015 17:23, Pedro Alves wrote:
> On 03/20/2015 04:06 PM, Jon TURNEY wrote:
>> On 18/03/2015 23:34, Pedro Alves wrote:
>>> On 03/06/2015 01:01 PM, Jon TURNEY wrote:
>>>> Exactly like x86_64-*-mingw, SYMBOL_PREFIX should not be set to "_" for
>>>> x86_64-*-cygwin
>> [...]
>>>> 2015-03-04  Jon TURNEY  <jon.turney@dronecode.org.uk>
>>>>
>>>> 	* lib/gdb.exp (gdb_target_symbol_prefix_flags): Don't set
>>>> 	SYMBOL_PREFIX for x86_64-*-cygwin.
>>>
>>> OK.
>>
>> I do not have write access, so can you apply this, please.
>
> Are you planning on working on GDB further?  (That'd be
> awesome, btw.)  We can get you write access so you can
> push your own patches.  Let me know if you'd like that.

Yes, please.

I already have a sourceware account, 'jturney'.
Jon TURNEY March 25, 2015, 5:51 p.m. UTC | #5
On 23/03/2015 14:39, Jon TURNEY wrote:
> On 20/03/2015 17:23, Pedro Alves wrote:
>> On 03/20/2015 04:06 PM, Jon TURNEY wrote:
>>> On 18/03/2015 23:34, Pedro Alves wrote:
>>>> On 03/06/2015 01:01 PM, Jon TURNEY wrote:
>>>>> Exactly like x86_64-*-mingw, SYMBOL_PREFIX should not be set to "_"
>>>>> for
>>>>> x86_64-*-cygwin
>>> [...]
>>>>> 2015-03-04  Jon TURNEY  <jon.turney@dronecode.org.uk>
>>>>>
>>>>>     * lib/gdb.exp (gdb_target_symbol_prefix_flags): Don't set
>>>>>     SYMBOL_PREFIX for x86_64-*-cygwin.
>>>>
>>>> OK.
>>>
>>> I do not have write access, so can you apply this, please.
>>
>> Are you planning on working on GDB further?  (That'd be
>> awesome, btw.)  We can get you write access so you can
>> push your own patches.  Let me know if you'd like that.
>
> Yes, please.

So it seems I do have write access, although I didn't know this :-)

Can I go ahead and commit this?
Pedro Alves March 26, 2015, 9:28 a.m. UTC | #6
On 03/25/2015 05:51 PM, Jon TURNEY wrote:
> On 23/03/2015 14:39, Jon TURNEY wrote:
>> On 20/03/2015 17:23, Pedro Alves wrote:
>>> On 03/20/2015 04:06 PM, Jon TURNEY wrote:
>>>> On 18/03/2015 23:34, Pedro Alves wrote:
>>>>> On 03/06/2015 01:01 PM, Jon TURNEY wrote:
>>>>>> Exactly like x86_64-*-mingw, SYMBOL_PREFIX should not be set to "_"
>>>>>> for
>>>>>> x86_64-*-cygwin
>>>> [...]
>>>>>> 2015-03-04  Jon TURNEY  <jon.turney@dronecode.org.uk>
>>>>>>
>>>>>>     * lib/gdb.exp (gdb_target_symbol_prefix_flags): Don't set
>>>>>>     SYMBOL_PREFIX for x86_64-*-cygwin.
>>>>>
>>>>> OK.
>>>>
>>>> I do not have write access, so can you apply this, please.
>>>
>>> Are you planning on working on GDB further?  (That'd be
>>> awesome, btw.)  We can get you write access so you can
>>> push your own patches.  Let me know if you'd like that.
>>
>> Yes, please.
> 
> So it seems I do have write access, although I didn't know this :-)
> 

:-)

> Can I go ahead and commit this?

Yes.

Please add yourself to write-after-approval section of
the gdb/MAINTAINERS file.  No need for approval for that
one.  Just post the patch/commit to the list for the archives.

Thanks,
Pedro Alves
diff mbox

Patch

diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index f274b64..0041adf 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -4998,7 +4998,7 @@  proc core_find {binfile {deletefiles {}} {arg ""}} {
 # TODO: find out automatically if the target needs this.
 
 proc gdb_target_symbol_prefix_flags {} {
-    if { [istarget "*-*-cygwin*"] || [istarget "i?86-*-mingw*"]
+    if { [istarget "i?86-*-cygwin*"] || [istarget "i?86-*-mingw*"]
 	 || [istarget "*-*-msdosdjgpp*"] || [istarget "*-*-go32*"] } {
 	return "additional_flags=-DSYMBOL_PREFIX=\"_\""
     } else {