From patchwork Wed Mar 4 19:33:34 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pedro Alves X-Patchwork-Id: 5457 Received: (qmail 114146 invoked by alias); 4 Mar 2015 19:33:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 114128 invoked by uid 89); 4 Mar 2015 19:33:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL, BAYES_00, SPF_HELO_PASS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 04 Mar 2015 19:33:37 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t24JXaVs011356 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 4 Mar 2015 14:33:36 -0500 Received: from brno.lan (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t24JXZds026204 for ; Wed, 4 Mar 2015 14:33:36 -0500 From: Pedro Alves To: gdb-patches@sourceware.org Subject: [pushed] Fix gdb.threads/thread-specific-bp.exp race Date: Wed, 4 Mar 2015 19:33:34 +0000 Message-Id: <1425497614-16522-1-git-send-email-palves@redhat.com> Gary stumbled on this: (gdb) PASS: gdb.threads/thread-specific-bp.exp: all-stop: continue to end info threads Id Target Id Frame * 1 Thread 0x7ffff7fdb700 (LWP 13717) "thread-specific" end () at /home/gary/work/archer/startswith/src/gdb/testsuite/gdb.threads/thread-specific-bp.c:29 (gdb) FAIL: gdb.threads/thread-specific-bp.exp: all-stop: thread start is gone info breakpoint The problem is that "...archer/startswith/src..." has a "start" in it, which matches the too-lax regex in the test. Rather than tweaking the regex, we can just remove the whole "info threads", like we removed similar ones in other files -- GDB nowadays does this implicitly already, so things should work without it. Thus removing this even improves testing here a bit. gdb/testsuite/ChangeLog: 2015-03-04 Pedro Alves * gdb.threads/thread-specific-bp.exp: Delete "info threads" test. --- gdb/testsuite/ChangeLog | 4 ++++ gdb/testsuite/gdb.threads/thread-specific-bp.exp | 13 ------------- 2 files changed, 4 insertions(+), 13 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 3f41178..6f97eda 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2015-03-04 Pedro Alves + + * gdb.threads/thread-specific-bp.exp: Delete "info threads" test. + 2015-03-04 Mark Kettenis * gdb.base/foll-fork.exp: Enable on *-*-openbsd*. diff --git a/gdb/testsuite/gdb.threads/thread-specific-bp.exp b/gdb/testsuite/gdb.threads/thread-specific-bp.exp index e167564..c4d8286 100644 --- a/gdb/testsuite/gdb.threads/thread-specific-bp.exp +++ b/gdb/testsuite/gdb.threads/thread-specific-bp.exp @@ -91,19 +91,6 @@ proc check_thread_specific_breakpoint {mode} { "Breakpoint .* end .* at .*" \ "continue to end" - # Force GDB to update the thread list. Otherwise, depending - # on target, GDB may not realize that the start thread has - # exited and thus not remove the thread specific breakpoint. - set test "thread start is gone" - gdb_test_multiple "info threads" $test { - -re "\[0-9\]+.*start.*$gdb_prompt $" { - fail $test - } - -re "$gdb_prompt $" { - pass $test - } - } - set test "thread-specific breakpoint was deleted" gdb_test_multiple "info breakpoint" $test { -re "thread $start_thre\n$gdb_prompt $" {