From patchwork Thu Jan 8 01:01:18 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrick Palka X-Patchwork-Id: 4559 Received: (qmail 22952 invoked by alias); 8 Jan 2015 01:01:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 22752 invoked by uid 89); 8 Jan 2015 01:01:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 X-HELO: mail-qa0-f54.google.com Received: from mail-qa0-f54.google.com (HELO mail-qa0-f54.google.com) (209.85.216.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 08 Jan 2015 01:01:28 +0000 Received: by mail-qa0-f54.google.com with SMTP id i13so5311791qae.13 for ; Wed, 07 Jan 2015 17:01:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=llbNC9scytStEmk5VnbEQGvWwOA/En30Ei3awhYfxRg=; b=Z3i9iszv2nkbdoHf0xH2gaiFL9lRhbe6N0a+qU/ZF0A4cktpW+G8EO8B8QG5ks6DHK XplUhA3hne8lOvh6ctPB5mwKD1/KDicMblqt1XHTgz6YXUyDWSYjaLlIRB3cmMJdjc0f +M1szhgiWInzMSNzglAV6sZ1AS/gbpaBL97vtrMIXDJFLgSUkGVxBsTwttqlFLYy23Lt lo6yUKx66h6Cff3NTmiOHrmtTgSgmoQei4mpsxKLENCs1ccsEUxhAJVtmq8fRgqrC3o5 D8iVb8Btj9/olgUuURfJIg7W2sjZDVsAX9EQUWWmgM3XL9QJ26TLbLObu6KtH88+Q7BO zWiQ== X-Gm-Message-State: ALoCoQkoq1ftbRJDnxzgy2LZ2wLOqRF8DRmCJeFhoR3V9FM4nw4rlZ8FZ4XAr4MzRfh2u2+WfPf9 X-Received: by 10.224.92.205 with SMTP id s13mr10163908qam.52.1420678885764; Wed, 07 Jan 2015 17:01:25 -0800 (PST) Received: from localhost.localdomain (ool-4353ac94.dyn.optonline.net. [67.83.172.148]) by mx.google.com with ESMTPSA id s9sm2669011qge.19.2015.01.07.17.01.24 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 07 Jan 2015 17:01:24 -0800 (PST) From: Patrick Palka To: gdb-patches@sourceware.org Cc: Patrick Palka Subject: [PATCH] Don't munge yacc's #line directives Date: Wed, 7 Jan 2015 20:01:18 -0500 Message-Id: <1420678878-14065-1-git-send-email-patrick@parcs.ath.cx> The #line directives within GDB's autogenerated yacc files (e.g. c-exp.c) are being munged by a dubious sed expression that is causing these directives to refer to nonexistent source files. As a result it is currently not possible to debug these source files at source level. The culprit sed expression was added by commit 954d8cae for non-obvious reasons. My guess is that the expression was added to work around a bug in ylwrap which has since been fixed upstream: if I revert the November 2014 update to ylwrap, commit be3046511, then the culprit sed line no longer causes the above mentioned issue. So this patch removes the culprit sed script since it does not seem needed anymore; the emitted #line directives look and work fine without it. gdb/ChangeLog: 2015-01-07 Patrick Palka * Makefile.in (.y.c): Don't munge yacc's #line directives. --- gdb/Makefile.in | 1 - 1 file changed, 1 deletion(-) diff --git a/gdb/Makefile.in b/gdb/Makefile.in index 31c8a4c..97d0045 100644 --- a/gdb/Makefile.in +++ b/gdb/Makefile.in @@ -1856,7 +1856,6 @@ po/$(PACKAGE).pot: force -e 's/\([ \t;,(]\)free\([ \t]*[&(),]\)/\1xfree\2/g' \ -e 's/\([ \t;,(]\)free$$/\1xfree/g' \ -e '/^#line.*y.tab.c/d' \ - -e "s/^\(#line.*\)`basename $<`/\1`echo $<|sed 's/\//\\\\\//g'`/" \ < $@.tmp > $@ rm -f $@.tmp .l.c: