diff mbox

Use standard_testfile in i386-bp_permanent.exp

Message ID 1417268930-13808-1-git-send-email-yao@codesourcery.com
State New, archived
Headers

Commit Message

Yao Qi Nov. 29, 2014, 1:48 p.m. UTC 
  This patch is to use standard_testfile in i386-bp_permanent.exp to replace
existing setting to testfile, srcfile and binfile.  So it fixes a problem
in i386-bp_permanent.exp in parallel testing.

$ make -j3 check TESTS='gdb.guile/scm-section-script.exp gdb.arch/i386-bp_permanent.exp'
....
gdb compile failed, /usr/bin/ld: cannot open output file x86/gdb/testsuite/gdb.arch/i386-bp_permanent: No such file or directory
collect2: error: ld returned 1 exit status

gdb/testsuite:

2014-11-29  Yao Qi  <yao@codesourcery.com>

	* gdb.arch/i386-bp_permanent.exp: Use standard_testfile.
---
 gdb/testsuite/gdb.arch/i386-bp_permanent.exp | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Pedro Alves Dec. 4, 2014, 5:18 p.m. UTC | #1 
On 11/29/2014 01:48 PM, Yao Qi wrote:
> This patch is to use standard_testfile in i386-bp_permanent.exp to replace
> existing setting to testfile, srcfile and binfile.  So it fixes a problem
> in i386-bp_permanent.exp in parallel testing.
> 
> $ make -j3 check TESTS='gdb.guile/scm-section-script.exp gdb.arch/i386-bp_permanent.exp'
> ....
> gdb compile failed, /usr/bin/ld: cannot open output file x86/gdb/testsuite/gdb.arch/i386-bp_permanent: No such file or directory
> collect2: error: ld returned 1 exit status
> 
> gdb/testsuite:
> 
> 2014-11-29  Yao Qi  <yao@codesourcery.com>
> 
> 	* gdb.arch/i386-bp_permanent.exp: Use standard_testfile.

Looks obviously correct to me.

Thanks Yao.

> -set testfile "i386-bp_permanent"
> -set srcfile i386-bp_permanent.c
> -set binfile ${objdir}/${subdir}/${testfile}
> +standard_testfile .c

(I think ".c" shouldn't be necessary.)


Thanks,
Pedro Alves
Yao Qi Dec. 5, 2014, 7:33 a.m. UTC | #2 
Pedro Alves <palves@redhat.com> writes:

> Looks obviously correct to me.
>
> Thanks Yao.
>
>> -set testfile "i386-bp_permanent"
>> -set srcfile i386-bp_permanent.c
>> -set binfile ${objdir}/${subdir}/${testfile}
>> +standard_testfile .c
>
> (I think ".c" shouldn't be necessary.)

Yeah, ".c" is removed and patch is pushed in.
diff mbox

Patch

diff --git a/gdb/testsuite/gdb.arch/i386-bp_permanent.exp b/gdb/testsuite/gdb.arch/i386-bp_permanent.exp
index 833b4ed..434e128 100644
--- a/gdb/testsuite/gdb.arch/i386-bp_permanent.exp
+++ b/gdb/testsuite/gdb.arch/i386-bp_permanent.exp
@@ -23,9 +23,7 @@  if { ![istarget "i?86-*-*"] && ![istarget "x86_64-*-*"] } then {
     return
 }
 
-set testfile "i386-bp_permanent"
-set srcfile i386-bp_permanent.c
-set binfile ${objdir}/${subdir}/${testfile}
+standard_testfile .c
 
 # some targets have leading underscores on assembly symbols.
 set additional_flags [gdb_target_symbol_prefix_flags]