From patchwork Wed Oct 22 05:26:27 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Kamensky X-Patchwork-Id: 3316 Received: (qmail 30544 invoked by alias); 22 Oct 2014 05:26:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 30403 invoked by uid 89); 22 Oct 2014 05:26:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pd0-f171.google.com Received: from mail-pd0-f171.google.com (HELO mail-pd0-f171.google.com) (209.85.192.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 22 Oct 2014 05:26:42 +0000 Received: by mail-pd0-f171.google.com with SMTP id ft15so2820038pdb.2 for ; Tue, 21 Oct 2014 22:26:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=AdpdJlmAGmdBeGYCzvZRgTsV79AFnn7+9dJOcG9te28=; b=PuqsrERPIQbG2+DN9XSPbKdvzmNtTzXh8B/JR9a7n0kXJ31pcoerbxdIte/5r4xjcd kiwnYLz3MmO+rVRkIimlBIiJJkSOuNroFM7q5SP0Ir2+xajRJRzzScZp/CJ8w5hhniZY RyIZVURPYDESEodB9rIgJ8U/eTY0dtgPZHIgHPls6zcZxuV1RfMTGDvpECdyp9t7D/xu rLDwaVy+JHfIvFkHEbEm+pLr3UKI9jN6Z7q8nFDj3umd48cLELXIzubsY7ul/Sth52Jb tTvZL7vJkqgbncwVGjR1aFqGux/vyoQtN4bkXvVuP6MqeT886SX0IIEGFW0y9asgJC8t /RYQ== X-Gm-Message-State: ALoCoQk1KzlG0fA8y/dy94Sae2giD4957aUPlVQteWyAQbIayjL7bc42BPesAfSOXEqKAjLTH1sY X-Received: by 10.70.10.33 with SMTP id f1mr40136541pdb.1.1413955600418; Tue, 21 Oct 2014 22:26:40 -0700 (PDT) Received: from kamensky-w530.hsd1.ca.comcast.net ([24.6.79.41]) by mx.google.com with ESMTPSA id i16sm13364690pdk.66.2014.10.21.22.26.39 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Oct 2014 22:26:39 -0700 (PDT) From: Victor Kamensky To: gdb-patches@sourceware.org, Yao Qi Cc: Andrew Pinski , victor.kamensky@linaro.org Subject: [PATCH V2 2/4] ARM: arm_breakpoint should be little endian form in case for arm BE8 Date: Tue, 21 Oct 2014 22:26:27 -0700 Message-Id: <1413955589-5054-3-git-send-email-victor.kamensky@linaro.org> In-Reply-To: <1413955589-5054-1-git-send-email-victor.kamensky@linaro.org> References: <1413955589-5054-1-git-send-email-victor.kamensky@linaro.org> tdep->arm_breakpoint, tdep->thumb_breakpoint, tdep->thumb2_breakpoint should be set le_ variants in case of arm BE8 code. Those instruciton sequences are writen to target with simple write_memory, without regarding gdbarch_byte_order_for_code. But in BE8 case even data memory is in big endian form, instructions are still in little endian form. Because of this issue there are many issues while running gdb test case in armv7b mode. For example gdb.arch/arm-disp-step.exp test fails because it gets SIGILL when displaced instrucion sequence reaches break instruction, which is in wrong byte order. Solution is to set tdep->xxx_breakpoint sequences in BE8 case (i.e when gdbarch_byte_order_for_code is BFD_ENDIAN_BIG. gdb/ChangeLog: 2014-10-21 Victor Kamensky * arm-linux-tdep.c (arm_linux_init_abi): Use info.byte_order_for_code to choose endianity of breakpoint instructions snippets. --- gdb/arm-linux-tdep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/arm-linux-tdep.c b/gdb/arm-linux-tdep.c index e3587f3..2e79658 100644 --- a/gdb/arm-linux-tdep.c +++ b/gdb/arm-linux-tdep.c @@ -1361,7 +1361,7 @@ arm_linux_init_abi (struct gdbarch_info info, linux_init_abi (info, gdbarch); tdep->lowest_pc = 0x8000; - if (info.byte_order == BFD_ENDIAN_BIG) + if (info.byte_order_for_code == BFD_ENDIAN_BIG) { if (tdep->arm_abi == ARM_ABI_AAPCS) tdep->arm_breakpoint = eabi_linux_arm_be_breakpoint;