Message ID | 1412082645-30629-1-git-send-email-yao@codesourcery.com |
---|---|
State | New |
Headers | show |
Yao Qi <yao@codesourcery.com> writes: > gdb/testsuite: > > 2014-09-30 Yao Qi <yao@codesourcery.com> > > * gdb.server/server-kill.exp: Skip it if the target is remote. Ping.
On 09/30/2014 02:10 PM, Yao Qi wrote: > I thought about different ways to handle remote target, for example: > > - use command ps on remote target to gdbserver pid, but it doesn't work > if we have multiple gdbserver instances during testing, > - port number can be regarded as an id to differentiate different > instances, but port number is unknown to each test case. Likewise, > we can't use 'pkill' due to the same reason. > - close the gdbserver channel, but gdbserver doesn't exit on the target, gdbserver will be the parent of the tested process. So how about tweaking the test program to do: int server_pid; int main () { server_pid = getppid (); } and then simply read "server_pid" out of the inferior ? Thanks, Pedro Alves
Pedro Alves <palves@redhat.com> writes: > gdbserver will be the parent of the tested process. So how about > tweaking the test program to do: > > int server_pid; > > int main () > { > server_pid = getppid (); > } > > and then simply read "server_pid" out of the inferior ? That is a good idea! Patch 2/3 is about this. Patch 1/3 is a clean up. Patch 3/3 is to fix a fail we've seen on target doesn't support tracepoint. *** BLURB HERE *** Yao Qi (3): Clean up server-kill.exp Get GDBserver pid on remote target Use command "monitor set debug 0" to check the connection gdb/testsuite/gdb.server/server-kill.c | 10 +++++++++- gdb/testsuite/gdb.server/server-kill.exp | 23 +++++++++++++++++------ 2 files changed, 26 insertions(+), 7 deletions(-)
Yao Qi <yao@codesourcery.com> writes: > That is a good idea! Patch 2/3 is about this. Patch 1/3 is a clean > up. Patch 3/3 is to fix a fail we've seen on target doesn't support > tracepoint. These three patches are pushed in.
diff --git a/gdb/testsuite/gdb.server/server-kill.exp b/gdb/testsuite/gdb.server/server-kill.exp index 5d31103..45af850 100644 --- a/gdb/testsuite/gdb.server/server-kill.exp +++ b/gdb/testsuite/gdb.server/server-kill.exp @@ -23,6 +23,11 @@ if {[skip_gdbserver_tests]} { return 0 } +# We can't get the pid of gdbserver on the remote target. +if [is_remote target] then { + return 0 +} + if { [prepare_for_testing ${testfile}.exp ${testfile}] } { return -1 }