Message ID | 1411631571-30769-1-git-send-email-yao@codesourcery.com |
---|---|
State | New |
Headers | show |
On 09/25/2014 08:52 AM, Yao Qi wrote: > performed. Then I check the callers of build_executable_own_libs, > and they are all skipped if isnative is false. It is reasonable to do > the same in dlopen-libpthread.exp too. Agreed. I think we should put an "error" call in build_executable_own_libs too, so that whoever adds the next test that uses this doesn't end up forgetting the same thing. Thanks, Pedro Alves
diff --git a/gdb/testsuite/gdb.threads/dlopen-libpthread.exp b/gdb/testsuite/gdb.threads/dlopen-libpthread.exp index f0e3358..265eb5d 100644 --- a/gdb/testsuite/gdb.threads/dlopen-libpthread.exp +++ b/gdb/testsuite/gdb.threads/dlopen-libpthread.exp @@ -13,7 +13,7 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. -if {![istarget *-linux*] || [skip_shlib_tests]} { +if {![isnative] || ![istarget *-linux*] || [skip_shlib_tests]} { return 0 }