diff mbox

Fix PR fortran/17237: bug in f-valprint.c

Message ID 1409680902-22975-1-git-send-email-sergiodj@redhat.com
State New
Headers show

Commit Message

Sergio Durigan Junior Sept. 2, 2014, 6:01 p.m. UTC
This commit fixes the PR mentioned in $subject.  It is about a set but
unused variable that refers to the output format of integer values
printed in Fortran.

This was probably a thinko (like most set-but-unused-vars), but it
could cause an internal error depending on the scenario.  I am sending
a testcase which triggers this error as well.

gdb/ChangeLog:
2014-09-02  Sergio Durigan Junior  <sergiodj@redhat.com>

	PR fortran/17237
	* f-valprint.c (f_val_print): Specify the correct print option to
	use when printing integer values.

gdb/testsuite/ChangeLog:
2014-09-02  Sergio Durigan Junior  <sergiodj@redhat.com>

	PR fortran/17237
	* gdb.fortran/print-formatted.exp: New file.
	* gdb.fortran/print-formatted.f90: Likewise.
---
 gdb/f-valprint.c                              |  2 +-
 gdb/testsuite/gdb.fortran/print-formatted.exp | 39 +++++++++++++++++++++++++++
 gdb/testsuite/gdb.fortran/print-formatted.f90 | 20 ++++++++++++++
 3 files changed, 60 insertions(+), 1 deletion(-)
 create mode 100644 gdb/testsuite/gdb.fortran/print-formatted.exp
 create mode 100644 gdb/testsuite/gdb.fortran/print-formatted.f90

Comments

Joel Brobecker Sept. 3, 2014, 6:28 a.m. UTC | #1
> gdb/ChangeLog:
> 2014-09-02  Sergio Durigan Junior  <sergiodj@redhat.com>
> 
> 	PR fortran/17237
> 	* f-valprint.c (f_val_print): Specify the correct print option to
> 	use when printing integer values.
> 
> gdb/testsuite/ChangeLog:
> 2014-09-02  Sergio Durigan Junior  <sergiodj@redhat.com>
> 
> 	PR fortran/17237
> 	* gdb.fortran/print-formatted.exp: New file.
> 	* gdb.fortran/print-formatted.f90: Likewise.

OK!

One minor suggestion:

> +gdb_test "print ii" " = 0xa" "print ii"

You don't really need the second "print ii" in the call to gdb_test,
I think. By default, the name of the test is the same as the test
itself. OK with me either way.
diff mbox

Patch

diff --git a/gdb/f-valprint.c b/gdb/f-valprint.c
index c7581a8..9a43cf3 100644
--- a/gdb/f-valprint.c
+++ b/gdb/f-valprint.c
@@ -349,7 +349,7 @@  f_val_print (struct type *type, const gdb_byte *valaddr, int embedded_offset,
 	  opts.format = (options->format ? options->format
 			 : options->output_format);
 	  val_print_scalar_formatted (type, valaddr, embedded_offset,
-				      original_value, options, 0, stream);
+				      original_value, &opts, 0, stream);
 	}
       else
 	{
diff --git a/gdb/testsuite/gdb.fortran/print-formatted.exp b/gdb/testsuite/gdb.fortran/print-formatted.exp
new file mode 100644
index 0000000..f4ecd5e
--- /dev/null
+++ b/gdb/testsuite/gdb.fortran/print-formatted.exp
@@ -0,0 +1,39 @@ 
+# Copyright (C) 2014 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+load_lib "fortran.exp"
+
+if { [skip_fortran_tests] } {
+    continue
+}
+
+standard_testfile .f90
+
+if { [prepare_for_testing $testfile.exp $testfile $srcfile {debug f90}] } {
+    return -1
+}
+
+if { ![runto MAIN__] } {
+    fail "runto MAIN__"
+    return -1
+}
+
+gdb_test "next" ".*" "go to the end of the program"
+
+gdb_test "set output-radix 16" \
+    "Output radix now set to decimal 16, hex 10, octal 20." \
+    "setting the output-radix to 16"
+
+gdb_test "print ii" " = 0xa" "print ii"
diff --git a/gdb/testsuite/gdb.fortran/print-formatted.f90 b/gdb/testsuite/gdb.fortran/print-formatted.f90
new file mode 100644
index 0000000..1c6c8d4
--- /dev/null
+++ b/gdb/testsuite/gdb.fortran/print-formatted.f90
@@ -0,0 +1,20 @@ 
+! Copyright 2014 Free Software Foundation, Inc.
+!
+! This program is free software; you can redistribute it and/or modify
+! it under the terms of the GNU General Public License as published by
+! the Free Software Foundation; either version 3 of the License, or
+! (at your option) any later version.
+!
+! This program is distributed in the hope that it will be useful,
+! but WITHOUT ANY WARRANTY; without even the implied warranty of
+! MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+! GNU General Public License for more details.
+!
+! You should have received a copy of the GNU General Public License
+! along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+program printformatted
+  integer :: ii
+
+  ii = 10
+end program printformatted