From patchwork Fri Aug 15 00:42:32 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yao Qi X-Patchwork-Id: 2397 Received: (qmail 30785 invoked by alias); 15 Aug 2014 00:46:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 30765 invoked by uid 89); 15 Aug 2014 00:46:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL, BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 15 Aug 2014 00:46:38 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1XI5f8-0006qU-M1 from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Thu, 14 Aug 2014 17:46:34 -0700 Received: from SVR-ORW-FEM-06.mgc.mentorg.com ([147.34.97.120]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Thu, 14 Aug 2014 17:46:34 -0700 Received: from qiyao.dyndns.org.com (147.34.91.1) by SVR-ORW-FEM-06.mgc.mentorg.com (147.34.97.120) with Microsoft SMTP Server id 14.2.247.3; Thu, 14 Aug 2014 17:46:33 -0700 From: Yao Qi To: Subject: [PATCH] Skip tfile.exp if unable to generate trace file Date: Fri, 15 Aug 2014 08:42:32 +0800 Message-ID: <1408063352-14658-1-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 X-IsSubscribed: yes I added proc generate_tracefile in this patch https://sourceware.org/ml/gdb-patches/2014-03/msg00591.html but tfile.exp isn't skipped as changelog entry said: * gdb.trace/tfile.exp: Skip the test if generate_tracefile return 0. it is a mistake in test I made at the last minute. Patch below fixed it. Patch is pushed in. gdb/testsuite: 2014-08-15 Yao Qi * gdb.trace/tfile.exp: Return -1 if generate_tracefile returns false. --- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/gdb.trace/tfile.exp | 1 + 2 files changed, 6 insertions(+) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 1be9268..18930a0 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,5 +1,10 @@ 2014-08-15 Yao Qi + * gdb.trace/tfile.exp: Return -1 if generate_tracefile returns + false. + +2014-08-15 Yao Qi + * gdb.cp/casts.exp: Set print symbol off. * gdb.cp/class2.exp: Likewise. * gdb.cp/overload.exp: Likewise. diff --git a/gdb/testsuite/gdb.trace/tfile.exp b/gdb/testsuite/gdb.trace/tfile.exp index 54648b8..c8fd01c 100644 --- a/gdb/testsuite/gdb.trace/tfile.exp +++ b/gdb/testsuite/gdb.trace/tfile.exp @@ -52,6 +52,7 @@ remote_file target delete $tfile_error if { ![generate_tracefile $binfile] } { unsupported "Unable to generate trace file" + return -1 } if {!$purely_local} {